Message-ID: <46FAC57A.3090309@tiscali.nl>
Date: Wed, 26 Sep 2007 22:47:54 +0200
From: roel <12o3l@tiscali.nl>
User-Agent: Thunderbird 2.0.0.6 (X11/20070728)
MIME-Version: 1.0
To: Guillaume Chazarain <guichaz@yahoo.fr>
CC: Andrew Morton <akpm@linux-foundation.org>,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 7/8] taskstats: fix stats->ac_exitcode to work on threads
 and	use group_exit_code
References: <20070926162800.29434.67786.stgit@cheypa.inria.fr> <20070926162831.29434.29622.stgit@cheypa.inria.fr>
In-Reply-To: <20070926162831.29434.29622.stgit@cheypa.inria.fr>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1216
Lines: 41

Guillaume Chazarain wrote:

[...]

> @@ -65,13 +65,15 @@ void bacct_add_tsk(struct taskstats *stats, struct task_struct *tsk)
>  void bacct_fill_threadgroup(struct taskstats *stats, struct task_struct *tsk,
>  			    bool tg_stats)
>  {
> +	int group_exit_code;
> +
>  	fill_wall_times(stats, tsk);
>  
> -	if (thread_group_leader(tsk)) {
> -		stats->ac_exitcode = tsk->exit_code;
> -		if (tsk->flags & PF_FORKNOEXEC)
> -			stats->ac_flag |= AFORK;
> -	}
> +	if (thread_group_leader(tsk) && ((tsk->flags & PF_FORKNOEXEC)))

	if (thread_group_leader(tsk) && (tsk->flags & PF_FORKNOEXEC))

> +		stats->ac_flag |= AFORK;
> +
> +	group_exit_code = tg_stats ? tsk->signal->group_exit_code : 0;
> +	stats->ac_exitcode = group_exit_code ? : tsk->exit_code;

Isn't this just confusing? why not

	if (tg_stats) {
		group_exit_code = tsk->signal->group_exit_code;
		stats->ac_exitcode = group_exit_code;
		
	} else {
		group_exit_code = 0;
		stats->ac_exitcode = tsk->exit_code;
	}
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/