Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230412144821.5716-1-jorge.lopez2@hp.com> <f91ee2ff-3a24-4e2b-bf68-f1c5400b7462@t-8ch.de>
In-Reply-To: <f91ee2ff-3a24-4e2b-bf68-f1c5400b7462@t-8ch.de>
From:   Jorge Lopez <jorgealtxwork@gmail.com>
Date:   Fri, 14 Apr 2023 15:00:02 -0500
Message-ID: <CAOOmCE-pfQa8_yn7zOkt9dBR9VpnnJF=dsvByZqLM=qcvoEx+Q@mail.gmail.com>
Subject: Re: [PATCH v9] HP BIOSCFG driver - Documentation
To:     thomas@t-8ch.de
Cc:     hdegoede@redhat.com, platform-driver-x86@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Thomas,

On Fri, Apr 14, 2023 at 10:27=E2=80=AFAM <thomas@t-8ch.de> wrote:
>
> Hi Jorge,
>
> On 2023-04-12 09:48:21-0500, Jorge Lopez wrote:
> > [..]
> >
> > +What:                /sys/class/firmware-attributes/*/authentication/S=
PM/statusbin
> > +Date:                March 29
> > +KernelVersion:       5.18
> > +Contact:     "Jorge Lopez" <jorge.lopez2@hp.com>
> > +Description: 'statusbin' is a read-only file that returns 'status' inf=
ormation
> > +             in binary format. This file provides a mechanism for comp=
onents
> > +             downstream (e.g. Recovery Agent) can read the status and =
public
> > +             key modulus.
>
> This is still missing docs about how to interpret the contents of the
> "statusbin" file.
>
> "components downstream" -> userspace.
>

I will provide the details in Version 10.   Additionally, I am working
with the architect to understand the need for 'statusbin' in their
upcoming features.

>
> I think we can start with the code review.
>

I will send all files with Version 10.   To aid in the review process,
I will keep all ..c in separate reviews.  It is less confusing that
way since there is commonality between them

> Could you also provide a sample of the attribute files?
> I'm especially curious about the different instances of the sure-start
> attributes, including current_value, possible_values and the auditlog
> properties.
>

What type of sample are you looking for.?   I can provide you with a
tree display of all attributes and some output samples for different
attribute types.
I will include sure-start  attributes, including current_value,
possible_values and the audit log properties.  Please let me know if
there is anything else you want to see.

> Also is the userspace component for this published somewhere?
> If so it would be useful to refer to it from the commit message.

Linux components are under development and not published yet.  The
only linux component at this time is the driver (hp bioscfg).
The only published components are under Windows ONLY.

>
> Thanks,
> Thomas