Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 14 Apr 2023 13:07:02 -0700
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Mel Gorman <mgorman@techsingularity.net>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Vlastimil Babka <vbabka@suse.cz>,
        Michal Hocko <mhocko@suse.com>,
        Oscar Salvador <OSalvador@suse.com>,
        Yuanxi Liu <y.liu@naruida.com>,
        David Hildenbrand <david@redhat.com>,
        Linux-MM <linux-mm@kvack.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: page_alloc: Assume huge tail pages are valid when
 allocating contiguous pages
Message-ID: <20230414200702.GB4712@monkey>
References: <20230414082222.idgw745cgcduzy37@techsingularity.net>
 <20230414190630.GA4712@monkey>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230414190630.GA4712@monkey>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?iYZPoputz7LDl/lyPbVF9mpa7kEgLwXruA7OTHU6h+XpA7O4xDQKs6WvhiPf?=
 =?us-ascii?Q?61XQanC6wr1Fm0DiGBApALYh5dqj4j23/m5EtNNlgPQdP8s/FzCHsDHNwzlM?=
 =?us-ascii?Q?YvCxdUblcLJynZqJ0cpjY+PrR4DEZCXLQs7BZ2y2eJMY6Ycvd76wEWANxrlQ?=
 =?us-ascii?Q?G7fQTYWyt/Z5l6Rj2j7tqEwIyQn30f9oAVn4HZG0TOEJV/4Sh18TBlvnvdRi?=
 =?us-ascii?Q?852APjgSGEjSfDxjVwnpXb8Bg3IAISNzP/mEzEY2+47rJyYXBZpPS4Ft0PVZ?=
 =?us-ascii?Q?EQnafazYjHZOlUo6t4H95IBNaoAJOARffEmsrg9mwq4tezA/ixux2SivuLXM?=
 =?us-ascii?Q?WOkAcwIinqMvhrMPY7uOGB8zvzkGRqsjYMctOQvzR7DHi91Q0rM6mENwTS9l?=
 =?us-ascii?Q?wncCSr8NKZuLmWW95pfyToutrVaLThdsn0XZJ4Gcswiw8qk0PeloRVc9TlM4?=
 =?us-ascii?Q?ePPzFSVzSrz3KdiE9hEeNF7Eaxdzp/g91mf0y+d5ZCNEnKbU/UkV+F+ZPH28?=
 =?us-ascii?Q?srEePPVRSFA90oFPMyxFR+UZCJKTu0cmR2l9OcBno8E0b8VaRnpFMnUyr9cj?=
 =?us-ascii?Q?CFas1/Eh7bXIjDNValST5BCoDEo2p+2w1b2t398JRnJOE0gfosAe2YW2uHQO?=
 =?us-ascii?Q?Vmuk83lLsR+3lE04fw8zbpNOBbY5LRaM0iT436aaaGUC8y+I5w9rHsURSiRf?=
 =?us-ascii?Q?oTgDRkK2pjj5SUWH5Ffhv6JUa6qKD/lrv7GB/WNYQXjSM7SkBbEc4064CgqM?=
 =?us-ascii?Q?guu4VB39YHiUTZscfQNrVNoXOKws1q9TKHktRr50yhQs2yv3QrqH2vXFVkJf?=
 =?us-ascii?Q?cxKNxOMaTuJpMAwm6XaBgtJKec178chhq0f1jRUPcldhoZafhld+EeLfTJyr?=
 =?us-ascii?Q?EuUKHAzt174YLh4DNzB7PdJEbnLTwTcxZvbrWegMmdn9R/IpMAAKS9QqFrte?=
 =?us-ascii?Q?oyFOgaD6GblWQFspi4B82un5pjVA2MhN4CkjNdQoOVtr+YOwM8HxV7rgaHvY?=
 =?us-ascii?Q?4BlTtqZOeHgQ5hXrQFWFFZ3Y6yqenkbPz+VwXqNO7nmmJvhEEsVxkr9+9y7z?=
 =?us-ascii?Q?2x4JLY9lxyvHoOeTrFjTdP/yO4khBSHZ9ramn5lFoAmoNbtnNi4/TAONpS96?=
 =?us-ascii?Q?Fo86lOLz2sQSrh+KNSMBy6ldaJzMZYfy2e6VTJosxkccz1YaA/b6iBEQL4yT?=
 =?us-ascii?Q?fa0UNXHfqNwRKfkGX7yaav2QYHqj/fwFfTISDnrfCcuJ/8aRLd1zZiYfZjN8?=
 =?us-ascii?Q?KqsSM2o2nddrBQBMZFj6MHacuktbupJEOCvNyQY0F/wTkf74WdSZld44wg9u?=
 =?us-ascii?Q?nfMhFmh4FKN9pNWpBQUpf5SWmzjNXiy+Fkua+UTFBLyOBTyQFyjsf02omNn1?=
 =?us-ascii?Q?rH2zCDEjyofmrhb9FXN87uPlrd/p5YIVPesaJy03hxF4I01cBiVTDr6llzUI?=
 =?us-ascii?Q?4WRhSnUfi8fZQFXDyd3lM/x3v2Rhwkm1lDsEi9LFKX5JYZmDfjVCjmxo1q82?=
 =?us-ascii?Q?8F3YWQ6fM5BEGyv08TG+IZ3E718rDYeGKKj2dw8DVFE1+I6LxmwsNda3WGW3?=
 =?us-ascii?Q?7/7jjX6uRaxFNwdsnl4S2iYuXA2NEL1bHmgiH0ve?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?yKWdMAJyCX2OptxLGGGdyOoxfnKdCfF5PabHUb+sULyFlOlSF7NA0vnoup3+?=
 =?us-ascii?Q?D9AGLVSEKxMQaODbJka65DoqSeUlB7I0V2FUSPHofZdJGpJWayXM8jNIXQ+m?=
 =?us-ascii?Q?AvnaBlJtgmTAJ4VxNEv/7NNgBamLdjVqpSp/bsGu/wjEv8phFJ/gHEsWzVkE?=
 =?us-ascii?Q?yYPrVsCkizwbum3QP56J0br1oVZ5nGtm6IKnaipeLdtEh+K4r5expD/HDHx+?=
 =?us-ascii?Q?lThTOL6EiMci/xceeahVaYTcOeU0AothwBNEykvpTtE6z5hzPyVeRIEhZauq?=
 =?us-ascii?Q?/xVKbPa8ECpyfsB92ZnZCAwdSZOBgFY5EYI1yhaHsP6w73/69t+O5mKpzowx?=
 =?us-ascii?Q?rjiaf27KVC60//00lHOWtjlcysppRCjMCqUZHpAUGzYXCtE/EmhOuYurr8hV?=
 =?us-ascii?Q?2IinmSOMnlPPwZMuaw25kEM3oRM9GuJDh0Tz6lbvxFZVhsvocSyhmRbARdoM?=
 =?us-ascii?Q?uju5AHsjxvHEOVfj0iFPNoJvPfQY4A3rOpiKVReV6hVo9cXVZ34Ph8/rUVyt?=
 =?us-ascii?Q?V+h61Fkzv+J2HEQDJcOVTjGsblEsaBu60uE/dJlJhoWPv5+uGYE8QHMRRstL?=
 =?us-ascii?Q?SDlreVqj3q0ld7e//giQX6H5gu5dl0EoVkPVzvnTacmZIAnHtuHuyRcB6ilS?=
 =?us-ascii?Q?2MdRKNoIPpiby5Nh2TcTB/Ypm0xlGXqIUFz+j3AS2nFiBDYHmzChe5ppHBFG?=
 =?us-ascii?Q?hHoO+Cgmi1Nu2t2WlgKS/FXI7xeaqVTEPwDnBC3uUhRLMkdxMQZRzBKkTg+a?=
 =?us-ascii?Q?MqF9l2Pq1W71Jo4uHQBp65zegSrVOsnzR9+WfDeNJZts/zHaAg87LaDq9BBo?=
 =?us-ascii?Q?erce6jCUJOwsbp2wbiMiDI557tuvRShwBv4xFxwCDUYD7VQg/i4IczD2/dMU?=
 =?us-ascii?Q?eyov8hobYnWJ+hHuDTVn/1DgmORFkMdmSUoLezIN1EM7jf1Au6tH4Bcp4o8k?=
 =?us-ascii?Q?gzaR4GRla7AccTeAeZkpgdaUIrHsy/DOkNZnXl3AygJoaQchOLUSb/BRadrj?=
 =?us-ascii?Q?QZVW?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dc920212-686a-41f0-ac43-08db3d23d1b4
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2023 20:07:05.6839
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ukbkD7MNzS102WUKWSohSOr6wEjvvu1/Nn8L62lm664mM1iUDciKcCb+UMj3yMm8Y1DkGtbhQIQ0YC1lgVhNDQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB6982
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-04-14_12,2023-04-14_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0
 adultscore=0 spamscore=0 suspectscore=0 bulkscore=0 mlxlogscore=999
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2303200000 definitions=main-2304140177
X-Proofpoint-GUID: M8g-GPmGbKlXBGt2LglIIRLJcyjqRGvB
X-Proofpoint-ORIG-GUID: M8g-GPmGbKlXBGt2LglIIRLJcyjqRGvB
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 04/14/23 12:06, Mike Kravetz wrote:
> Thanks Mel!
> Apologies for not noticing when the bug was posted to the list.  Otherwise,
> I would have jumped on it.
> 
> On 04/14/23 09:22, Mel Gorman wrote:
> > A bug was reported by Yuanxi Liu where allocating 1G pages at runtime is
> > taking an excessive amount of time for large amounts of memory. Further
> > testing allocating huge pages that the cost is linear i.e. if allocating
> > 1G pages in batches of 10 then the time to allocate nr_hugepages from
> > 10->20->30->etc increases linearly even though 10 pages are allocated at
> > each step. Profiles indicated that much of the time is spent checking the
> > validity within already existing huge pages and then attempting a migration
> > that fails after isolating the range, draining pages and a whole lot of
> > other useless work.
> > 
> > Commit eb14d4eefdc4 ("mm,page_alloc: drop unnecessary checks from
> > pfn_range_valid_contig") removed two checks, one which ignored huge pages
> > for contiguous allocations as huge pages can migrate. While there may be
> > value on migrating a 2M page to satisfy a 1G allocation, it's pointless
> > to move a 1G page for a new 1G allocation or scan for validity within an
> > existing huge page.
> 
> eb14d4eefdc4 was the last patch in Oscar's series "Make alloc_contig_range
> handle Hugetlb pages".
> https://lore.kernel.org/linux-mm/20210419075413.1064-1-osalvador@suse.de/
> 
> It seems bailing out of alloc_contig_range when experiencing hugetlb
> pages was an actual issue as the cover letter says:
> 

David correctly pointed out that I was confusing alloc_contig_range and
alloc_contig_pages.  Sorry!

-- 
Mike Kravetz