Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 14 Apr 2023 22:36:02 +0200
From:   Thomas =?utf-8?Q?Wei=C3=9Fschuh?= <thomas@t-8ch.de>
To:     Jorge Lopez <jorgealtxwork@gmail.com>
Cc:     hdegoede@redhat.com, platform-driver-x86@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9] HP BIOSCFG driver - Documentation
Message-ID: <0b92276d-09e5-4308-b4c1-4519ac2ac65d@t-8ch.de>
References: <20230412144821.5716-1-jorge.lopez2@hp.com>
 <f91ee2ff-3a24-4e2b-bf68-f1c5400b7462@t-8ch.de>
 <CAOOmCE-pfQa8_yn7zOkt9dBR9VpnnJF=dsvByZqLM=qcvoEx+Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAOOmCE-pfQa8_yn7zOkt9dBR9VpnnJF=dsvByZqLM=qcvoEx+Q@mail.gmail.com>
Precedence: bulk

On 2023-04-14 15:00:02-0500, Jorge Lopez wrote:
> On Fri, Apr 14, 2023 at 10:27 AM <thomas@t-8ch.de> wrote:
> > On 2023-04-12 09:48:21-0500, Jorge Lopez wrote:
> > > [..]
> > >
> > > +What:                /sys/class/firmware-attributes/*/authentication/SPM/statusbin
> > > +Date:                March 29
> > > +KernelVersion:       5.18
> > > +Contact:     "Jorge Lopez" <jorge.lopez2@hp.com>
> > > +Description: 'statusbin' is a read-only file that returns 'status' information
> > > +             in binary format. This file provides a mechanism for components
> > > +             downstream (e.g. Recovery Agent) can read the status and public
> > > +             key modulus.
> >
> > This is still missing docs about how to interpret the contents of the
> > "statusbin" file.
> >
> > "components downstream" -> userspace.
> >
> 
> I will provide the details in Version 10.   Additionally, I am working
> with the architect to understand the need for 'statusbin' in their
> upcoming features.

If the userspace component is not ready maybe this can be delayed for a
future patchset?
The basic features should already be useful with a generic client like
fwupd.
Doing it in steps should be faster both in development and wall time.

> > I think we can start with the code review.
> >
> 
> I will send all files with Version 10.   To aid in the review process,
> I will keep all ..c in separate reviews.  It is less confusing that
> way since there is commonality between them
> 
> > Could you also provide a sample of the attribute files?
> > I'm especially curious about the different instances of the sure-start
> > attributes, including current_value, possible_values and the auditlog
> > properties.
> >
> 
> What type of sample are you looking for.?   I can provide you with a
> tree display of all attributes and some output samples for different
> attribute types.

That sounds great.

> I will include sure-start  attributes, including current_value,
> possible_values and the audit log properties.  Please let me know if
> there is anything else you want to see.

I want to get a feeling for the exposed bios settings and how the
sure-start stuff works.

> > Also is the userspace component for this published somewhere?
> > If so it would be useful to refer to it from the commit message.
> 
> Linux components are under development and not published yet.  The
> only linux component at this time is the driver (hp bioscfg).
> The only published components are under Windows ONLY.

Maybe mention this in the commit message.

Also it would be useful to test the new driver with fwupd which is the
existing userspace user of this ABI.
Just to make sure that nothing is obviously broken there.
(And mention this in the commit message)

Thomas