Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 14 Apr 2023 15:17:39 -0700
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Peter Xu <peterx@redhat.com>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        Axel Rasmussen <axelrasmussen@google.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        David Hildenbrand <david@redhat.com>,
        Nadav Amit <nadav.amit@gmail.com>,
        Andrea Arcangeli <aarcange@redhat.com>,
        linux-stable <stable@vger.kernel.org>
Subject: Re: [PATCH 1/6] mm/hugetlb: Fix uffd-wp during fork()
Message-ID: <20230414221739.GA54118@monkey>
References: <20230413231120.544685-1-peterx@redhat.com>
 <20230413231120.544685-2-peterx@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230413231120.544685-2-peterx@redhat.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?sYOfmrtEs1TuR1ed+lIOsRR7d7L2Ba8f5OVDX4+RhMXqPi/o2X7+BDqX2DZb?=
 =?us-ascii?Q?nmqgtDCakfZDxzJGeeTAgNwilpGNv6DYq0tofMXGa9gH55C5RNJRKDeTu719?=
 =?us-ascii?Q?f5+iu4JwaIB7oG5cXu1w4iQNEnGNbSf5hnneF4HpZmbq2pNRO73W17SgmWQa?=
 =?us-ascii?Q?b2LE56cs+22udeQKc8QJJrCpaKGm+maZzY18Pu5l9jbv8wpvFCm/gcfvmKaB?=
 =?us-ascii?Q?RWT/ybIdVQibfpIT8eF5zCH1x+oxDrtW1nbGrb4fYwfVymajBYvvrGRegVIn?=
 =?us-ascii?Q?63tbjb9CJvzssEMkTMqDzWcC763sovheUc2QRuG4abbYrU3DrO9lnxQ7QK9O?=
 =?us-ascii?Q?5/hmuT39LNqeKCyhWadCdtdDEEbPlkt8rorGliQuG47l83H2EZmHr5oe5Ygh?=
 =?us-ascii?Q?NU2t6hpqBYAxu3jz/ZvUl4s6njQiud8Z6fR1dglI7j5pczhHnLmzVEvCW386?=
 =?us-ascii?Q?Ss6pgRF4lagH3Xip35IfZSk9twoWMpB9v5CaiLz153JETL939PAAXn3gZLdT?=
 =?us-ascii?Q?vygHl+OmG5iC64CmDbMi3Zx9UDAcbgCMv5uJD4K+3TE3dOPxZiS4zqZfIuaI?=
 =?us-ascii?Q?p8SPwcRVHwP+PE1VCvqcpMGqgNpEUZ8IDPmi5natHYmSG9arXueUhKD/S2nU?=
 =?us-ascii?Q?UTRKsbK0wACiq9137TwBbYthWj1QJkdY7XqwB1ObEEew2OF2EzhkGmHFoamf?=
 =?us-ascii?Q?pBYh4N4HZzLox1u9yoOEh3r/JAXKNN+1JEmIPhusQyM6iirDElsrNRJm/QLD?=
 =?us-ascii?Q?5qGE/Z9iGv9G7JXFraDdVBP+UWMNkpFpXLYf1RKmmIpwpOs4IJB3YlWUMGZE?=
 =?us-ascii?Q?lCUurpRHuWyd7Imv+WzzU8jESS6TigBwkAFhEY0ik11BFdSynNEU1H1aV16r?=
 =?us-ascii?Q?J8LLLXBva9Aol3XOu1clbi+pO6fJ2Hx/GuxkHU1NTm6mp9cpDufBUWQAvJQH?=
 =?us-ascii?Q?SXLq+OPtg46Sf+ZyWdTGhmHV6QVJhQpBaT/cUtpbMvX89CMtAHcHQZNNx7w1?=
 =?us-ascii?Q?OeMu8lRfo87gSFLW2Y7Wx31smHqE06wVV7DvpVSHVKhgUsXmXMZrriG2Yoyk?=
 =?us-ascii?Q?+okZtoqdpx0jn45TPyxmrtzVUqEtu9WxL9eCoWnBlvfpVXe0UtbGaXneqf/u?=
 =?us-ascii?Q?YX3uez/+qIgRTgWSglN9ubTJRCYps/0nhAu1jHrWnsxer1o136oLP/wkcMeS?=
 =?us-ascii?Q?lVGeC8MaCAUOwKjuD5UVJ9aWZFgu85oRMhZKby+GP4dAcE6F0nxkCVRiNDLW?=
 =?us-ascii?Q?ja9L4NCJCVBl9bFpKIvG+0ffqV7wAoV9pqCGqKSUJ4/GxAwBPb7aLMYohBZN?=
 =?us-ascii?Q?cmCr5SKg7+1osFUIPIWQU4gE2Y33fsnVI0QvwQVjuwjXf8uLEBllltfrSTY0?=
 =?us-ascii?Q?Z7/2qJr/6aqr//qyGvVKnioo/L1KyhXz3p0dr6jsKJpZQZffZtkAXm1DAVHM?=
 =?us-ascii?Q?5xFZkAra5brhIPls3QZWPyj1TafIGqKRWs9eURwEZe/8U888ryKa83cUCubW?=
 =?us-ascii?Q?MXBwv6in6q33BpgzAwoPZleHYOW4P3jli6t3FPt4bkhw1TLQ0CluJ25Kh1Xg?=
 =?us-ascii?Q?oGeL/xrtyZ4aeZWnG1DM9RxIMFTDA6LSpWB+V8bD?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?q4aFjsjFs1avmHyVQnFcBS6fFQf/1Az2FLe5L/URhB2/dKeg85QrW8DnaW1w?=
 =?us-ascii?Q?hy1AA6rb6uAZhd0Uk2cr4OT/l3SaKNnCRnmMQY9cBJGVTMNaaSKd++wQE7cf?=
 =?us-ascii?Q?pGfKpc0Eq2yUZPK8RX9FS7iI+fbatDS4hGSP6pIpZ8yY5DTnkXCsmY/9Ii8Y?=
 =?us-ascii?Q?G9hgoDBzIY9fROcHjk1SPrhYzGC4rCpew7B3Q5T8TWvWtOauaqvaaavuk5IR?=
 =?us-ascii?Q?qPT1aRf2AIONqERaJpzgwZPbUa4m8hCl09XPWZzJMbdm+OazgYreM5ibO4CY?=
 =?us-ascii?Q?U69GHalJqdpAxav4IF6HVwKqcg6Af/7uUgjvVAFDXRPi/IEydz86AtDYGVOn?=
 =?us-ascii?Q?7onTHKSoGjZlgB2u/0S4YEGKgdh96iwEwl3ZV8QS/iBUXLW8g91G7rW/2+B8?=
 =?us-ascii?Q?IEL8I0dAxO86L2hPXWhwmyXUrDdMUlWx21eWCau8BDEMSf4rch01/phw3bPu?=
 =?us-ascii?Q?1zQCEaQMes89/lZjLQeMwqw5a7KJTlubFFaq18nKKU7Db1fYzYmZXxwLkbd2?=
 =?us-ascii?Q?oaGW5HXAC0WW/b0DjEbgZmd79RNDd2xMa1V0VhfUo1zID8Rok0GlWNnOxtdC?=
 =?us-ascii?Q?pdo5AFqDJ1NkSAmXqcvlVq5+27swG5k/mCft8SoC7C54lrOgpyU8CllgCWGt?=
 =?us-ascii?Q?nwWM1Jq7AGPy9qkYghnN72rLuBppWNu54YRWk7Dy0czvlx3/Rq17P+v8+7a5?=
 =?us-ascii?Q?B66/0iIrAru8qCdmoFk44L21V8tw7uQ/jKou7QLn5QL8W9elrnvhMgWrElBU?=
 =?us-ascii?Q?XKZuvkTGGRmkpSqCNnIO5/BE7jF1lqiZArQuMkVct2xYnXix47/p5mDSwwFF?=
 =?us-ascii?Q?RvQLp5G4o92avsvMUn2y280RH7UbjtDdo1yJ/pYZq1DaKQCy9K+sSTBmf3dD?=
 =?us-ascii?Q?iedPYSgj0qf/iPl7eBPi+gR9ssQBYrOol3OO9zSDcMd7pljnDrLYZdx7MehB?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aec8bbcc-1f03-4d97-3271-08db3d3610dd
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2023 22:17:42.6290
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eeGa5xCQ8DTxaIlBNKdAWkTUqji/WudjEIU7CPiVHGUIdhSTbmBOG4FUHjalBx0yCcFCaX6KMxc0LS1UNM4vvg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR10MB5633
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-04-14_14,2023-04-14_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=530
 phishscore=0 mlxscore=0 malwarescore=0 suspectscore=0 bulkscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2303200000 definitions=main-2304140195
X-Proofpoint-GUID: HZM8BhWN1UfjqOf6wuTWDjpCVAJDe6Q7
X-Proofpoint-ORIG-GUID: HZM8BhWN1UfjqOf6wuTWDjpCVAJDe6Q7
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 04/13/23 19:11, Peter Xu wrote:
> There're a bunch of things that were wrong:
> 
>   - Reading uffd-wp bit from a swap entry should use pte_swp_uffd_wp()
>     rather than huge_pte_uffd_wp().

That was/is quite confusing to me at least.

> 
>   - When copying over a pte, we should drop uffd-wp bit when
>     !EVENT_FORK (aka, when !userfaultfd_wp(dst_vma)).
> 
>   - When doing early CoW for private hugetlb (e.g. when the parent page was
>     pinned), uffd-wp bit should be properly carried over if necessary.
> 
> No bug reported probably because most people do not even care about these
> corner cases, but they are still bugs and can be exposed by the recent unit
> tests introduced, so fix all of them in one shot.
> 
> Cc: linux-stable <stable@vger.kernel.org>
> Fixes: bc70fbf269fd ("mm/hugetlb: handle uffd-wp during fork()")
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
>  mm/hugetlb.c | 26 ++++++++++++++++----------
>  1 file changed, 16 insertions(+), 10 deletions(-)

No issues except losing information in pte entry as pointed out by Mika.

-- 
Mike Kravetz