Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762576AbXIZVId (ORCPT ); Wed, 26 Sep 2007 17:08:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757466AbXIZVIY (ORCPT ); Wed, 26 Sep 2007 17:08:24 -0400 Received: from smtp-out1.tiscali.nl ([195.241.79.176]:60040 "EHLO smtp-out1.tiscali.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756997AbXIZVIX (ORCPT ); Wed, 26 Sep 2007 17:08:23 -0400 Message-ID: <46FACA43.90303@tiscali.nl> Date: Wed, 26 Sep 2007 23:08:19 +0200 From: roel <12o3l@tiscali.nl> User-Agent: Thunderbird 2.0.0.6 (X11/20070728) MIME-Version: 1.0 To: Matthew Wilcox CC: linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] dmapool: Validate parameters to dma_pool_create References: <20070926185757.GM3899@parisc-linux.org> <11908332793750-git-send-email-willy@linux.intel.com> <46FAB75D.9020800@tiscali.nl> <20070926214022.GA14710@linuxntel.com> In-Reply-To: <20070926214022.GA14710@linuxntel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 820 Lines: 18 Matthew Wilcox wrote: > On Wed, Sep 26, 2007 at 09:47:41PM +0200, roel wrote: >> The brackets in the first if/else are not required, and you could combine the two statements: > > You mean braces, not brackets. And I find this little fetish of yours > highly disturbing. I prefer to use braces, and will continue to do so, > regardless of your nitpicking. Well as you say it, you like the braces, so it appears to be your fetish. Of course you don't have to make any changes, I am just reporting them cause they aren't needed. No need for the offensive tone either. Roel - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/