Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761483AbXIZVKW (ORCPT ); Wed, 26 Sep 2007 17:10:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756438AbXIZVKJ (ORCPT ); Wed, 26 Sep 2007 17:10:09 -0400 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:56240 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1754650AbXIZVKI (ORCPT ); Wed, 26 Sep 2007 17:10:08 -0400 Date: Wed, 26 Sep 2007 14:10:08 -0700 (PDT) Message-Id: <20070926.141008.25425420.davem@davemloft.net> To: willy@linux.intel.com Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] Avoid taking waitqueue lock in dmapool From: David Miller In-Reply-To: <11908332791719-git-send-email-willy@linux.intel.com> References: <20070926185757.GM3899@parisc-linux.org> <11908332791719-git-send-email-willy@linux.intel.com> X-Mailer: Mew version 5.1.52 on Emacs 21.4 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 704 Lines: 18 From: Matthew Wilcox Date: Wed, 26 Sep 2007 15:01:16 -0400 > With one trivial change (taking the lock slightly earlier on wakeup > from schedule), all uses of the waitq are under the pool lock, so we > can use the locked (or __) versions of the wait queue functions, and > avoid the extra spinlock. > > Signed-off-by: Matthew Wilcox This one looks good to me: Acked-by: David S. Miller - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/