Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   SeongJae Park <sj@kernel.org>
To:     "Paul E . McKenney" <paulmck@kernel.org>
Cc:     SeongJae Park <sj@kernel.org>,
        Matthew Wilcox <willy@infradead.org>,
        akpm@linux-foundation.org, vbabka@suse.cz, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] mm/slab: break up RCU readers on SLAB_TYPESAFE_BY_RCU example code
Date:   Sat, 15 Apr 2023 03:23:05 +0000
Message-Id: <20230415032305.3860-1-sj@kernel.org>
In-Reply-To: <20230415030452.3223-1-sj@kernel.org>
References: 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Sat, 15 Apr 2023 03:04:52 +0000 SeongJae Park <sj@kernel.org> wrote:

> On Sat, 15 Apr 2023 03:51:54 +0100 Matthew Wilcox <willy@infradead.org> wrote:
> 
> > On Sat, Apr 15, 2023 at 12:37:53AM +0000, SeongJae Park wrote:
> > >   *
> > > + * begin:
> > >   *  rcu_read_lock();
> > > - * again:
> > >   *  obj = lockless_lookup(key);
> > >   *  if (obj) {
> > >   *    if (!try_get_ref(obj)) // might fail for free objects
> > > - *      goto again;
> > > + *      goto begin;

I simply followed the commit da82af04352b ("doc: Update and wordsmith
rculist_nulls.rst") for this change, and I think I overlooked this part.  If
I'm not missing something, I think we should call rcu_read_unlock() here too,
just before 'goto begin'.

I will post another patch for rculist_null.rst later.


Thanks,
SJ

> > >   *
> > >   *    if (obj->key != key) { // not the object we expected
> > >   *      put_ref(obj);
> > > + *      rcu_read_unlock();
> > >   *      goto again;
> > 
> > - *      goto again;
> > + *      goto begin;
> 
> Oops, thank you for catching, Matthew!
> 
> 
> Thanks,
> SJ