Date: Wed, 26 Sep 2007 14:13:24 -0700 (PDT)
Message-Id: <20070926.141324.83603136.davem@davemloft.net>
To: willy@linux.intel.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] Change dmapool free block management
From: David Miller <davem@davemloft.net>
In-Reply-To: <1190833279354-git-send-email-willy@linux.intel.com>
References: <20070926185757.GM3899@parisc-linux.org>
	<1190833279354-git-send-email-willy@linux.intel.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 871
Lines: 21

From: Matthew Wilcox <willy@linux.intel.com>
Date: Wed, 26 Sep 2007 15:01:18 -0400

> Also add documentation for how dma pools work, move the header above the
> includes, add my copyright, add the original author's copyright, add a
> GPL v2 licence to the file and fix the includes.
> 
> Signed-off-by: Matthew Wilcox <willy@linux.intel.com>

Correct or not, you need to describe how you are changing the
free block management, why that transformation is valid and
worthwhile, etc.

I can see that you're getting rid of a bitmap and replacing it
with the dma_page->in_use et al. stuff, but you need to describe
that in detail.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/