Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <20bbb3f0-ac79-9d98-9c99-7062581b163f@ti.com>
Date:   Sat, 15 Apr 2023 09:40:10 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH 1/2] arm64: dts: ti: k3-j7200: Fix physical address of pin
Content-Language: en-US
To:     Nishanth Menon <nm@ti.com>
CC:     <linux-arm-kernel@lists.infradead.org>, <afd@ti.com>, <bb@ti.com>,
        <vaishnav.a@ti.com>, <j-choudhary@ti.com>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <vigneshr@ti.com>, <kristo@kernel.org>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, J Keerthi <j-keerthy@ti.com>
References: <20230414181434.2046049-1-u-kumar1@ti.com>
 <20230414181434.2046049-2-u-kumar1@ti.com>
 <20230414182638.watc555ihi2hgkuv@slinging>
From:   "Kumar, Udit" <u-kumar1@ti.com>
In-Reply-To: <20230414182638.watc555ihi2hgkuv@slinging>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Nishanth

On 4/14/2023 11:56 PM, Nishanth Menon wrote:
> On 23:44-20230414, Udit Kumar wrote:
>> Fixes: 9ae21ac445e9 ("arm64: dts: ti: k3-j7200: Fix wakeup pinmux range")
> In the wrong place.


will address in v2


>> wkup_pmx splits into multiple regions. Like
>>
>>      wkup_pmx0 -> 13 pins (WKUP_PADCONFIG 0 - 12)
>>      wkup_pmx1 -> 2 pins (WKUP_PADCONFIG 14 - 15)
>>      wkup_pmx2 -> 59 pins (WKUP_PADCONFIG 26 - 84)
>>      wkup_pmx3 -> 8 pins (WKUP_PADCONFIG 93 - 100)
>>
>> With this split, pin offset needs to be adjusted to
>> match with new pmx for all pins above wkup_pmx0.
>>
>> Example a pin under wkup_pmx1 should start from 0 instead of
>> old offset(0x38 WKUP_PADCONFIG 14 offset)
>>
>> J7200 Datasheet (Table 6-106, Section 6.4 Pin Multiplexing) :
>>              https://www.ti.com/lit/ds/symlink/dra821u.pdf
> Drop the preceding whitespace.

ok

>> Signed-off-by: J Keerthi <j-keerthy@ti.com>
> Spell check name please, I think he usually goes with:
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
>
> If this patch is from Keerthy, the patch should have a "From:"

ok.

git apply on original patch didn't worked , so i applied and committed.

will fix in patch itself before posting, Keerthi as author


>> Signed-off-by: Udit Kumar <u-kumar1@ti.com>
>> ---
>>   .../dts/ti/k3-j7200-common-proc-board.dts     | 28 +++++++++----------
>>   1 file changed, 14 insertions(+), 14 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
>> index 0d39d6b8cc0c..63633e4f6c59 100644
>> --- a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
>> +++ b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
>> @@ -83,25 +83,25 @@ vdd_sd_dv: gpio-regulator-TLV71033 {
>>   &wkup_pmx2 {
>>   	mcu_cpsw_pins_default: mcu-cpsw-pins-default {
>>   		pinctrl-single,pins = <
>> -			J721E_WKUP_IOPAD(0x0068, PIN_OUTPUT, 0) /* MCU_RGMII1_TX_CTL */
>> -			J721E_WKUP_IOPAD(0x006c, PIN_INPUT, 0) /* MCU_RGMII1_RX_CTL */
>> -			J721E_WKUP_IOPAD(0x0070, PIN_OUTPUT, 0) /* MCU_RGMII1_TD3 */
>> -			J721E_WKUP_IOPAD(0x0074, PIN_OUTPUT, 0) /* MCU_RGMII1_TD2 */
>> -			J721E_WKUP_IOPAD(0x0078, PIN_OUTPUT, 0) /* MCU_RGMII1_TD1 */
>> -			J721E_WKUP_IOPAD(0x007c, PIN_OUTPUT, 0) /* MCU_RGMII1_TD0 */
>> -			J721E_WKUP_IOPAD(0x0088, PIN_INPUT, 0) /* MCU_RGMII1_RD3 */
>> -			J721E_WKUP_IOPAD(0x008c, PIN_INPUT, 0) /* MCU_RGMII1_RD2 */
>> -			J721E_WKUP_IOPAD(0x0090, PIN_INPUT, 0) /* MCU_RGMII1_RD1 */
>> -			J721E_WKUP_IOPAD(0x0094, PIN_INPUT, 0) /* MCU_RGMII1_RD0 */
>> -			J721E_WKUP_IOPAD(0x0080, PIN_OUTPUT, 0) /* MCU_RGMII1_TXC */
>> -			J721E_WKUP_IOPAD(0x0084, PIN_INPUT, 0) /* MCU_RGMII1_RXC */
>> +			J721E_WKUP_IOPAD(0x0000, PIN_OUTPUT, 0) /* MCU_RGMII1_TX_CTL */
>> +			J721E_WKUP_IOPAD(0x0004, PIN_INPUT, 0) /* MCU_RGMII1_RX_CTL */
>> +			J721E_WKUP_IOPAD(0x0008, PIN_OUTPUT, 0) /* MCU_RGMII1_TD3 */
>> +			J721E_WKUP_IOPAD(0x000c, PIN_OUTPUT, 0) /* MCU_RGMII1_TD2 */
>> +			J721E_WKUP_IOPAD(0x0010, PIN_OUTPUT, 0) /* MCU_RGMII1_TD1 */
>> +			J721E_WKUP_IOPAD(0x0014, PIN_OUTPUT, 0) /* MCU_RGMII1_TD0 */
>> +			J721E_WKUP_IOPAD(0x0020, PIN_INPUT, 0) /* MCU_RGMII1_RD3 */
>> +			J721E_WKUP_IOPAD(0x0024, PIN_INPUT, 0) /* MCU_RGMII1_RD2 */
>> +			J721E_WKUP_IOPAD(0x0028, PIN_INPUT, 0) /* MCU_RGMII1_RD1 */
>> +			J721E_WKUP_IOPAD(0x002c, PIN_INPUT, 0) /* MCU_RGMII1_RD0 */
>> +			J721E_WKUP_IOPAD(0x0018, PIN_OUTPUT, 0) /* MCU_RGMII1_TXC */
>> +			J721E_WKUP_IOPAD(0x001c, PIN_INPUT, 0) /* MCU_RGMII1_RXC */
> nice catch.
>
>>   		>;
>>   	};
>>   
>>   	mcu_mdio_pins_default: mcu-mdio1-pins-default {
>>   		pinctrl-single,pins = <
>> -			J721E_WKUP_IOPAD(0x009c, PIN_OUTPUT, 0) /* (L1) MCU_MDIO0_MDC */
>> -			J721E_WKUP_IOPAD(0x0098, PIN_INPUT, 0) /* (L4) MCU_MDIO0_MDIO */
>> +			J721E_WKUP_IOPAD(0x0034, PIN_OUTPUT, 0) /* (L1) MCU_MDIO0_MDC */
>> +			J721E_WKUP_IOPAD(0x0030, PIN_INPUT, 0) /* (L4) MCU_MDIO0_MDIO */
>>   		>;
>>   	};
>>   };
>> -- 
>> 2.34.1
>>