Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 15 Apr 2023 10:01:02 +0200
From:   Pavel Machek <pavel@ucw.cz>
To:     Andreas Kemnade <andreas@kemnade.info>
Cc:     lee@kernel.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, linux-leds@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        Matti Vaittinen <mazziesaccount@gmail.com>
Subject: Re: [PATCH v4 2/2] leds: bd2606mvv: Driver for the Rohm 6 Channel
 i2c LED driver
Message-ID: <ZDpZvhWX/Vx9jVUT@amd.ucw.cz>
References: <20230414055341.335456-1-andreas@kemnade.info>
 <20230414055341.335456-3-andreas@kemnade.info>
 <ZDlEsNZ3pTlfxkAz@duo.ucw.cz>
 <20230415000533.534ea99b@aktux>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="HyL346m6DlBmbap6"
Content-Disposition: inline
In-Reply-To: <20230415000533.534ea99b@aktux>
Precedence: bulk


--HyL346m6DlBmbap6
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi!

> > > The device provides 6 channels which can be individually
> > > turned off and on but groups of two channels share a common brightness
> > > register. =20
> >=20
> > Yeah, well.. Turn it into 3-channel controller with brightness or
> > 6-channel on/off one... You can't really share brightness.
> >=20
> No, I cannot change the hardware, so it is a 6-channel with limitations.
> And the devicetree has to describe the hardware and not the driver.

Device tree is okay, I commented on the driver.

> What is discussable is just how the driver should deal with that:
>=20
> I see 5 possibilities.
> a) ignore the shared brightness problem (status quo)
> b) never set a brightness other than full on/off
> c) ignore one led of each pair (not register it at all{
> d) couple also the on/off of the pairs, so present to
>    userspace only max. 3 leds.
> e) allow full brightness control where independently possible,
>    if LEDs are defined where that leads to conflicts,
>    register them with max_brightness=3D1 and use them
>    in on/off mode.
>=20
> My preference were a) or e), the most possible usages.
> e) has a cleaner interface to the userspace.

b) c) e) are acceptable to me. So I guess e) is preffered.

BR,							Pavel
--=20
People of Russia, stop Putin before his war on Ukraine escalates.

--HyL346m6DlBmbap6
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCZDpZvgAKCRAw5/Bqldv6
8mJmAJ9pkr4g+mUllXlalLoHux4zFB6q8ACfcm6tduTKgAhtq5v26sV7/2ZHxa4=
=Vrcm
-----END PGP SIGNATURE-----

--HyL346m6DlBmbap6--