Received: by 2002:a05:6358:53a8:b0:117:f937:c515 with SMTP id z40csp1621200rwe; Sat, 15 Apr 2023 02:59:14 -0700 (PDT) X-Google-Smtp-Source: AKy350Yr8vR2+ue+XCGsvv2CmT5Ovt3qj8grDVAFcomPrB6wWZzRLFS7w3EKnWPO5jkQ2+PYunsx X-Received: by 2002:a05:6a20:8419:b0:d8:bed9:33cf with SMTP id c25-20020a056a20841900b000d8bed933cfmr10136099pzd.17.1681552753937; Sat, 15 Apr 2023 02:59:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681552753; cv=none; d=google.com; s=arc-20160816; b=AW4MuJHrm3+FoI9o59RJ4RvNCvbGCTjZYm8UNCnL5uZrTQ6axcYWunK4QxUr88quTD XHqEW00zTVl57mfupae5ZLH0v+H71oqhRUQnCxnIRXP+mnE/iAx4vK6/nWKfDMZrZGYB /ZOZe9W7Z6qsdblZiLlbSVgqhnCoRmvJpzadsPfJL+rcWMpJmYXUSIgTqKxvPK7MLpJU 2M1W4cx1cfk0w4Msc7qzAmwD+QltDhD6QvjqX/oAFrJbekWmelnXC8UDq5MY4kB/7ydB nor1CLYReR1NyZu2PFPB9Hk4rz5at3m0xDL0urLLKCu2NjoICoWkdLA9EDtJPUUytKbP gz0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=qBW7voqUuCZ1/G9Ruo0KBFBVOsPyocZSL7gk/zrdikA=; b=bnD1ZeaW3JLVLgsFUDAT2l5bEkk0v5DEGwlt3/5BEWFavxT7TnTatKL3CN62n/vDdY VqVbbOEkmaTR63XC+Pzzuv2yANDvMndLPi6ddLf2Ewh/XnOgybj0DdVBe+Xf3YvhIjuw rT6CfinUXaW+CJ1phTrSk2kOvbnnls1h8BTFuDC3RDiBYbZaDg+gpANJuvj/hpjLJgVU A5CGgTJwlaEI/g5SlFTpkkPHLEF/gvs8SV0++4QtmICIlwVkrdlMiT2Wnv9KBZQ2aI1e M6395fipUtEu/j0ILsiHYiHwELtlXdFj9dBnhWHmDOnTD8xk2GkBeLatIvyuwsvMmyH1 q8vw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=vV0UVC8Y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a11-20020a63d40b000000b00518ebc6f91csi7207981pgh.306.2023.04.15.02.59.00; Sat, 15 Apr 2023 02:59:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=vV0UVC8Y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230044AbjDOJ6U (ORCPT + 99 others); Sat, 15 Apr 2023 05:58:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229911AbjDOJ6R (ORCPT ); Sat, 15 Apr 2023 05:58:17 -0400 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 48CFB40DF for ; Sat, 15 Apr 2023 02:58:14 -0700 (PDT) Received: by mail-ej1-x634.google.com with SMTP id xd13so17784842ejb.4 for ; Sat, 15 Apr 2023 02:58:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681552693; x=1684144693; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=qBW7voqUuCZ1/G9Ruo0KBFBVOsPyocZSL7gk/zrdikA=; b=vV0UVC8YX5hmGr0O97HyyHm2Xo8rJmT7MUThJiturG/vbsOZEQRCW+4Z0YLug1TOuA 9Fl8JfgAPV0dxpjL6yz1awbckIWcCiv4Hd8gj0dA972smjEZDmZv4JjOqq7iZVpBW1sY mF5wUG94gjCJkPbW3xKn1lVAPzwYVtZa1qeOWVyYbG8fUaE7YKWfd8oS2zh10JImfbRT O8lCVvmjaHsSea0ZY/SQAum9EPpDkCtdmnt2u3aFbMLw2G9sg2x+R/EdSXH/RcSPmxwH Iu3rdR7zRs4CK/5xpJtAtfDsmNTydHU8iff+2leZXDusAHTEaDLK7m0Ywax1Mb5TkID/ qMrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681552693; x=1684144693; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qBW7voqUuCZ1/G9Ruo0KBFBVOsPyocZSL7gk/zrdikA=; b=DnoKehUA0yAXq9WXYHKxxN0uKGkrFRfs+CqzQvYxo0z6Q2d47IMw7n7uJ1g8cwgdhb HWXIN5aMd4srUdnMBKDMrWIFu3WWCKs+Q7vs4DziS5zn90fshpa/2vwUpwpgKt984GFC XgZ/nuI2S2HM2XE4Q6jOT6qMiWJty3xNb6hDojnUhx22K7mHyEFM9GNd5J40dtnRQgZH SEndsw0zppcKSbmwbjIj89h6qMXeTEPpw9aGDbO71kCkxJH0tvzBgshPuP1r3YQff9yz 9ZuRmI7ysSKJwkkBV3jvpkrKcM7eoNgdzWuvsjXomMfEsi1+FHFFzGJheNMb/CRFnr4h +oQw== X-Gm-Message-State: AAQBX9ewiR4E+uNnqsb4zZau8F4R6dtHOXWMBmOi8z9l25f+eN6N0Zu4 Ny7cRFG/okZQNcqZQica+M9ITA== X-Received: by 2002:a17:907:1245:b0:94e:6294:9d23 with SMTP id wc5-20020a170907124500b0094e62949d23mr1342399ejb.26.1681552692687; Sat, 15 Apr 2023 02:58:12 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:a3bf:4ed:6c53:2a36]) by smtp.gmail.com with ESMTPSA id gn23-20020a1709070d1700b009373f1b5c4esm3594248ejc.161.2023.04.15.02.58.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Apr 2023 02:58:12 -0700 (PDT) From: Krzysztof Kozlowski To: Wim Van Sebroeck , Guenter Roeck , Rob Herring , Krzysztof Kozlowski , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Julius Werner , Evan Benn , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Florian Fainelli , Broadcom internal kernel review list , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Matthias Brugger , AngeloGioacchino Del Regno , Andy Gross , Bjorn Andersson , Konrad Dybcio , Sander Vanheule , Maxime Coquelin , Alexandre Torgue , Nobuhiro Iwamatsu , Geert Uytterhoeven , Magnus Damm , Fu Wei , Viresh Kumar , Eugen Hristev , Justin Chen , =?UTF-8?q?=82ecki?= , Linus Walleij , Corentin Labbe , Anson Huang , Robert Marko , Sergio Paracuellos , Sai Prakash Ranjan , Wolfram Sang , Jamie Iles , Yannick Fertre , Christophe Roullier , Shubhrajyoti Datta , Srinivas Neeli , linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-renesas-soc@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 1/6] dt-bindings: watchdog: drop duplicated GPIO watchdog bindings Date: Sat, 15 Apr 2023 11:51:07 +0200 Message-Id: <20230415095112.51257-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Two conversions to DT schema of GPIO watchdog binding happened and came through different trees. Merge them into one: 1. Combine maintainers, 2. Use more descriptive property descriptions and constraints from gpio-wdt.yaml, 3. Switch to unevaluatedProperties:false, to allow generic watchdog properties. Signed-off-by: Krzysztof Kozlowski --- .../bindings/watchdog/gpio-wdt.yaml | 55 ------------------- .../bindings/watchdog/linux,wdt-gpio.yaml | 17 +++++- 2 files changed, 15 insertions(+), 57 deletions(-) delete mode 100644 Documentation/devicetree/bindings/watchdog/gpio-wdt.yaml diff --git a/Documentation/devicetree/bindings/watchdog/gpio-wdt.yaml b/Documentation/devicetree/bindings/watchdog/gpio-wdt.yaml deleted file mode 100644 index 155dc7965e9b..000000000000 --- a/Documentation/devicetree/bindings/watchdog/gpio-wdt.yaml +++ /dev/null @@ -1,55 +0,0 @@ -# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) -%YAML 1.2 ---- -$id: http://devicetree.org/schemas/watchdog/gpio-wdt.yaml# -$schema: http://devicetree.org/meta-schemas/core.yaml# - -title: GPIO controlled watchdog - -maintainers: - - Robert Marko - -properties: - compatible: - const: linux,wdt-gpio - - gpios: - maxItems: 1 - description: GPIO connected to the WDT reset pin - - hw_algo: - $ref: /schemas/types.yaml#/definitions/string - description: Algorithm used by the driver - oneOf: - - description: - Either a high-to-low or a low-to-high transition clears the WDT counter. - The watchdog timer is disabled when GPIO is left floating or connected - to a three-state buffer. - const: toggle - - description: - Low or high level starts counting WDT timeout, the opposite level - disables the WDT. - Active level is determined by the GPIO flags. - const: level - - hw_margin_ms: - $ref: /schemas/types.yaml#/definitions/uint32 - description: Maximum time to reset watchdog circuit (in milliseconds) - minimum: 2 - maximum: 65535 - - always-running: - type: boolean - description: - If the watchdog timer cannot be disabled, add this flag to have the driver - keep toggling the signal without a client. - It will only cease to toggle the signal when the device is open and the - timeout elapsed. - -required: - - compatible - - gpios - - hw_algo - - hw_margin_ms - -unevaluatedProperties: false diff --git a/Documentation/devicetree/bindings/watchdog/linux,wdt-gpio.yaml b/Documentation/devicetree/bindings/watchdog/linux,wdt-gpio.yaml index 50af79af6416..499f1b7e03f9 100644 --- a/Documentation/devicetree/bindings/watchdog/linux,wdt-gpio.yaml +++ b/Documentation/devicetree/bindings/watchdog/linux,wdt-gpio.yaml @@ -8,6 +8,7 @@ title: GPIO-controlled Watchdog maintainers: - Guenter Roeck + - Robert Marko properties: compatible: @@ -19,11 +20,23 @@ properties: hw_algo: description: The algorithm used by the driver. - enum: [ level, toggle ] + oneOf: + - description: + Either a high-to-low or a low-to-high transition clears the WDT counter. + The watchdog timer is disabled when GPIO is left floating or connected + to a three-state buffer. + const: toggle + - description: + Low or high level starts counting WDT timeout, the opposite level + disables the WDT. + Active level is determined by the GPIO flags. + const: level hw_margin_ms: description: Maximum time to reset watchdog circuit (milliseconds). $ref: /schemas/types.yaml#/definitions/uint32 + minimum: 2 + maximum: 65535 always-running: type: boolean @@ -42,7 +55,7 @@ required: allOf: - $ref: watchdog.yaml# -additionalProperties: false +unevaluatedProperties: false examples: - | -- 2.34.1