Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <7c00f4f8-5bdf-4fa6-d9f0-141cf88c9ec9@nvidia.com>
 <20230329162145.147395-1-akinobu.mita@gmail.com> <c57uedevavvjwlcvgxfv453dfiy4cgq4f23dscu5dy77sujgw2@pb6fyyfov5se>
In-Reply-To: <c57uedevavvjwlcvgxfv453dfiy4cgq4f23dscu5dy77sujgw2@pb6fyyfov5se>
From:   Akinobu Mita <akinobu.mita@gmail.com>
Date:   Sat, 15 Apr 2023 19:29:48 +0900
Message-ID: <CAC5umyhVXdRN570SmcvMNtW-xL38siQ38PeYHrJgATxHyU4g0A@mail.gmail.com>
Subject: Re: [PATCH blktests] don't require modular null_blk for fault-injection
To:     "Shin'ichiro Kawasaki" <shinichiro@fastmail.com>
Cc:     chaitanyak@nvidia.com, akpm@linux-foundation.org, axboe@kernel.dk,
        hch@infradead.org, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

2023=E5=B9=B44=E6=9C=8812=E6=97=A5(=E6=B0=B4) 12:05 Shin'ichiro Kawasaki <s=
hinichiro@fastmail.com>:
>
> Akinobu, thanks for the patch, and sorry for this slow response.
>
> On Mar 30, 2023 / 01:21, Akinobu Mita wrote:
> > I'm trying to allow configuration of null_blk fault-injection via confi=
gfs.
> >
> > This blktests change changes null_blk fault-injection settings to be
> > configured via configfs instead of module parameters.
> > This allows null_blk fault-injection tests to run even if the null_blk =
is
> > built-in the kernel and not built as a module.
>
> It's good that the three test case can run with built-in null_blk.
>
> >
> > However, to keep the scripts simple, we will skip testing if the null_b=
lk
> > does not yet support configuring fault-injection via configfs.
>
> Hmm, it means that blktests coverage will be lost on older kernels withou=
t the
> configfs support. Before this change, the test cases were not skipped on =
older
> kernel with loadable null_blk. After this patch, the test cases will be s=
kipped.
>
> Can we cover both the new and old ways? When the null_blk set up with con=
figfs
> fails, we can fallback to the old way with module parameters.
>
> For example, null_blk set up of block/014 can be like this:

OK, I'll update the tests and give it a try.