Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 15 Apr 2023 07:47:09 -0500
From:   Nishanth Menon <nm@ti.com>
To:     "Kumar, Udit" <u-kumar1@ti.com>
CC:     <linux-arm-kernel@lists.infradead.org>, <afd@ti.com>, <bb@ti.com>,
        <vaishnav.a@ti.com>, <j-choudhary@ti.com>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <vigneshr@ti.com>, <kristo@kernel.org>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>
Subject: Re: [PATCH 2/2] arm64: dts: ti: k3-j7200-common-proc-board: Enable
 I2C
Message-ID: <20230415124709.fazcyqe5zfnbcrbc@jogging>
References: <20230414181434.2046049-1-u-kumar1@ti.com>
 <20230414181434.2046049-3-u-kumar1@ti.com>
 <20230414182401.2yfpwjug3naiwesi@quicksand>
 <b360dfd0-3dd3-996c-a9b6-1af770c4015b@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <b360dfd0-3dd3-996c-a9b6-1af770c4015b@ti.com>
Precedence: bulk

On 09:36-20230415, Kumar, Udit wrote:
[...]

> > > diff --git a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
> > > index 63633e4f6c59..e66bbfe65ff2 100644
> > > --- a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
> > > +++ b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
> > > @@ -254,6 +254,10 @@ exp3: gpio@20 {
> > >   	};
> > >   };
> > > +&wkup_i2c0 {
> > > +	status = "okay";
> > How about the pinmux? speed? what peripheral is on the wakeup i2c?
> > 
> > 	Do we have an eeprom or something here?
> 
> 
> This got eeprom and PMIC,
> 
> eeprom read is ok with pin mux and speed.
> 
> if you want to specify, let me know

yes, you must specify eeprom at least. I understand pmic is in
discussion atm [1], So, that can be resolved seperately.

Also if the eeprom is on the SoM, you should add this in the SoM dtsi,
not the baseboard dtsi.

[1] https://lore.kernel.org/all/714a56b1-438c-7aad-920b-f3f1d72afc5f@linaro.org/
-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D