Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 15 Apr 2023 13:39:38 +0200
From:   Luke Koch <lu.ale.koch@gmail.com>
To:     Dan Carpenter <error27@gmail.com>
Cc:     gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: wlan-ng: replace rate macros
Message-ID: <ZDqM+seGtevADusa@kernelhacking.kernelhacking.example.com>
References: <ZDqKb1iuoSQTYXJM@kernelhacking.kernelhacking.example.com>
 <714c5d3f-438a-4633-a46e-127f876ffec4@kili.mountain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <714c5d3f-438a-4633-a46e-127f876ffec4@kili.mountain>
Precedence: bulk

On Sat, Apr 15, 2023 at 03:43:20PM +0300, Dan Carpenter wrote:
> Writing every sentence in imperative tense makes people sound like space
> aliens in human skin...  You can if you want to but it's not a
> requirement in staging.  There are two maintainers who have that
> requirement and the Outreachy people.

> > -	struct p80211item_uint32 basicrate1;
>                                  ^^^^^^^^^^
> This starts at 1 instead of 0.

> > +	for (int i = 0; i < 8; i++) {
>                  ^^^^^
> Now it starts at zero.
> 
> > +		if (count >= i &&
> > +		    DOT11_RATE5_ISBASIC_GET(item->supprates[i - 1])) {
>                                                             ^^^^^
> This is an array underflow.
> 
> regards,
> dan carpenter

Thank you for the heads up on the (lack of) necessity for alienspeak and
the code problem.
Starting at 0 should not have made a difference but I totally missed
that underflow... embarassing.
I'll make sure to fix that and resubmit the revised patch.

Thanks,
Luke