Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761617AbXIZVkx (ORCPT ); Wed, 26 Sep 2007 17:40:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754284AbXIZVko (ORCPT ); Wed, 26 Sep 2007 17:40:44 -0400 Received: from smtp-out1.tiscali.nl ([195.241.79.176]:42607 "EHLO smtp-out1.tiscali.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753099AbXIZVkn (ORCPT ); Wed, 26 Sep 2007 17:40:43 -0400 X-Greylist: delayed 368 seconds by postgrey-1.27 at vger.kernel.org; Wed, 26 Sep 2007 17:40:43 EDT Message-ID: <46FAD1D2.8030306@tiscali.nl> Date: Wed, 26 Sep 2007 23:40:34 +0200 From: roel <12o3l@tiscali.nl> User-Agent: Thunderbird 2.0.0.6 (X11/20070728) MIME-Version: 1.0 To: Erez Zadok CC: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, viro@ftp.linux.org.uk, hch@infradead.org Subject: Re: [PATCH 13/25] Unionfs: add un/likely conditionals on dir ops References: <11907762042481-git-send-email-ezk@cs.sunysb.edu> <11907762104036-git-send-email-ezk@cs.sunysb.edu> In-Reply-To: <11907762104036-git-send-email-ezk@cs.sunysb.edu> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 630 Lines: 18 Erez Zadok wrote: > @@ -194,7 +194,7 @@ int check_empty(struct dentry *dentry, struct unionfs_dir_state **namelist) > > BUG_ON(!S_ISDIR(dentry->d_inode->i_mode)); > > - if ((err = unionfs_partial_lookup(dentry))) > + if (unlikely((err = unionfs_partial_lookup(dentry)))) > goto out; > > bstart = dbstart(dentry); Is it bad to leave this assignment within the unlikely()? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/