Received: by 2002:a05:6358:53a8:b0:117:f937:c515 with SMTP id z40csp1968765rwe; Sat, 15 Apr 2023 09:05:06 -0700 (PDT) X-Google-Smtp-Source: AKy350Y671UImT+Vosu7xcoRYWIcrAJOdZH5NNTdJP1YBfsWAdedATpvqowsIOYLf3xCP1RzpgS6 X-Received: by 2002:a05:6a00:2e26:b0:634:f9a3:9be6 with SMTP id fc38-20020a056a002e2600b00634f9a39be6mr15691435pfb.11.1681574706047; Sat, 15 Apr 2023 09:05:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681574706; cv=none; d=google.com; s=arc-20160816; b=bhhrUMP2ngSfP05mqF7EU2yAQOmRg/lvZ+FHvJskPzHYTBp6fTq7tPmILSi376NgG+ kRJsAgiXfApzGbJE+ukaMqcWRZPjUAlJsDcTh2SusprrcSP8GCLQQHpMUY1Uh9/tKO2i WViNZFPgK/S8i16xQ9FMH/ZaskMthoxR3o9rdGZwM5s0P3o7mfOVfYX5XD8WJs5+w21N RUAa6fY7l+suLbmqeT1kH/q5w2w2gew351FKJGsKWl1MX8vauPdBP65IMeObP4k8Dcc4 m82CS45VJ8adL6nhMeG0o9Wd/0Inrwm0K/A2vTeTLHpMfgQh4ou4I3LsnhmLABNsH74g dcrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=A4FSO8eDj7F6WaUQ2/fLk8IQQ4ZXu2FsDNL3WAoEdhs=; b=fGSX7ERyWL7LuWl5Mjuwvh8BgOi+cBHNg+h4dpIxXZmztYredGPeGYmHRunRRcGgzQ ioCTsvhCGthCS9Myu6hclcFyiimpI6MACwOfSGABCvziICIBDXGDit7WPJlVSYxMxBS1 OkXz/bZNYPeEz86SRw5vhR7FLSnrdsR+fMCtpu6VjcYZfDYRAkEJI2XjmGGEL++V45lP VJb5g6LI2gpkIUfveWtS9bcZlRYSlxCtksnqZ7skzWGu/H1m4bRaTZ5p32Gl811+42Ef 1Qp9gsTIiFCgFrSp3L3C6irfuAPKSsheEr1TqPbsCBuEsOsmiuAARQiy3W0ZKa4J6bem T7Cw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=CmWfuR3u; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e185-20020a6369c2000000b0051b1241624esi7843405pgc.65.2023.04.15.09.04.31; Sat, 15 Apr 2023 09:05:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=CmWfuR3u; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229946AbjDOQCu (ORCPT + 99 others); Sat, 15 Apr 2023 12:02:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40192 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229997AbjDOQCq (ORCPT ); Sat, 15 Apr 2023 12:02:46 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C49EC4ECB for ; Sat, 15 Apr 2023 09:02:43 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9A40E60AED for ; Sat, 15 Apr 2023 16:02:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A6908C433D2; Sat, 15 Apr 2023 16:02:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1681574563; bh=Keho5jZUf9JoMSbHmX57TIOBY/LQblSMA+MdqWd6VXc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CmWfuR3uSekN6HhPeC3PBfkOM6/U+mAO6TNArkm/CpYFEZOpXE3G6j9SZM54hvhw9 I8aKbZdhpUOpdwQM03SAEvB3mNX9SNwsf/8iuo0YqdQJGHYNA4dsumZ1RdjjpFC+2C VW7a3a866ltfvQpIK/zlw/YeYnXoIKRukvV3QmFc= Date: Sat, 15 Apr 2023 18:02:40 +0200 From: Greg Kroah-Hartman To: Philipp Hortmann Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8192e: Fix W_DISABLE# does not work after stop/start Message-ID: <2023041515-overhung-grime-d9fc@gregkh> References: <20230414183452.GA12295@matrix-ESPRIMO-P710> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230414183452.GA12295@matrix-ESPRIMO-P710> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 14, 2023 at 08:34:52PM +0200, Philipp Hortmann wrote: > When loading the driver for rtl8192e, the W_DISABLE# switch is working as > intended. But when the WLAN is turned off in software and then turned on > again the W_DISABLE# does not work anymore. Reason for this is that in > the function _rtl92e_dm_check_rf_ctrl_gpio() the bfirst_after_down is > checked and returned when true. bfirst_after_down is set true when > switching the WLAN off in software. But it is not set to false again > when WLAN is turned on again. > > Add bfirst_after_down = false in _rtl92e_sta_up to reset bit and fix > above described bug. > > Signed-off-by: Philipp Hortmann > --- > Tested with rtl8192e (WLL6130-D99) > Transferred this patch over wlan connection of rtl8192e > --- > drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 1 + > 1 file changed, 1 insertion(+) What commit id does this fix? Should it go to the stable kernels? If so, how far back? thanks, greg k-h