Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230327143733.14599-1-akinobu.mita@gmail.com>
 <20230327143733.14599-2-akinobu.mita@gmail.com> <CAMuHMdXhRvq3nktP4Kzjk8TuX1G=RfO3eOODGt5GRC6vGnfwzw@mail.gmail.com>
In-Reply-To: <CAMuHMdXhRvq3nktP4Kzjk8TuX1G=RfO3eOODGt5GRC6vGnfwzw@mail.gmail.com>
From:   Akinobu Mita <akinobu.mita@gmail.com>
Date:   Sun, 16 Apr 2023 01:50:47 +0900
Message-ID: <CAC5umyiE0sx=NJSV4kgvF-cfc2nB+kSxJdwp2-cXU0HZTbydLQ@mail.gmail.com>
Subject: Re: [PATCH 1/2] fault-inject: allow configuration via configfs
To:     Geert Uytterhoeven <geert@linux-m68k.org>
Cc:     linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
        akpm@linux-foundation.org, axboe@kernel.dk,
        Linux-Next <linux-next@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

2023=E5=B9=B44=E6=9C=8815=E6=97=A5(=E5=9C=9F) 23:53 Geert Uytterhoeven <gee=
rt@linux-m68k.org>:
>
> Hi Mita-san,
>
> On Mon, Mar 27, 2023 at 4:48=E2=80=AFPM Akinobu Mita <akinobu.mita@gmail.=
com> wrote:
> > This provides a helper function to allow configuration of fault-injecti=
on
> > for configfs-based drivers.
> >
> > The config items created by this function have the same interface as th=
e
> > one created under debugfs by fault_create_debugfs_attr().
> >
> > Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
>
> Thanks for your patch, which is now commit 4668c7a2940d134b
> ("fault-inject: allow configuration via configfs") in linux-next
> (to be tagged soon as next-20140414).
>
> > --- a/lib/Kconfig.debug
> > +++ b/lib/Kconfig.debug
> > @@ -1977,9 +1977,20 @@ config FAIL_SUNRPC
> >           Provide fault-injection capability for SunRPC and
> >           its consumers.
> >
> > +config FAULT_INJECTION_CONFIGFS
> > +       bool "Configfs interface for fault-injection capabilities"
> > +       depends on FAULT_INJECTION && CONFIGFS_FS
>
> noreply@ellerman.id.au reported build failures for e.g. m68k-allmodconfig
> http://kisskb.ellerman.id.au/kisskb/buildresult/14911188/:
>
> fault-inject.c:(.text+0x1ee): undefined reference to
> `config_group_init_type_name'
>
> This fails because FAULT_INJECTION=3Dy but CONFIGFS_FS=3Dm.

Oh, I just sent that build fix patch.
https://lore.kernel.org/all/20230415125705.180426-1-akinobu.mita@gmail.com/

Could you please check if this is the correct way to fix it?