Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 15 Apr 2023 21:09:36 +0300
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     netdev@vger.kernel.org
Cc:     "David S. Miller" <davem@davemloft.net>,
        Michal Kubecek <mkubecek@suse.cz>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 0/2] ethtool mm API improvements
Message-ID: <20230415180936.lx7sw4r3ungcl7w4@skbuf>
References: <20230415173454.3970647-1-vladimir.oltean@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230415173454.3970647-1-vladimir.oltean@nxp.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?H2hDOM7pgi57Xa6GizYJkIfqNb4F9hvdhFx1BaYcKAYiUnL3qkt8QrymKMq2?=
 =?us-ascii?Q?XKG/1yuzwop2Nq24Vp38a/4+Fc5AdLWM8QzUz8uoxRpcvUsRg4gefGnua65d?=
 =?us-ascii?Q?IMqeV4J0MG8yhJGfKpIXA3WGxCkn+8fbckP+t8D2htqaqODAHdhi8NwpqMH8?=
 =?us-ascii?Q?Cq4FKWpKtpQBOChSaXYjHUsNgBe5WDApY2GpJ+QgZsrCMfPsr+dZNk1iaBdu?=
 =?us-ascii?Q?lal1H+HSD/fLXe3Qz1kT0YTcFWLgV2Tf/wIFshD6nlPAwPnsKm0rFlKc2q9P?=
 =?us-ascii?Q?W3wex3bB79paL2XA4zO5UZp6G0BSRuOjGa+RooAZIdGoFZ9xAqzICAf+b/px?=
 =?us-ascii?Q?N/NsWycbbp8Dj1ihvy2D2DWnXZoMyqfiUmorwaJ8+sZA9IFPBWycRFJ20b8E?=
 =?us-ascii?Q?18kjYdP11/jsuHD2BlSClT+KjL2KZKOfFuGFbAjlqLUDLaTIvHPpF1AcSqT0?=
 =?us-ascii?Q?P7m5wlPetZHhr5d3wxyoReGGpjUcw8WsQhbZzfFUIf+s6umB59vA4ySZOEGc?=
 =?us-ascii?Q?VYeXktXjoT8Wxp37jZCL0OyT4IEM6OyTFT+G4qD6kHPNPWvy8ejFPiki/UM2?=
 =?us-ascii?Q?dje/Sg+JZJccsO+Cs9BmsVlMD0XIEWizrHCjr/XlkVdVLXydoC7Hc+ZgWbgb?=
 =?us-ascii?Q?qMNchYUvkHUj8bmgoKCL6YOQ/kNyYXAlKY88+KPTi+Rtk9Lfdn+aBU1ZRqxC?=
 =?us-ascii?Q?xAwuL/QJ3HCT4prrARsiOflVQOud57gaUjKDvHAza3XleMM00nfvkzLRF8J1?=
 =?us-ascii?Q?r/KLcocMFhfrU+sNt+ziYridNDmMX6T06Ia8Qace2UZWZXz29a7FkF2UU+dJ?=
 =?us-ascii?Q?VfeKiSdr/vI8BNREQsM9V7PxotUN8WV4MhRYJSjqFL+YnQmNlSqENSklZVkT?=
 =?us-ascii?Q?e7BlRn6qPS7jASyMcs2uvUkKOH5KxP2pekMIt04o/8NGFQhjYqBLc6VzJ4RM?=
 =?us-ascii?Q?ErFH8LRQY/BA9tVJmND9pIpPb1gLSCB1D1If1OQp9dIXAiKAUWf8MGgjteYh?=
 =?us-ascii?Q?ypYEqXpJ2wKCaePJ1hPhZ1hrFyUdI1nHsldqPjjn0N6ktqXIMyX/XHGf8jX8?=
 =?us-ascii?Q?jv72ITMld1XExEzBs+Cu9O3fBxY9zkOTo1HsR1dc/G/Pn+QjilDeF2kUvYgw?=
 =?us-ascii?Q?HTkl/++jyGgdtBfDO4+B2WMaGdnYL4Cv4Ub9/UIr0CuuVGVYtrkM/IyqUeGF?=
 =?us-ascii?Q?gKiwa9NUTwn1KsEuACF6BSI4u+NfhsLT/T2Yc4KygML9jDvmlBkuTj7CONlQ?=
 =?us-ascii?Q?YPOJQUhEgVyu84pujXNep0G2ZZv8gnsjXHN//t0Qvyeng6c8R5xZHrOwI2d1?=
 =?us-ascii?Q?Si7oTvJ1M/C+sGJBYOEZyV+Z40zseWMN6E5nGCR5WWK1tpoTIugBd5kFh3w1?=
 =?us-ascii?Q?k4NHI7IDYTwQU/9pver/fEmayzUBvSWTVRwGTU1re4D/B7kEisA/nCpnNhW9?=
 =?us-ascii?Q?2Qxve01SpFayJ7rE3RMV6XVqA5LSfFUgVWrFIl/CrzNGm/rQwVO+k8TxwsNx?=
 =?us-ascii?Q?QCCOfM9hGEpgaDC50b0S++bImozNFhUli1Gsvk994QFZg5ahM0vxjJmwf4gr?=
 =?us-ascii?Q?UByJlzEcfs0+s02SiJtS6U4Ea8975eKRHqlvcnhUDRPbTrP0NOHkjoQaJzqj?=
 =?us-ascii?Q?Tg=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 76a4afe2-1ca0-4a0d-aad0-08db3ddc94d8
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2023 18:09:40.4651
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QiTBg+kje+GVtCtka7ZjCAU7ieDeWJ2MH7toCfa5hmk70gnwzY66ygVyRSU6aTB5RqwR94A1KR88nk03C8jGYw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8947
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Apr 15, 2023 at 08:34:52PM +0300, Vladimir Oltean wrote:
> Currently the ethtool --set-mm API permits the existence of 2
> configurations which don't make sense:
> 
> - pmac-enabled false tx-enabled true
> - tx-enabled false verify-enabled true
> 
> By rejecting these, we can give driver-level code more guarantees.
> I re-ran the MM selftest posted here (which I need to repost):
> https://lore.kernel.org/netdev/20230210221243.228932-1-vladimir.oltean@nxp.com/
> 
> and it didn't cause functional problems.

Actually, it looks like that selftest passed by mistake in the
configuration that I tested it in. I actually get these failures:

~/selftests/net/forwarding# journalctl -b -u lldpad
Apr 15 18:05:10 lldpad[705]: arg_path "tlvid00120f07.addFragSize"
Apr 15 18:05:10 lldpad[705]: arg_path "tlvid00120f07.addFragSize"
Apr 15 18:05:10 lldpad[705]: arg_path "tlvid00120f07.addFragSize"
Apr 15 18:05:10 lldpad[705]: arg_path "tlvid00120f07.addFragSize"
Apr 15 18:05:10 lldpad[705]: Signal 15 received - terminating
Apr 15 18:05:10 lldpad[705]: ethtool: kernel reports: TX enabled requires pMAC enabled
Apr 15 18:05:10 lldpad[705]: ethtool: kernel reports: TX enabled requires pMAC enabled
Apr 15 18:05:10 systemd[1]: lldpad.service: Deactivated successfully.
Apr 15 18:05:10 systemd[1]: Stopped Link Layer Discovery Protocol Agent Daemon..

Please disregard at least patch 2. Patch 1 is still perfectly valid as-is.