Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230411140850.3129374-1-trix@redhat.com>
In-Reply-To: <20230411140850.3129374-1-trix@redhat.com>
From:   Oded Gabbay <ogabbay@kernel.org>
Date:   Sun, 16 Apr 2023 11:35:43 +0300
Message-ID: <CAFCwf12tq7-r7Ej2mwWruQHOvk2d1Z2S_BEVoKF45HsJjfZBDw@mail.gmail.com>
Subject: Re: [PATCH] accel/habanalabs: remove variable gaudi_irq_name
To:     Tom Rix <trix@redhat.com>
Cc:     gregkh@linuxfoundation.org, osharabi@habana.ai, talcohen@habana.ai,
        dhirschfeld@habana.ai, obitton@habana.ai,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Apr 11, 2023 at 5:09=E2=80=AFPM Tom Rix <trix@redhat.com> wrote:
>
> gcc with W=3D1 reports
> drivers/accel/habanalabs/gaudi/gaudi.c:117:19: error:
>   =E2=80=98gaudi_irq_name=E2=80=99 defined but not used [-Werror=3Dunused=
-const-variable=3D]
>   117 | static const char gaudi_irq_name[GAUDI_MSI_ENTRIES][GAUDI_MAX_STR=
ING_LEN] =3D {
>       |                   ^~~~~~~~~~~~~~
>
> This variable is not used so remove it.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>  drivers/accel/habanalabs/gaudi/gaudi.c | 7 -------
>  1 file changed, 7 deletions(-)
>
> diff --git a/drivers/accel/habanalabs/gaudi/gaudi.c b/drivers/accel/haban=
alabs/gaudi/gaudi.c
> index a29aa8f7b6f3..a1697581c218 100644
> --- a/drivers/accel/habanalabs/gaudi/gaudi.c
> +++ b/drivers/accel/habanalabs/gaudi/gaudi.c
> @@ -114,13 +114,6 @@ static u32 gaudi_stream_master[GAUDI_STREAM_MASTER_A=
RR_SIZE] =3D {
>         GAUDI_QUEUE_ID_DMA_1_3
>  };
>
> -static const char gaudi_irq_name[GAUDI_MSI_ENTRIES][GAUDI_MAX_STRING_LEN=
] =3D {
> -               "gaudi cq 0_0", "gaudi cq 0_1", "gaudi cq 0_2", "gaudi cq=
 0_3",
> -               "gaudi cq 1_0", "gaudi cq 1_1", "gaudi cq 1_2", "gaudi cq=
 1_3",
> -               "gaudi cq 5_0", "gaudi cq 5_1", "gaudi cq 5_2", "gaudi cq=
 5_3",
> -               "gaudi cpu eq"
> -};
> -
>  static const u8 gaudi_dma_assignment[GAUDI_DMA_MAX] =3D {
>         [GAUDI_PCI_DMA_1] =3D GAUDI_ENGINE_ID_DMA_0,
>         [GAUDI_PCI_DMA_2] =3D GAUDI_ENGINE_ID_DMA_1,
> --
> 2.27.0
>

Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Applied to -next
Thanks,
Oded