Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230305212519.499-1-yongsuyoo0215@gmail.com>
In-Reply-To: <20230305212519.499-1-yongsuyoo0215@gmail.com>
From:   YongSu Yoo <yongsuyoo0215@gmail.com>
Date:   Sun, 16 Apr 2023 21:02:09 +0900
Message-ID: <CANXPkT4QS1OO_BW5xWguNxa3jXVjwfFTxPmHYAYT=+MRc-FZOg@mail.gmail.com>
Subject: Re: [PATCH] media: dvb_demux: Fix a bug for the continuity counter
To:     0215yys@hanmail.net, yongsu.yoo@lge.com, mchehab@kernel.org,
        tommaso.merciai@amarulasolutions.com, yongsuyoo0215@gmail.com,
        hverkuil-cisco@xs4all.nl, colin.i.king@gmail.com,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi ~ Everyone
Can you share how this patch is going ?

2023=EB=85=84 3=EC=9B=94 6=EC=9D=BC (=EC=9B=94) =EC=98=A4=EC=A0=84 6:25, <y=
ongsuyoo0215@gmail.com>=EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1:
>
> From: YongSu Yoo <yongsuyoo0215@gmail.com>
>
> Signed-off-by: Yongsu Yoo <yongsuyoo0215@gmail.com>
>
> In dvb_demux.c, some logics exist which compare the expected
> continuity counter and the real continuity counter. If they
> are not matched each other, both of the expected continuity
> counter and the real continuity counter should be printed.
> But there exists a bug that the expected continuity counter
> is not correctly printed. The expected continuity counter is
> replaced with the real countinuity counter + 1 so that
> the epected continuity counter is not correclty printed.
> This is wrong. This bug is fixed.
> ---
>  drivers/media/dvb-core/dvb_demux.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/dvb-core/dvb_demux.c b/drivers/media/dvb-core/=
dvb_demux.c
> index 398c86279b5b..7c4d86bfdd6c 100644
> --- a/drivers/media/dvb-core/dvb_demux.c
> +++ b/drivers/media/dvb-core/dvb_demux.c
> @@ -115,12 +115,12 @@ static inline int dvb_dmx_swfilter_payload(struct d=
vb_demux_feed *feed,
>
>         cc =3D buf[3] & 0x0f;
>         ccok =3D ((feed->cc + 1) & 0x0f) =3D=3D cc;
> -       feed->cc =3D cc;
>         if (!ccok) {
>                 set_buf_flags(feed, DMX_BUFFER_FLAG_DISCONTINUITY_DETECTE=
D);
>                 dprintk_sect_loss("missed packet: %d instead of %d!\n",
>                                   cc, (feed->cc + 1) & 0x0f);
>         }
> +       feed->cc =3D cc;
>
>         if (buf[1] & 0x40)      // PUSI ?
>                 feed->peslen =3D 0xfffa;
> @@ -300,7 +300,6 @@ static int dvb_dmx_swfilter_section_packet(struct dvb=
_demux_feed *feed,
>
>         cc =3D buf[3] & 0x0f;
>         ccok =3D ((feed->cc + 1) & 0x0f) =3D=3D cc;
> -       feed->cc =3D cc;
>
>         if (buf[3] & 0x20) {
>                 /* adaption field present, check for discontinuity_indica=
tor */
> @@ -336,6 +335,7 @@ static int dvb_dmx_swfilter_section_packet(struct dvb=
_demux_feed *feed,
>                 feed->pusi_seen =3D false;
>                 dvb_dmx_swfilter_section_new(feed);
>         }
> +       feed->cc =3D cc;
>
>         if (buf[1] & 0x40) {
>                 /* PUSI=3D1 (is set), section boundary is here */
> --
> 2.17.1
>