Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <02a4ebb4-7652-fb1f-ae56-920648470c67@i2se.com>
Date:   Sun, 16 Apr 2023 15:11:02 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH v2 2/2] ARM: dts: Add nvmem node for BCM2711 bootloader
 public key
To:     "Ivan T. Ivanov" <iivanov@suse.de>
Cc:     Nicolas Saenz Julienne <nsaenz@kernel.org>,
        Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Phil Elwell <phil@raspberrypi.com>,
        linux-rpi-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Tim Gover <tim.gover@raspberrypi.com>
References: <20230413085206.149730-1-iivanov@suse.de>
 <20230413085206.149730-3-iivanov@suse.de>
 <9b03551a-278d-16dc-08ed-1ef0f89dc79c@i2se.com>
 <duuhz5pju4q7lnvzwndcnruqwqzbwy4jhrfn42vov2rfct4i7c@qh55cifhoud7>
 <9de62851-73a6-0070-4e64-94b6614c11fd@i2se.com>
 <CAAvKZ64KyXJ2QPjRnj3i-8AKh7jGCUw=HNi76XG-a9K-+_JiYQ@mail.gmail.com>
Content-Language: en-US
From:   Stefan Wahren <stefan.wahren@i2se.com>
In-Reply-To: <CAAvKZ64KyXJ2QPjRnj3i-8AKh7jGCUw=HNi76XG-a9K-+_JiYQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
UI-OutboundReport: notjunk:1;M01:P0:mSbi3KU6BPs=;NGWcCVS+iN0hiOR4UsxHWiuLqDt
 xHyIgrmAMXNW18TpA9ertaHkMRM84nwLUmzGall7mWck+IrViBMvFooNYc0ZOp7/DQWKRpZBL
 eMhOxYNwt+fm8C2juJ7anRLNzvl8dlSN61oiyfjDc/Havh40eH+i7aDQnqQDxWNuRXBwQAzhk
 BE3p75HqFowAhWtaqqD5uu/E/qOAvgydvGCAjIxIFiVSJ1Bcy4fiKTWInyA6+yI/4Bk0dClB7
 5o2shN35ZAEmVLQ3ns/+sY3fRdD4vEOSRzSDyB1vYtVcbyck5nDJff/nXhQtiJHZlGsVfbu00
 CeBCEpr4n+7YlBbml1s8O2aNipH9YHNNavyWEiMkDmLOW5ZI2CeCjYSuWhJFBgQrxneV3bhTa
 i+bLNBcBJx4V6F3mdXL1oUAszC7JSeHq2x/OqxSu/l8k4n8OQpI+lZTjnAM5UnAyHBHvC3VvH
 PUODrIzt2tdhCwfGrM9jtS4wb3Ie2LTzD8Nfar4xSlkUdxRvtz7KG0Z+yQfW3kS8GfnzH8kqY
 M6R2TmcTvDUCufyjEcqqx0aWhmo8UH8RzP9gvPwT8RV3bxrcwNsllTWY2hEbS1u0X3oryTV5j
 dP8AtF1VmbWWvHlAE4c8R19jJryky9Ky4izx65dghxLsbHDMfWrICwWhcMrQcPcQjrJxwOEh7
 3FyOyNK7ge3bdiSt/eGD9ETs7kYWiZIavGSJXiQTRw==
Precedence: bulk

Hi,

Am 13.04.23 um 21:28 schrieb Tim Gover:
> On Thu, 13 Apr 2023 at 19:44, Stefan Wahren <stefan.wahren@i2se.com> wrote:
>>
>> Hi Ivan,
>>
>> Am 13.04.23 um 20:18 schrieb Ivan T. Ivanov:
>>> On 04-13 18:15, Stefan Wahren wrote:
>>>>
>>>> Hi Ivan,
>>>>
>>>> Am 13.04.23 um 10:52 schrieb Ivan T. Ivanov:
>>>>> From: Tim Gover <tim.gover@raspberrypi.com>
>>>>>
>>>>> Make a copy of the bootloader secure-boot public key available to the OS
>>>>> via an nvmem node. The placement information is populated by the
>>>>> Raspberry Pi firmware if a public key is present in the BCM2711
>>>>> bootloader EEPROM.
>>>>
>>>> It would be nice to have a helpful link like:
>>>> https://www.raspberrypi.com/documentation/computers/configuration.html#nvmem-nodes
>>>
>>> Yep, make sense.
>>>
>>>>> +
>>>>> +   /*
>>>>> +    * RPi4 will copy the binary public key blob (if present) from the bootloader
>>>>> +    * into memory for use by the OS.
>>>>> +    */
>>>>> +   blpubkey: nvram@1 {
>>>>> +           compatible = "raspberrypi,bootloader-public-key", "nvmem-rmem";
>>>>
>>>> Yes this looks better, but this introduce a new dtbs_check issue. The new
>>>
>>> Oops, yes, I forgot to make this check.
>>>
>>>> compatible must be documented in
>>>> Documentation/devicetree/bindings/nvmem/rmem.yaml in a separate patch and
>>>> reviewed by the DT guys.
>>>
>>> Or I can drop the new compatible string altogether? It looks like
>>> only alias is strictly required?! Tim Gover is this correct?
>>
>> i cannot speak for the firmware side, but i think we should try to keep
>> it compatible with the vendor DTB here.
>>
> 
> The firmware doesn't look at the compatible string. It locates the
> nodes to update using the 'blconfig' and 'blpubkey' aliases. Userspace
> scripts (including the documentation example) should also use these
> aliases.
> Therefore, I don't think it matters if the compatible strings is
> modified, but I won't pretend to know what the correct DT style is
> here :)

okay, regardless of the compatible string the patch must be send to the 
DT maintainers and the devicetree mailing list otherwise they don't have 
any chance to review.

Thanks

> 
> Tim