Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 16 Apr 2023 21:25:50 +0800
From:   Chao Gao <chao.gao@intel.com>
To:     Binbin Wu <binbin.wu@linux.intel.com>
CC:     <kvm@vger.kernel.org>, Jiaan Lu <jiaan.lu@intel.com>,
        Zhang Chen <chen.zhang@intel.com>,
        Sean Christopherson <seanjc@google.com>,
        "Paolo Bonzini" <pbonzini@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        "Ingo Molnar" <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>, <x86@kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH v2 02/11] KVM: x86: Advertise CPUID.7.2.EDX and
 RRSBA_CTRL support
Message-ID: <ZDvDAlc/TOrIjvlS@chao-env>
References: <20230414062545.270178-1-chao.gao@intel.com>
 <20230414062545.270178-3-chao.gao@intel.com>
 <2ff6d934-bd9c-227b-9693-911a85145da7@linux.intel.com>
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <2ff6d934-bd9c-227b-9693-911a85145da7@linux.intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?q2+voTK82iiL3PpZGSdfzFt9MK02ZufiE4/daRVEtLmWSSRbin0vjjcQlw?=
 =?iso-8859-1?Q?Tq7RpNaEYw2RLBe/883LJnmRRgfHz5QiRuxgDWyI0Jy4OMCYQDQ5ZAOXoS?=
 =?iso-8859-1?Q?h5T6vlUtBl6M289/lR72utp5pl3PxZ+ZeEvMbX+TllxpfK4NjC7ZoR9UCV?=
 =?iso-8859-1?Q?eyt4F+zlfE4u8n+6CM2uCqcTUxJ7SSAEtnpLDAtQXiA+ZuS3jQaDSQtSfY?=
 =?iso-8859-1?Q?qHTJeNzTg5U8f3rS3bFGYewapQEnapxW6Vy7E3s7W0t8WGlhN/BtU4aEJq?=
 =?iso-8859-1?Q?U54rpoa7aJArrGNrU5SzhNvLWb4RBNuy6gCD+pmJ7y0lAHm0YDqnMlNQ/u?=
 =?iso-8859-1?Q?DdU72uRpo9gS+W+fDgLcGieddfFFqfV+GugrqnPMLTxVRpOd23Z03otTKX?=
 =?iso-8859-1?Q?kLtnUm8/loY3uBDimAEPume10ymI3TaBdtbubjazGcDNu5EKfANUcRdPZg?=
 =?iso-8859-1?Q?YgN87OfG7yvoax5O5i2XWeJrZhS5E9fvOVwCLEO8o8qg5YRg7mXJJE29+3?=
 =?iso-8859-1?Q?2snz7osBDerI2wOdHJhSAlP/1mnfMGVQDqc7w4EokhLDsGKDIp8TfbrAeV?=
 =?iso-8859-1?Q?kidC63+vGkYAzOi31FJWln7PoEhA3X03K81ftoq0PLnw1YdpAb+hCViekf?=
 =?iso-8859-1?Q?LuZBNB4/1cTwgIJs9P1LV9wLm/5oO/OCj99pz8R8NfmuNluIhDilAAm0zq?=
 =?iso-8859-1?Q?c3rmhBdEP1rHz8l/CRgfkuzQfcYf+0vv3IVDYmw/+qOagF3E2Ii7bZ2Gwu?=
 =?iso-8859-1?Q?dlsquCBwwgVwMs4+Do7BgpjHCRSX232qK6eSUiT1/p5Odr2eXNrJrH5rTS?=
 =?iso-8859-1?Q?NEKpXqcDDZZG7YS6ov4EhcKlOrr3TmtGAmswuwQ8PNKnEQw9WEHS2/EtOz?=
 =?iso-8859-1?Q?bQUQyADebcn/d7McRJax5J3hUQHhhqH3WoXs7nCUkj8T6CIvrXBUjmHYKU?=
 =?iso-8859-1?Q?xR3sClYRwAGsz31WREQQpjnGZudORZsgGuOD0vf45ueq79bHsVKXs089qF?=
 =?iso-8859-1?Q?g8/Mz3gH4vFGLFOiDId0OWGECRidrNwPySflWi7PArfhXQtMq5202LTpkx?=
 =?iso-8859-1?Q?Ujn2wPnKyGZlXpYb9LFXA++DrRrdtMMqGDhKwGfn7W/NMNeFifAYgW77Bl?=
 =?iso-8859-1?Q?TD+1sGzrML9buLDKVlTblytXXMGIIo/Gn2eGEpzpZOiEjts7rqCF8VebV3?=
 =?iso-8859-1?Q?3r3q9Sk6KSbQsRSJ1Jbbe06FvG15CyYEvMDWrNS/ofkY1oVQDjG66XxtoI?=
 =?iso-8859-1?Q?iThEa0CcMPs7DG2DzqIhjkKMO0bIwv9MlJC3ktrTk3/scX3yIZcXp6+iN6?=
 =?iso-8859-1?Q?I6Kc6W37NHouQbcqTKCX+IcvE/sxljzrmAB850HdRIW3N6dRU1a+tZkbKh?=
 =?iso-8859-1?Q?HaDrPmoc13CDxpRTcJTDTtK83Z+7vZFqUCh4fxIj3isVY7i39oIGXI93E1?=
 =?iso-8859-1?Q?vqC2uOHoeZG7M4hOg7WUYUdUlq24yc064hcJfOBfWbzkEjauaGJn0PCO9Y?=
 =?iso-8859-1?Q?1nqKR1XN2rXdi53XXCH7JH+5LDPTVocew+TAQN+9gCM6n59KULyNd5MxHd?=
 =?iso-8859-1?Q?0aWovzuYhHhz85+SXBKh1DvoPJLuRz6aRZjML5t6jfXlppWtCapiblJTis?=
 =?iso-8859-1?Q?yZXB0rhQ6wM2Z/KmmRUwDu4zuVAISNsaE3?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5226a1eb-45af-4880-1444-08db3e7e1ef1
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB6780.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Apr 2023 13:26:01.3842
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dagIl1syzNNI8ckNAmiPYQIuVTMREAuYYUko5NNS2htNnL7D9BQGIQux0TyZtY1+2wxHapYVL6Oh38OWCpMKMQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6490
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Apr 16, 2023 at 03:04:59PM +0800, Binbin Wu wrote:
>
>On 4/14/2023 2:25 PM, Chao Gao wrote:
>> From: Zhang Chen <chen.zhang@intel.com>
>> 
>> Add a kvm-only CPUID feature leaf for CPUID.7.2.EDX and RRSBA_CTRL
>> as the first feature in the leaf.
>> 
>> RRSBA_CTRL is enumerated by CPUID.7.2.EDX[2]. If supported, RRSBA_DIS_U
>> (bit 5) and RRSBA_DIS_S (bit 6) of IA32_SPEC_CTRL MSR can be used to
>> disable RRSBA behavior for CPL3 and CPL0/1/2 respectively.
>> 
>> Note that KVM does not intercept guests' IA32_SPEC_CTRL MSR accesses
>> after a non-zero is written to the MSR. Therefore, guests can already
>> toggle the two bits if the host supports RRSBA_CTRL, and no extra code
>> is needed to allow guests to toggle the two bits.
>> 
>> Signed-off-by: Zhang Chen <chen.zhang@intel.com>
>> Signed-off-by: Chao Gao <chao.gao@intel.com>
>> Tested-by: Jiaan Lu <jiaan.lu@intel.com>
>> ---
>>   arch/x86/kvm/cpuid.c         | 22 +++++++++++++++++++---
>>   arch/x86/kvm/reverse_cpuid.h |  7 +++++++
>>   2 files changed, 26 insertions(+), 3 deletions(-)
>> 
>> diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c
>> index 9583a110cf5f..f024c3ac2203 100644
>> --- a/arch/x86/kvm/cpuid.c
>> +++ b/arch/x86/kvm/cpuid.c
>> @@ -685,6 +685,10 @@ void kvm_set_cpu_caps(void)
>>   		SF(SGX1) | SF(SGX2) | SF(SGX_EDECCSSA)
>>   	);
>> +	kvm_cpu_cap_init_kvm_defined(CPUID_7_2_EDX,
>> +		SF(RRSBA_CTRL)
>> +	);
>> +
>
>Is it slightly better to put the new added one after
>
>??? kvm_cpu_cap_init_kvm_defined(CPUID_7_1_EDX, ...
>
>to make it in order?

Yes. Will do.