Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 16 Apr 2023 19:59:04 +0300
From:   Vladimir Oltean <olteanv@gmail.com>
To:     Oleksij Rempel <o.rempel@pengutronix.de>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Andrew Lunn <andrew@lunn.ch>,
        Eric Dumazet <edumazet@google.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Woojung Huh <woojung.huh@microchip.com>,
        Arun Ramadoss <arun.ramadoss@microchip.com>,
        kernel@pengutronix.de, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org, UNGLinuxDriver@microchip.com
Subject: Re: [PATCH net-next v1 2/2] net: dsa: microchip: Add partial ACL
 support for ksz9477 switches
Message-ID: <20230416165904.2y7zwgyxwltjzj7m@skbuf>
References: <20230411172456.3003003-1-o.rempel@pengutronix.de>
 <20230411172456.3003003-3-o.rempel@pengutronix.de>
 <20230413042936.GA12562@pengutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230413042936.GA12562@pengutronix.de>
Precedence: bulk

On Thu, Apr 13, 2023 at 06:29:36AM +0200, Oleksij Rempel wrote:
> According to KSZ9477S 5.2.8.2 Port Priority Control Register
> "To achieve the desired functionality, do not set more than one bit at a
> time in this register.
> ...
> Bit 6 - OR’ed Priority
> ...
> Bit 2 - 802.1p Priority Classification
> Bit 1 - Diffserv Priority Classification
> Bit 0 - ACL Priority Classification
> "
> @Arun  what will happen if multiple engines are used for packet
> prioritization? For example ACL || Diffserv || 802.1p... ?
> If I see it correctly, it is possible but not recommended. Should I
> prevent usage of multiple prio sources? 

You could try and find out which one takes priority... we support VLAN
PCP and DSCP prioritization through the dcbnl application priority table.