Received: by 2002:a05:6358:53a8:b0:117:f937:c515 with SMTP id z40csp3119326rwe; Sun, 16 Apr 2023 12:08:30 -0700 (PDT) X-Google-Smtp-Source: AKy350Z425FF2HZHyPDqdAXbeZAIv6QIvsTL2vXs5lBRtAaqi+LOuD/pMsweb7ZFydNzLmI97lnb X-Received: by 2002:a17:902:d48e:b0:1a6:dc4a:b8f8 with SMTP id c14-20020a170902d48e00b001a6dc4ab8f8mr1095547plg.38.1681672110153; Sun, 16 Apr 2023 12:08:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681672110; cv=none; d=google.com; s=arc-20160816; b=QI28VNRtWfnGpq58DJTzzorH+Cet58+OXT+rdb+MUvb12mRYUomDfjizYlo0t4QShw 1Py8Lm9l676DsXK4yIrnQCTjMtIy0hi1arXud2Z3Ri7WkXAiBbp7mFj3pCI/75CdJfGq rWAndWU4eJhMZfGptRSXZppH7VHjWe7nD9h1kfGchR7x7rpyNaKtAiVgO2/UMc0fF6AJ WBG9r2AJmDV20qI0/M+y8tge1BXWnKf5vyX6JwdMPxmlCnExTohavROHh4xmhaBF9BI6 9rJh7tYRYPAoxTbhQIoaDPA/WJoFSFtRP8mptGeciFR+EzyDShYjVYEoPmE9EtCfoRzG vGyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=9Sz194YkTjiHWHU6EwyUZFw+SUiZ9p2+4bs7KVCWW2A=; b=W/83EordjYPvPnHgy9l4UKhoUTo24QW8o75RfB2OqIUjmvhRAwTMIVxBV2fPW8QQMF R+/2iO9QElGSMVLGdhgVjvuQ44xPmAD73HX84UzgArQw4oo0XSx2V5p3pJ1RVj4Est9g ha1KmIP50e33Rl3vBnIj7zfVWtOU29Fy1mlPAQm1irMytUVP8p/zpf22yqkI/P2iyABz LLXhtnHOW7U9n65X59+smkS5UiqiaeEq64S6BnvxF9RJ04td5p71K9kzvVJY7tCMUTlL 7XjJskhyPYskrmvK2mf61VBFTOCidh9z367tXayJgn3FF0PWfEoTJsAXh6jeiHTLU/z/ Aukw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20221208.gappssmtp.com header.s=20221208 header.b=YsXwiRJP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c7-20020a170903234700b001893c960ac9si10999690plh.533.2023.04.16.12.08.18; Sun, 16 Apr 2023 12:08:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20221208.gappssmtp.com header.s=20221208 header.b=YsXwiRJP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230063AbjDPTCl (ORCPT + 99 others); Sun, 16 Apr 2023 15:02:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230071AbjDPTCj (ORCPT ); Sun, 16 Apr 2023 15:02:39 -0400 Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9CA1A1FE0 for ; Sun, 16 Apr 2023 12:02:35 -0700 (PDT) Received: by mail-pf1-x435.google.com with SMTP id d2e1a72fcca58-63b78525ac5so576318b3a.0 for ; Sun, 16 Apr 2023 12:02:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20221208.gappssmtp.com; s=20221208; t=1681671755; x=1684263755; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9Sz194YkTjiHWHU6EwyUZFw+SUiZ9p2+4bs7KVCWW2A=; b=YsXwiRJP0NXEjK+RH7+/TXmJTwfxsPnrrZbXOPSmesB18YcDroRhIOFx6C/ps+8Mnc q+iCq5t5dVYp9Guj6BJW+jAPv5f1kw5yhqlWxZMV8UblOVUZSjOfk7uyhz7l84q5Fr9D UJgrABdzODvM4SFCQ2FlKAd9oZ5WkL2E9IN+ADeqmftZ9XAEsB6J9tfWpM83R2Nwqii6 2RTlZlvl6iOdcDePuc1V51e1hxb9F+tN6gR1JhqcSMkPhVFKBwBovJojs2iRAfs+xHAE iDUMYjMiA5g3DEUtGDGH1DTL6uG6F2xCtpsxW/ejixTfGz955R6CQvCJTx2/p1QZ4IK7 G2rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681671755; x=1684263755; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9Sz194YkTjiHWHU6EwyUZFw+SUiZ9p2+4bs7KVCWW2A=; b=BWwo+mVXCzBPkqlPG1BEz0r8kAvJxbSe3b9jGlNIer8qnnV1cUq86LSjkEuVm2CrAS 9H1x0+TPs5OAiTEzPtfW/UQTNrE9zfhawH7hHxC4E2ESBEVW007xY+7oc3WU2W2aE8O2 s6UTvrSEEufd7XRREG5BrUG7zx9V2BOW+j+gju20Iz+J+wRb70APrlSKwY0xfs47v8LG f1uLjp4exOP+B403zGmC008EPoyNTOpOl8NJaghNxlR6diy+aSuCh/V+N1E6jERcmI42 bw6W9wACcvndTGXfQzzTGZDjom9KCyhke+X8VlzdPE1AUfXDnD8m3cPTpw8jCjXgOE+B YJqg== X-Gm-Message-State: AAQBX9fr6Hrre3PJBUUwPo1eUdjjQ8MxBSOx9kdt/Cq0PaKBJlxksUUM mz8K1QW7IaiFuleKgUrMWi6svfDzmLEqUWhOZ48= X-Received: by 2002:a05:6a00:8018:b0:63b:61cc:5aaa with SMTP id eg24-20020a056a00801800b0063b61cc5aaamr9432015pfb.1.1681671755034; Sun, 16 Apr 2023 12:02:35 -0700 (PDT) Received: from [127.0.0.1] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id 12-20020aa7924c000000b006258dd63a3fsm6176156pfp.56.2023.04.16.12.02.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Apr 2023 12:02:34 -0700 (PDT) From: Jens Axboe To: Paolo Valente , linux-block@vger.kernel.org, Colin Ian King Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20230413133009.1605335-1-colin.i.king@gmail.com> References: <20230413133009.1605335-1-colin.i.king@gmail.com> Subject: Re: [PATCH] block, bfq: Fix division by zero error on zero wsum Message-Id: <168167175425.156307.13715193817993910123.b4-ty@kernel.dk> Date: Sun, 16 Apr 2023 13:02:34 -0600 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.13-dev-00303 X-Spam-Status: No, score=1.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 13 Apr 2023 14:30:09 +0100, Colin Ian King wrote: > When the weighted sum is zero the calculation of limit causes > a division by zero error. Fix this by continuing to the next level. > > This was discovered by running as root: > > stress-ng --ioprio 0 > > [...] Applied, thanks! [1/1] block, bfq: Fix division by zero error on zero wsum commit: e53413f8deedf738a6782cc14cc00bd5852ccf18 Best regards, -- Jens Axboe