Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 16 Apr 2023 23:25:49 +0200
From:   Andreas Kemnade <andreas@kemnade.info>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     pavel@ucw.cz, lee@kernel.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, linux-leds@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        Matti Vaittinen <mazziesaccount@gmail.com>
Subject: Re: [PATCH v4 1/2] dt-bindings: leds: Add ROHM BD2606MVV LED driver
Message-ID: <20230416232549.3b0a5eed@aktux>
In-Reply-To: <7fe8d6f5-ab0f-c6d5-2551-7beb3dfb16d7@linaro.org>
References: <20230414055341.335456-1-andreas@kemnade.info>
        <20230414055341.335456-2-andreas@kemnade.info>
        <f9da7499-3fb3-1ce6-db0b-d87febee2052@linaro.org>
        <20230414175412.37a15572@aktux>
        <7fe8d6f5-ab0f-c6d5-2551-7beb3dfb16d7@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On Fri, 14 Apr 2023 23:17:56 +0200
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:

> On 14/04/2023 17:54, Andreas Kemnade wrote:
> > On Fri, 14 Apr 2023 17:28:49 +0200
> > Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> >   
> >> On 14/04/2023 07:53, Andreas Kemnade wrote:  
> >>> Document ROHM BD2606MVV LED driver devicetree bindings.    
> >>
> >> Subject: no improvements and no comments from your side. Why?
> >>  
> > old subject (v2):
> > 
> > dt-bindings: leds: ROHM BD2606MVV LED driver
> > 
> > Your comment:
> > Subject: maybe drop "driver" (suggests it is for Linux drivers, although
> > maybe it matches the actual hardware here?) and add missing verb, e.g.
> > "Add ROHM ..."
> > 
> > New Subject (v3/4):
> > dt-bindings: leds: Add ROHM BD2606MVV LED driver
> > 
> > What is still missing?  
> 
> There is still "driver". Comment was: drop "driver". Where is it dropped?
> 
> If you do not agree, sure, just respond with something.
> 
I am fine with both. On one hand BD2606MVV is not a LED by itself
but LEDs can be connected to it. so the chip itself can be called LED driver.

But on the other hand I think that holds true for everything in drivers/leds
and binding/leds and we do not call the subsystem leddriver.
So there are reasons for and against "driver" in the subject line.

Regards,
Andreas