Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 17 Apr 2023 00:43:16 +0200
From:   Samuel Thibault <samuel.thibault@ens-lyon.org>
To:     Dominique Martinet <asmadeus@codewreck.org>
Cc:     James Chapman <jchapman@katalix.com>, tparkin@katalix.com,
        edumazet@google.com, davem@davemloft.net, kuba@kernel.org,
        pabeni@redhat.com, corbet@lwn.net, netdev@vger.kernel.org,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PPPoL2TP: Add more code snippets
Message-ID: <20230416224316.xlvgjor65nejldwh@begin>
Mail-Followup-To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
        Dominique Martinet <asmadeus@codewreck.org>,
        James Chapman <jchapman@katalix.com>, tparkin@katalix.com,
        edumazet@google.com, davem@davemloft.net, kuba@kernel.org,
        pabeni@redhat.com, corbet@lwn.net, netdev@vger.kernel.org,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230416220704.xqk4q6uwjbujnqpv@begin>
 <ZDx2IUYTmLSdzU6D@codewreck.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZDx2IUYTmLSdzU6D@codewreck.org>
Organization: I am not organized
User-Agent: NeoMutt/20170609 (1.8.3)
Precedence: bulk

Dominique Martinet, le lun. 17 avril 2023 07:26:41 +0900, a ecrit:
> > +The ppp<ifunit> interface can then be configured as usual with SIOCSIFMTU,
> > +SIOCSIFADDR, SIOCSIFDSTADDR, SIOCSIFNETMASK, and activated by setting IFF_UP
> > +with SIOCSIFFLAGS
> 
> (That somewhat makes it sounds like the "new" netlink interface cannot
> be used (e.g. ip command);

Ah, right...

> although I guess sommeone implementing this would be more likely to
> use the ioctls than not so having the names can be a timesaver?)

It's indeed a timesaver to have the ioctl names, but perhaps we can
replace this part with a pointer to a if-configuration documentation?

> Also, this got me wondering if the 'if' fd can be closed immediately or
> if the interface will be removed when the fd is closed (probably not?)

Closing the fd would close the if, yes. AIUI one really has to keep the
pppox socket (for stats), the ppp chan (for non-data ppp packets), and
the ppp if (for the if).

Samuel