Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <91eded3b-0ad8-b092-bf17-7b34fd4ece65@huawei.com>
Date:   Mon, 17 Apr 2023 09:51:01 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.1
Subject: Re: [PATCH] mm: rename reclaim_pages() to reclaim_folios()
Content-Language: en-US
To:     Matthew Wilcox <willy@infradead.org>
CC:     Andrew Morton <akpm@linux-foundation.org>, <linux-mm@kvack.org>,
        SeongJae Park <sj@kernel.org>, Hugh Dickins <hughd@google.com>,
        <linux-kernel@vger.kernel.org>
References: <20230415092716.61970-1-wangkefeng.wang@huawei.com>
 <ZDrK9R9wLlfrUWMZ@casper.infradead.org>
From:   Kefeng Wang <wangkefeng.wang@huawei.com>
In-Reply-To: <ZDrK9R9wLlfrUWMZ@casper.infradead.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2023/4/16 0:04, Matthew Wilcox wrote:
> On Sat, Apr 15, 2023 at 05:27:16PM +0800, Kefeng Wang wrote:
>> As commit a83f0551f496 ("mm/vmscan: convert reclaim_pages() to use
>> a folio") changes the arg from page_list to folio_list, but not
>> the defination, let's correct it and rename it to reclaim_folios too.
> 
> I didn't bother.  It's not inaccurate; we're reclaiming the pages
> in the folios.

OK, keep the name seems better, there is another similar issue in
reclaim_clean_pages_from_list(), I will only unify the arg between
definition and declaration.>