Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753195AbXI0DSt (ORCPT ); Wed, 26 Sep 2007 23:18:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751975AbXI0DSl (ORCPT ); Wed, 26 Sep 2007 23:18:41 -0400 Received: from smtp.ocgnet.org ([64.20.243.3]:57486 "EHLO smtp.ocgnet.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751269AbXI0DSk (ORCPT ); Wed, 26 Sep 2007 23:18:40 -0400 Date: Thu, 27 Sep 2007 12:18:21 +0900 From: Paul Mundt To: Valdis.Kletnieks@vt.edu Cc: mgross@linux.intel.com, Randy Dunlap , linux-pm , lkml Subject: Re: [RFC] QoS params patch Message-ID: <20070927031821.GA26307@linux-sh.org> Mail-Followup-To: Paul Mundt , Valdis.Kletnieks@vt.edu, mgross@linux.intel.com, Randy Dunlap , linux-pm , lkml References: <20070926223712.GA22029@linux.intel.com> <20070926224026.GA23218@linux.intel.com> <20070926164159.3b43479b.randy.dunlap@oracle.com> <20070927004020.GB29906@linux.intel.com> <22087.1190861583@turing-police.cc.vt.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <22087.1190861583@turing-police.cc.vt.edu> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1383 Lines: 26 On Wed, Sep 26, 2007 at 10:53:03PM -0400, Valdis.Kletnieks@vt.edu wrote: > On Wed, 26 Sep 2007 17:40:20 PDT, Mark Gross said: > > --- linux-2.6.23-rc8/kernel/Makefile 2007-09-26 13:54:54.000000000 -0700 > > +++ linux-2.6.23-rc8-qos/kernel/Makefile 2007-09-26 14:06:38.000000000 - > 0700 > > @@ -9,7 +9,7 @@ > > rcupdate.o extable.o params.o posix-timers.o \ > > kthread.o wait.o kfifo.o sys_ni.o posix-cpu-timers.o mutex.o \ > > hrtimer.o rwsem.o latency.o nsproxy.o srcu.o die_notifier.o \ > > - utsname.o > > + utsname.o qos_params.o > > So I don't get a choice in the matter if I will be dragging this thing > around in my kernel, even if I have no intention of using the functionality? > You don't get that option with latency.c either at the moment, and it's arguable whether it's even worth it. The more curious thing is that while this qos params seems to be an evolution of Arjan's latency.c (and the drivers that are using it are updated in the rest of the patch set), latency.c itself is still compiled in. Is this an oversight, or was it intentional? One set of latency hinting APIs only, please :-) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/