Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230412055852.971991-1-dddddd@hust.edu.cn>
In-Reply-To: <20230412055852.971991-1-dddddd@hust.edu.cn>
From:   Peter Chen <hzpeterchen@gmail.com>
Date:   Mon, 17 Apr 2023 10:04:08 +0800
Message-ID: <CAL411-qGHzMPopY_5u3r5Nu8NHYVaqU6JNKaGryqFjNPtoFUvQ@mail.gmail.com>
Subject: Re: [PATCH] usb: chipidea: fix missing goto in `ci_hdrc_probe`
To:     Yinhao Hu <dddddd@hust.edu.cn>
Cc:     Peter Chen <peter.chen@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        hust-os-kernel-patches@googlegroups.com,
        Dongliang Mu <dzm91@hust.edu.cn>,
        Peter Chen <peter.chen@freescale.com>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Apr 12, 2023 at 2:01=E2=80=AFPM Yinhao Hu <dddddd@hust.edu.cn> wrot=
e:
>
> From the comment of ci_usb_phy_init, it returns an error code if
> usb_phy_init has failed, and it should do some clean up, not just
> return directly.
>
> Fix this by goto the error handling.
>
> Fixes: 74475ede784d ("usb: chipidea: move PHY operation to core")
> Signed-off-by: Yinhao Hu <dddddd@hust.edu.cn>
> Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>
> ---
>  drivers/usb/chipidea/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
> index 281fc51720ce..25084ce7c297 100644
> --- a/drivers/usb/chipidea/core.c
> +++ b/drivers/usb/chipidea/core.c
> @@ -1108,7 +1108,7 @@ static int ci_hdrc_probe(struct platform_device *pd=
ev)
>         ret =3D ci_usb_phy_init(ci);
>         if (ret) {
>                 dev_err(dev, "unable to init phy: %d\n", ret);
> -               return ret;
> +               goto ulpi_exit;
>         }
>
>         ci->hw_bank.phys =3D res->start;
> --
> 2.34.1
>

Acked-by: Peter Chen <peter.chen@kernel.org>

Peter