Received: by 2002:a05:6358:53a8:b0:117:f937:c515 with SMTP id z40csp3416994rwe; Sun, 16 Apr 2023 19:53:39 -0700 (PDT) X-Google-Smtp-Source: AKy350YQGh91PffO3rMXu3DZBOS/doVFIdPW9o42ReNJ/yY0oXKIZriGA6uQgPji45skg8z/RjoW X-Received: by 2002:a05:6a20:2445:b0:ef:85a6:464d with SMTP id t5-20020a056a20244500b000ef85a6464dmr3740624pzc.13.1681700019658; Sun, 16 Apr 2023 19:53:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681700019; cv=none; d=google.com; s=arc-20160816; b=WvflCEbb04529lei5+UMYIjQl2i0Ug7UHCDfFoGOvkXlcxf1oH9W3iPOtna+MJyY0V lJr1HGwsBNHnrSCN1FVMOoDlZFLDDYJgsvWwK402/JZOgDwWxmd9W4BTNM8jUAf3ViPj tlwoRXVbE02BFDwmZlqbiOKWSLtof02rznleRhRnhW7Go3l+44nxuSZwwQlvetXbUdr9 qyz2FbJt+54hMvTAlTMW5rw4EM9zr1vijG1TsOmTNBiYVHRohcPpW0N5IaIyCHS6DUQ2 dKdXC0zODK1FTl4aQfN32kUwCLR6Qkdxb3MQD1bgKoe7BfYb526ldiMFDvdxOQiUkz5K hoVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=J0FGTmUrLx+j+AGEiyeNq3HtAlIDUKglYm4c41XRe4g=; b=eA5mQvHsBJ2xETPBiVg/AQQheM582Ow8fXZ9jC6ReW4JKkXpvedxd/61ZXuRQU4B5A SHlbUtkfzGi+xt8GTmR1lGT/xa8azCoOn0rV6akLNZsMqwvUFIH3pqZrYBzV/vfbWq4h nxUh7WM+iDOZtBAfoXXwqS/KgkhqMljGTvvMLo1DMmnweAnBEl9wkxJCN6PJ1MWE4eGo 0LRkKAQ/7dW52oztCmJ7zjbVN2YqMcPXnufH4Yzw4wUeeH3vB+vfrladttopILUZtgF+ DwsZxSFbA7CKijeubogp3gRGjBTxYLlnLBRyHti6kmceboK01PammdtFXTa0Zx9sXqkT 8//w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mediatek.com header.s=dk header.b=q1sI64MJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c23-20020a634e17000000b0051ace49ded1si11129094pgb.886.2023.04.16.19.53.28; Sun, 16 Apr 2023 19:53:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@mediatek.com header.s=dk header.b=q1sI64MJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229830AbjDQCw1 (ORCPT + 99 others); Sun, 16 Apr 2023 22:52:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229849AbjDQCwR (ORCPT ); Sun, 16 Apr 2023 22:52:17 -0400 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 853391FFC; Sun, 16 Apr 2023 19:52:15 -0700 (PDT) X-UUID: d74d9bbcdcca11edb6b9f13eb10bd0fe-20230417 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=J0FGTmUrLx+j+AGEiyeNq3HtAlIDUKglYm4c41XRe4g=; b=q1sI64MJYy+5vRMgq9Ddwr0SVDHFUMnFOEbrBiMVYgAUQshlBrWTfhcQrvSJHLLSl1X4FVCAjBKCrO2YQYuaY8+y1N2q14XSrp+lUYJQQq9CbT2EXeRoyf3emKYq0na+nN6ZGAnSlqY4fk07ACAN3rVxhnQAOEWwj0U4EdYUg28=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.22,REQID:c8eafc9d-040d-49eb-89f9-e99c14ebf179,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:120426c,CLOUDID:171628eb-db6f-41fe-8b83-13fe7ed1ef52,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:11|1,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-UUID: d74d9bbcdcca11edb6b9f13eb10bd0fe-20230417 Received: from mtkmbs11n2.mediatek.inc [(172.21.101.187)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 639314019; Mon, 17 Apr 2023 10:52:07 +0800 Received: from mtkmbs11n1.mediatek.inc (172.21.101.185) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.25; Mon, 17 Apr 2023 10:52:06 +0800 Received: from mhfsdcap04.gcn.mediatek.inc (10.17.3.154) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.1118.25 via Frontend Transport; Mon, 17 Apr 2023 10:52:06 +0800 From: Chunfeng Yun To: Greg Kroah-Hartman , Rob Herring CC: Chunfeng Yun , Krzysztof Kozlowski , Matthias Brugger , AngeloGioacchino Del Regno , , , , , , Tianping Fang Subject: [PATCH v3 2/7] usb: mtu3: use boolean return value Date: Mon, 17 Apr 2023 10:51:58 +0800 Message-ID: <20230417025203.18097-2-chunfeng.yun@mediatek.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230417025203.18097-1-chunfeng.yun@mediatek.com> References: <20230417025203.18097-1-chunfeng.yun@mediatek.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-MTK: N X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Prefer to use boolean value due to gpd_ring_empty() return true or false. See "16) Function return values and names" in coding-style.rst Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Chunfeng Yun --- v3: no changes v2: add Reviewed-by AngeloGioacchino --- drivers/usb/mtu3/mtu3_qmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/mtu3/mtu3_qmu.c b/drivers/usb/mtu3/mtu3_qmu.c index a4da1af0b2c0..6be4977a5db5 100644 --- a/drivers/usb/mtu3/mtu3_qmu.c +++ b/drivers/usb/mtu3/mtu3_qmu.c @@ -221,7 +221,7 @@ static struct qmu_gpd *advance_deq_gpd(struct mtu3_gpd_ring *ring) } /* check if a ring is emtpy */ -static int gpd_ring_empty(struct mtu3_gpd_ring *ring) +static bool gpd_ring_empty(struct mtu3_gpd_ring *ring) { struct qmu_gpd *enq = ring->enqueue; struct qmu_gpd *next; -- 2.18.0