Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230330102013.545588-1-keguang.zhang@gmail.com>
 <20230330102013.545588-2-keguang.zhang@gmail.com> <20230330113053.GB9674@alpha.franken.de>
In-Reply-To: <20230330113053.GB9674@alpha.franken.de>
From:   Keguang Zhang <keguang.zhang@gmail.com>
Date:   Mon, 17 Apr 2023 11:28:17 +0800
Message-ID: <CAJhJPsWDP1Wvef2HGhAqiL77bDRMzz37XkXkVWgzW7Ca54p5XA@mail.gmail.com>
Subject: Re: [PATCH 1/2] MIPS: Loongson32: Remove reset.c
To:     Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc:     linux-watchdog@vger.kernel.org, linux-mips@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Wim Van Sebroeck <wim@linux-watchdog.org>,
        Guenter Roeck <linux@roeck-us.net>,
        Yang Ling <gnaygnil@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Mar 30, 2023 at 7:33=E2=80=AFPM Thomas Bogendoerfer
<tsbogend@alpha.franken.de> wrote:
>
> On Thu, Mar 30, 2023 at 06:20:12PM +0800, Keguang Zhang wrote:
> > The Loongson-1 restart handler will be moved to watchdog driver,
> > then _machine_restart is no longer needed.
> > The _machine_halt and pm_power_off are also unnecessary,
> > which contain no hardware operations.
> >
> > Therefore, remove the entire reset.c and related header file.
> > Update the Makefile accordingly.
> >
> > Signed-off-by: Keguang Zhang <keguang.zhang@gmail.com>
> > ---
> >  .../include/asm/mach-loongson32/regs-wdt.h    | 15 ------
> >  arch/mips/loongson32/common/Makefile          |  2 +-
> >  arch/mips/loongson32/common/reset.c           | 51 -------------------
> >  3 files changed, 1 insertion(+), 67 deletions(-)
> >  delete mode 100644 arch/mips/include/asm/mach-loongson32/regs-wdt.h
> >  delete mode 100644 arch/mips/loongson32/common/reset.c
>
> Acked-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
>
Thomas,
Sorry! I forgot to remove the reference to regs-wdt.h, which will
cause a build error.
Could you please review v2:
https://lore.kernel.org/all/20230330112051.551648-2-keguang.zhang@gmail.com=
/
Thanks very much!

> --
> Crap can work. Given enough thrust pigs will fly, but it's not necessaril=
y a
> good idea.                                                [ RFC1925, 2.3 =
]


--
Best regards,

Keguang Zhang