Received: by 2002:a05:6358:53a8:b0:117:f937:c515 with SMTP id z40csp3581005rwe; Sun, 16 Apr 2023 23:40:41 -0700 (PDT) X-Google-Smtp-Source: AKy350Zn2dpL+/JnFY/rsYFcuxKkVRY9yr8CeIvyqBngAj35AusKu3w9P7sBMW/4kC20qNedhH4/ X-Received: by 2002:a05:6a20:3a88:b0:eb:e869:6919 with SMTP id d8-20020a056a203a8800b000ebe8696919mr13099423pzh.21.1681713641685; Sun, 16 Apr 2023 23:40:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681713641; cv=none; d=google.com; s=arc-20160816; b=nz7lfcfUFCeemYtcWfkVDg+JlLirOawQ4LHeMUrd5Cs6y1NnxN2Ina65Oyk0eugOe2 NvnhFWRr8tkFue5XPEUkPYzF5saBHStLGGzRdaAbP9CNq8sqdOX/j/TfY70Rc3lNAXci vESvnL8uiyJJO71kUgE2os28MYi9v9ZXJIKDIPuWolDxEL6XBXhcOioxLLxPqGQTL5ak tRuNKIstKEwLvQDyrHf8q6Zq0fiGJsO1SfALqrJ0MjrjVfvYymXGi04co4S3tJdGHMrw V3liukV9raPfPnFGkHFxiqOgRdBQz/3xqxeKXBJdDxWf+AHZLV7DFQ49XCE7Gp/+dqkg h+DQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=MdcEqIopRGNeL8ynxUzh+Lk0gzYXw7VEdoDGuF/nCC4=; b=sQAzIVrEHO46DN32vk27eQQokSP9PUv3Mijrk+6fTtJ0et9ug+N06BhchcYEgMWaCQ SNDXrvwl3JWtQeCyBX7QzF8fVdOhlnx07TKc+MGtWKty4Rw5XQkERzm0DIHpUVkUFHLk cWii344W+0XQ5aAUfOGwI29iAaTSFy9b73BmM4Q2OpuCl5VogzCqJyuWhimslhJL7f1G HzzsuG9fl/eGcR8wkvmyNk+O2vmkix2MkWB5a3k7At9jEU1s5f78tKzCGSwK3k9CHhHW WKZLFK+k6wRIKEcz9SKVF613cP0Z8LPR+bwwQoOIP5US0x1PmYd1odZtwvnuG0Xg7M6L mkrQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=WJCZu+82; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 6-20020a630f46000000b005135d3abc6asi11443879pgp.90.2023.04.16.23.40.27; Sun, 16 Apr 2023 23:40:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=WJCZu+82; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230143AbjDQG1I (ORCPT + 99 others); Mon, 17 Apr 2023 02:27:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229574AbjDQG1H (ORCPT ); Mon, 17 Apr 2023 02:27:07 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 325D7359C; Sun, 16 Apr 2023 23:27:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=MdcEqIopRGNeL8ynxUzh+Lk0gzYXw7VEdoDGuF/nCC4=; b=WJCZu+82Ms9YNKKRexfvrIz0CQ 5rd8KyfwBqTZIK8vlQEdi2tfQutHIcUeBeFnpFyde1kheiETzyWGdyodCxdK0LR2NGt//zf1MDoPo Dt6ikWhcz8fZ+uudi04lRvwud7EdV2kBCqqX6OGl5U7M5/INOXVeEbrqsRwlQdV5Cq5doaBQOBTCI U20l+C4YHkx6o0alQFNw9/jVnVwnAPV1YjhTI4GBACpg/zCTkzkzpoSPN9OPY+VFKGk1ik6fGBV2q vawsnlDV1Z32PMn36gCL0a+DYfg0jdLTfqbLo8mF1WIowd5EIM6XTr//qQ7dSF70eeuGlimIVBPLv IUvIi0Vw==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1poIKK-00F3GR-2y; Mon, 17 Apr 2023 06:27:00 +0000 Date: Sun, 16 Apr 2023 23:27:00 -0700 From: Christoph Hellwig To: Hannes Reinecke Cc: Christoph Hellwig , Pankaj Raghav , Matthew Wilcox , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, mcgrof@kernel.org Subject: Re: [PATCH] mm/filemap: allocate folios according to the blocksize Message-ID: References: <20230414134908.103932-1-hare@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 17, 2023 at 08:08:04AM +0200, Hannes Reinecke wrote: > On 4/17/23 06:36, Christoph Hellwig wrote: > > On Fri, Apr 14, 2023 at 03:49:08PM +0200, Hannes Reinecke wrote: > > > If the blocksize is larger than the pagesize allocate folios > > > with the correct order. > > > > And how is that supposed to actually happen? > > By using my patcheset to brd and set the logical blocksize to eg 16k. Then add it to your patchset instead of trying to add dead code to the kernel while also losing context.