Received: by 2002:a05:6358:53a8:b0:117:f937:c515 with SMTP id z40csp3609902rwe; Mon, 17 Apr 2023 00:16:34 -0700 (PDT) X-Google-Smtp-Source: AKy350aDFW7hxdwnn4YGAoGOTB4ZmXmQ8FMyf9eH+S7F6Fs6vFUVZ/W3N9q5yGsti18yWlc2Whb0 X-Received: by 2002:a05:6a00:984:b0:63b:84a4:7a1 with SMTP id u4-20020a056a00098400b0063b84a407a1mr6582821pfg.7.1681715794510; Mon, 17 Apr 2023 00:16:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681715794; cv=none; d=google.com; s=arc-20160816; b=IKnRMRepVx4OIW83fp3fOrFVeoQFYHIF8nSzCxbNYO+fwV1kpw76wil+L5DWhpBqIn JbvpUdIyqXAv7SweFyQ5m6bDHkD4LIL6FwCbOj12zuaABGK9MSrYsvzc/5VYqbnhB7J/ w5iUJYaqi/ihX5yXKEUuzkvWRA445kppvfRHe9KzQleMXs/JCvX9VCgHeeTDFVwkJyi0 yMzOK1fQlYmAEWUOvl8gd8BRKF7PxOjIPMzegTV0VLZq2HA3/b4pjlBgAAG5gSlS+mT8 M6VWL7mSTD90evQzfOjnko9jaZzPqg9LAy1+GfoY3W8nDtiyiNeXUwwIuyFVgRYoaiQO 763Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=3DxIGeDChpW+dCspX207xU3KDB22/OENqLPHBuTpQk8=; b=OoqYYgMf8qzyX373KLGbsUHcOxKG9fB/pCHcKtvoGnVkLDAk9VTKbmDbz4k9iSYQ7Y 0dxssCiv38X3QFUIRhT30nTKJjQx6AlXZmukmtRuPdkrPjSTDwCxHxHq/PGV2Cok2HGq KWo3PRWuwAGDd2DTEP5jaSvm7xKGjqG8xCLRUppx62Ft9GLhFziCDJLbQDiodLB8jIfK Ulrpm6s8vSPNxKVXW3d5j5BFnw7FrEE9mFigDGB/jnna3HK0Q6v3jQ5NQeEUnOBt6FfJ +0ZYqDxLeYF6pXTM8h+CHCTvx7kTLOnx3ndj+aPsGahUgVpFRF1PSJN9c6XmHNTwteh6 hnEA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=A8MSv8IV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m17-20020a656a11000000b0050f74bf6b3asi12859524pgu.700.2023.04.17.00.16.21; Mon, 17 Apr 2023 00:16:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=A8MSv8IV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230036AbjDQHMr (ORCPT + 99 others); Mon, 17 Apr 2023 03:12:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229754AbjDQHMk (ORCPT ); Mon, 17 Apr 2023 03:12:40 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9278E40C7 for ; Mon, 17 Apr 2023 00:11:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681715508; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3DxIGeDChpW+dCspX207xU3KDB22/OENqLPHBuTpQk8=; b=A8MSv8IVdK0x2Sj+8hjcVYlPWQiKlP03/Xj9iH9dGFbevjrambVsOz1DQiinvcbCevImAK rhrm2CVlmN3RQYHggb8ZHPrWZos1BXeR9GbYhVcmAg815u0qG7jlbAkWzp/9PE86Nl4zZb alaP0vkeZ//UlCz2BYgZNtbTo/oTnxw= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-668-ItRi8JVANii7U6tYzBkMlA-1; Mon, 17 Apr 2023 03:11:46 -0400 X-MC-Unique: ItRi8JVANii7U6tYzBkMlA-1 Received: by mail-qt1-f200.google.com with SMTP id o4-20020ac87c44000000b003e38726ec8bso17241924qtv.23 for ; Mon, 17 Apr 2023 00:11:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681715506; x=1684307506; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3DxIGeDChpW+dCspX207xU3KDB22/OENqLPHBuTpQk8=; b=KuBdP64/ita9+u+LIcajBv29QdGXei7TO/QIikXejIFBP7M9QCNNGPbIyPPXkQowT4 D4dunqU8IAJGgi115RFWcIJeK0Orb0IwzPMqWm4Rp+X7Xw8TWthzVzy+CZ0SbeGteWI7 yZoFtoQWJJ52tltGkwjIYZunGGSbScGa5+G5pHc8sg8DF08OTTMTAD52FH791v0j5Ruo zdUHA+LxAu35tjCFaX/joFdHKYO9pVopabzz+lQfPMHjdmZGHPzI6fhsX+jhSf2GRiVv 4XDTm5/zICy2pHbTArDJ9mSqmEnjtNzYFnWk7nstCE+qfLJ+O8okNjSLWyP2pX75ZDmI yjdA== X-Gm-Message-State: AAQBX9eUzH951v6AJofzJpC424qQjr3UR0js7OgURge40BF4gYoU5k9j knm4QaRpKkJu7K2+qk/pCw5WugZPvsr1EJlGInsg3Be+/JaKv9i3m70gg5euLE+J9fKzZPFLwQc JLCKZ4MsatqQLTQVA33A3cGSrMSXHCbUN/Ds= X-Received: by 2002:a05:622a:15c8:b0:3e6:7634:3d0a with SMTP id d8-20020a05622a15c800b003e676343d0amr20401074qty.1.1681715505870; Mon, 17 Apr 2023 00:11:45 -0700 (PDT) X-Received: by 2002:a05:622a:15c8:b0:3e6:7634:3d0a with SMTP id d8-20020a05622a15c800b003e676343d0amr20401058qty.1.1681715505638; Mon, 17 Apr 2023 00:11:45 -0700 (PDT) Received: from redhat.com ([185.199.103.251]) by smtp.gmail.com with ESMTPSA id z1-20020ac81001000000b003b9b8ec742csm3089121qti.14.2023.04.17.00.11.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Apr 2023 00:11:45 -0700 (PDT) Date: Mon, 17 Apr 2023 03:11:38 -0400 From: "Michael S. Tsirkin" To: Alvaro Karsz Cc: Xuan Zhuo , "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" , "virtualization@lists.linux-foundation.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Jason Wang Subject: Re: [PATCH net] virtio-net: reject small vring sizes Message-ID: <20230417031052-mutt-send-email-mst@kernel.org> References: <20230416074607.292616-1-alvaro.karsz@solid-run.com> <20230416164453-mutt-send-email-mst@kernel.org> <20230417021725-mutt-send-email-mst@kernel.org> <1681713856.1928573-2-xuanzhuo@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 17, 2023 at 07:07:59AM +0000, Alvaro Karsz wrote: > > Why tx timeout without frags? > > Please see my response to Michael. > > > > * Guest GSO/big MTU (without VIRTIO_NET_F_MRG_RXBUF?), we can't chain page size buffers anymore. > > > > > > Or, we disable the GUEST_GSO, HOST_GSO...... > > > And disable VIRTIO_NET_F_MTU, quoting the spec: > "A driver SHOULD negotiate VIRTIO_NET_F_MTU if the device offers it." If you don't the nic can still get jumbo packets it will just drop them ... > We can find a way around using buffers bigger than a page size like Michael implied.