Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d3db48f8-779c-f990-a5e3-c720b8bcabdb@suse.cz>
Date:   Mon, 17 Apr 2023 09:27:57 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH] lib/show_mem.c: Use for_each_populated_zone() simplify
 code
Content-Language: en-US
To:     Yajun Deng <yajun.deng@linux.dev>, hannes@cmpxchg.org,
        mhocko@suse.com, akpm@linux-foundation.org
Cc:     linux-kernel@vger.kernel.org
References: <20230417035226.4013584-1-yajun.deng@linux.dev>
From:   Vlastimil Babka <vbabka@suse.cz>
In-Reply-To: <20230417035226.4013584-1-yajun.deng@linux.dev>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/17/23 05:52, Yajun Deng wrote:
> The __show_mem() needs to iterate over all zones that have memory, we can
> simplify the code by using for_each_populated_zone().
> 
> Signed-off-by: Yajun Deng <yajun.deng@linux.dev>

Acked-by: Vlastimil Babka <vbabka@suse.cz>

> ---
>  lib/show_mem.c | 19 ++++++-------------
>  1 file changed, 6 insertions(+), 13 deletions(-)
> 
> diff --git a/lib/show_mem.c b/lib/show_mem.c
> index 0d7585cde2a6..1485c87be935 100644
> --- a/lib/show_mem.c
> +++ b/lib/show_mem.c
> @@ -10,26 +10,19 @@
>  
>  void __show_mem(unsigned int filter, nodemask_t *nodemask, int max_zone_idx)
>  {
> -	pg_data_t *pgdat;
>  	unsigned long total = 0, reserved = 0, highmem = 0;
> +	struct zone *zone;
>  
>  	printk("Mem-Info:\n");
>  	__show_free_areas(filter, nodemask, max_zone_idx);
>  
> -	for_each_online_pgdat(pgdat) {
> -		int zoneid;
> +	for_each_populated_zone(zone) {
>  
> -		for (zoneid = 0; zoneid < MAX_NR_ZONES; zoneid++) {
> -			struct zone *zone = &pgdat->node_zones[zoneid];
> -			if (!populated_zone(zone))
> -				continue;
> +		total += zone->present_pages;
> +		reserved += zone->present_pages - zone_managed_pages(zone);
>  
> -			total += zone->present_pages;
> -			reserved += zone->present_pages - zone_managed_pages(zone);
> -
> -			if (is_highmem_idx(zoneid))
> -				highmem += zone->present_pages;
> -		}
> +		if (is_highmem(zone))
> +			highmem += zone->present_pages;
>  	}
>  
>  	printk("%lu pages RAM\n", total);