Received: by 2002:a05:6358:53a8:b0:117:f937:c515 with SMTP id z40csp3649539rwe; Mon, 17 Apr 2023 01:04:50 -0700 (PDT) X-Google-Smtp-Source: AKy350anV5hXZROx92Nd/NUnfKCim/oVPrFJ8vOhj9yKMeNl6n8S+XV3o98KqGnQP8e2k3vrE176 X-Received: by 2002:a05:6a20:a11b:b0:f0:edb:f612 with SMTP id q27-20020a056a20a11b00b000f00edbf612mr1505682pzk.14.1681718690131; Mon, 17 Apr 2023 01:04:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681718690; cv=none; d=google.com; s=arc-20160816; b=FklzGSRtBvtJuHNpQRXgucj+DMqZ8gDPyvVyTeq6S42Y2rWNNWv9oJv1W4satx6TXU TNOnbqvPIYNengrurue61d6aKJKoQYxBjSfqXX41LlrdnfnBaYiCHLaRNSfVpXnl+NXj dy1ISfwfaQ5de3Zp5qAR8xf+kRzbLH3flN8mlz9uv5mHHYRmND4i4THQwZUBilwdkdxz kixj1bX20SAFfmKgQb9dulwpWN6tR5xeWXuwgy5rsoumB1eWtiGC9InxPo+RfADuFvNq 6axC63eTahzWeEsHnE40DMFvEtsPMiSg7rMSUAY21XH3ef8/OMOu8O9lKdF9v7LaI3sV DjnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=mxAVc0ncUnjPKeybMVjKd5qlxZDMp8oAMzg8SofTCCg=; b=NJvirmRfTb6XM5l5Ft7nS/MBA1xh2h149YX9RijIusVMAxlUBodDMiBNvhpTFdeEjJ qp9vOp6noFQEnuaBjoWK7XEuxoultChvATH3FxJnVUJQ6Y6i/ww5cGe/Hx/zdBwfJDJ2 DV6UK7mo/AzhBAs5Dui9WgHH3rPXRPTD7ssFiFf1nqcbHH69nE0DuFQoKT4Di3fp9ewX 5VL+aqQmnfWAmBm12+WvH2TmKfos4AT3ipkC5tb3eN1lAHW7nj8rr+MX7ix87JCWNdbN c0PglXP06ddKRO7t4oP7fBTBL9WEvoa85YLJ2cugHK7ut/hJ5NpAFzLdd6BDflqS4J6B RaiA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b="CAKf/vDt"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x6-20020a634846000000b004fbe5ede659si10763464pgk.317.2023.04.17.01.04.38; Mon, 17 Apr 2023 01:04:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b="CAKf/vDt"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230343AbjDQIEY (ORCPT + 99 others); Mon, 17 Apr 2023 04:04:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230430AbjDQIEN (ORCPT ); Mon, 17 Apr 2023 04:04:13 -0400 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9831F196 for ; Mon, 17 Apr 2023 01:04:10 -0700 (PDT) Received: by mail-wm1-x32e.google.com with SMTP id gw13so13304256wmb.3 for ; Mon, 17 Apr 2023 01:04:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681718649; x=1684310649; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=mxAVc0ncUnjPKeybMVjKd5qlxZDMp8oAMzg8SofTCCg=; b=CAKf/vDt8JEBGp0mnnx5TlC2WmrwGF+A9JBXRln52KHrtc9rD+bXz46fUMASfxJnTt rkz555Z+QrhLasN8SSjr9Ae5e7g99errmpTjhcYSInlAWWoGVnAr9x3d9HAXC5I17+Ji iixNE8eqUHvKXVDOknf/NJBq8SHchC6FVsoVcjcyxNZE140E1OpQ0TfTEkuq/H6zXudw jGpxBG6f9Z+DU7i/VQEh0XBVW5xdaCTmnQlu1hp8AgwPd1ABZtTubLZ130oy7TEQ968X 5gMxT4hrbGMFvcB8D4yVw7/afVm0JrthXGU9FuiIOU653DoN/jKp7bENCPw9SVinghb8 HHqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681718649; x=1684310649; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mxAVc0ncUnjPKeybMVjKd5qlxZDMp8oAMzg8SofTCCg=; b=dR1fxE/5DOx9kO2EZy9GTJ3l3VXnzEKO4whzHT4YJloock+OS1xsNDNHMIHfUACW4A p+nGUS+g5OLsW/um3wviNRPZoa7RyYEvMn56jKpKuI173cciFhJxfZ0JFv8SY0uudELn q/AKxLdiXZSQlSt8qwjgMNjq/ErHtcXj5CHF48JrzVkFWHntTOEqXHWtA8F3tkZszB7x uMTz4DNbKV2c5jTi2yF/HOUWHdS489ZfBgCFFxKQsCeOsRQtWR6fPTGX2fZsvVUSxpSW wnsJSC3U2uJe+HPx3CCdq0e4vxwua1ru1OSz4sAAi/cl93jfe1Q5W/NgM4mAlGQsw/em kS9A== X-Gm-Message-State: AAQBX9e6eObz0BZsFurLImduSGFOwwmfsIN5IpY//aoP5ySC5vh3COjn Xp99rXuoXMbby/atEKtsXWE= X-Received: by 2002:a1c:7c15:0:b0:3f0:b095:15d9 with SMTP id x21-20020a1c7c15000000b003f0b09515d9mr7262274wmc.40.1681718648924; Mon, 17 Apr 2023 01:04:08 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id m9-20020a7bca49000000b003f172db455dsm3366558wml.32.2023.04.17.01.04.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Apr 2023 01:04:08 -0700 (PDT) Date: Mon, 17 Apr 2023 11:04:04 +0300 From: Dan Carpenter To: Luke Koch Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: wlan-ng: replace rate macros Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 15, 2023 at 04:10:44PM +0200, Luke Koch wrote: > + for (int i = 0; i < 8; i++) { > + if (count > i && > + DOT11_RATE5_ISBASIC_GET(item->supprates[i])) { > + req->basicrate[i] .data = item->supprates[i]; ^ Could you remove these spaces before the .data and .status? Otherwise it looks good to me. Reviewed-by: Dan Carpenter regards, dan carpenter