Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 17 Apr 2023 10:25:41 +0200
From:   Luke Koch <lu.ale.koch@gmail.com>
To:     Dan Carpenter <error27@gmail.com>
Cc:     gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: wlan-ng: replace rate macros
Message-ID: <ZD0ChREQnV8tKwS1@kernelhacking.kernelhacking.example.com>
References: <ZDqwZKZHyZZX4b2J@kernelhacking.kernelhacking.example.com>
 <f44f44e4-25c0-4489-96e9-8ca63fa294d7@kili.mountain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f44f44e4-25c0-4489-96e9-8ca63fa294d7@kili.mountain>
Precedence: bulk

On Mon, Apr 17, 2023 at 11:04:04AM +0300, Dan Carpenter wrote:
> On Sat, Apr 15, 2023 at 04:10:44PM +0200, Luke Koch wrote:
> > +	for (int i = 0; i < 8; i++) {
> > +		if (count > i &&
> > +		    DOT11_RATE5_ISBASIC_GET(item->supprates[i])) {
> > +			req->basicrate[i] .data = item->supprates[i];
>                                          ^
> Could you remove these spaces before the .data and .status?  Otherwise
> it looks good to me.

Sure, the spaces must have been leftovers from the token pasting and I
unfortunately overlooked them. Thanks for reviewing!

Best regards,
Luke Koch