Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1632bd15-c9b6-4bb8-13b2-d0c4b068315c@linaro.org>
Date:   Mon, 17 Apr 2023 10:35:15 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH v3 03/18] dt-bindings: interrupt-controller: qcom-pdc: add
 compatible for sa8775p
Content-Language: en-US
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To:     Bartosz Golaszewski <brgl@bgdev.pl>
Cc:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
        Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Marc Zyngier <maz@kernel.org>
References: <20230327125316.210812-1-brgl@bgdev.pl>
 <20230327125316.210812-4-brgl@bgdev.pl>
 <CAMRc=Mfe6gCM=Mz6Can6xsSsrjX-9T_aR2Yev+b57koky_az-A@mail.gmail.com>
 <CAMRc=Mfw+4Co8JPz51_E+DSawijO8EB6rMmFXEmM0e5F3Fg_8A@mail.gmail.com>
 <3877cb9e-9647-0acf-f705-d34fe2c731ff@linaro.org>
 <CAMRc=MeT4VLiLu5DJSXHqDdZv2gEoC-B7aPvoXVpc3SokQcrFg@mail.gmail.com>
 <b46028dc-b539-384c-78aa-2f5e6f6516f2@linaro.org>
In-Reply-To: <b46028dc-b539-384c-78aa-2f5e6f6516f2@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 17/04/2023 09:55, Krzysztof Kozlowski wrote:
> On 17/04/2023 09:27, Bartosz Golaszewski wrote:
>> On Sun, Apr 16, 2023 at 5:04 PM Krzysztof Kozlowski
>> <krzysztof.kozlowski@linaro.org> wrote:
>>>
>>> On 14/04/2023 11:33, Bartosz Golaszewski wrote:
>>>> On Thu, Apr 6, 2023 at 4:10 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>>>>>
>>>>> On Mon, Mar 27, 2023 at 2:53 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>>>>>>
>>>>>> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>>>>>>
>>>>>> Add a compatible for the Power Domain Controller on SA8775p platforms.
>>>>>> Increase the number of PDC pin mappings.
>>>>>>
>>>>>> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>>>>>> Cc: Thomas Gleixner <tglx@linutronix.de>
>>>>>> Cc: Marc Zyngier <maz@kernel.org>
>>>>>> ---
>>>>>>  .../devicetree/bindings/interrupt-controller/qcom,pdc.yaml     | 3 ++-
>>>>>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>>>>>
>>>>>> diff --git a/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml b/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml
>>>>>> index 94791e261c42..641ff32e4a6c 100644
>>>>>> --- a/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml
>>>>>> +++ b/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml
>>>>>> @@ -26,6 +26,7 @@ properties:
>>>>>>    compatible:
>>>>>>      items:
>>>>>>        - enum:
>>>>>> +          - qcom,sa8775p-pdc
>>>>>>            - qcom,sc7180-pdc
>>>>>>            - qcom,sc7280-pdc
>>>>>>            - qcom,sc8280xp-pdc
>>>>>> @@ -53,7 +54,7 @@ properties:
>>>>>>    qcom,pdc-ranges:
>>>>>>      $ref: /schemas/types.yaml#/definitions/uint32-matrix
>>>>>>      minItems: 1
>>>>>> -    maxItems: 32 # no hard limit
>>>>>> +    maxItems: 38 # no hard limit
>>>
>>> I don't think the limit is correct. I still see warnings with this
>>> patch. We already have 57 elements, so limit should be I guess 128 or
>>> something.
>>>
>>
>> You mean for other platforms? This limit applies to sa8775p as the
> 
> I see errors on sa8775p.

OK, so as you pointed out it's about other platform - sa8540p-ride.
Anyway you update now this line to bump the limit, so bump it to
something high instead of changing it in two patches.

Best regards,
Krzysztof