Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 17 Apr 2023 12:19:57 +0300
From:   Matti Vaittinen <mazziesaccount@gmail.com>
To:     Matti Vaittinen <mazziesaccount@gmail.com>,
        Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Cc:     Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Matti Vaittinen <mazziesaccount@gmail.com>,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/2] iio: bu27034: Fix integration time
Message-ID: <a05647669af22ba919c7c87dccb43975e3235a87.1681722914.git.mazziesaccount@gmail.com>
References: <cover.1681722914.git.mazziesaccount@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="K2MOcnigrCNm05N+"
Content-Disposition: inline
In-Reply-To: <cover.1681722914.git.mazziesaccount@gmail.com>
Precedence: bulk


--K2MOcnigrCNm05N+
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

The bu27034 uses micro seconds for integration time configuration. This
is incorrect as the ABI mandates use of seconds.

Change BU27034 driver to use seconds for integration time.

Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>
---
 drivers/iio/light/rohm-bu27034.c | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/drivers/iio/light/rohm-bu27034.c b/drivers/iio/light/rohm-bu27=
034.c
index e486dcf35eba..25c9b79574a5 100644
--- a/drivers/iio/light/rohm-bu27034.c
+++ b/drivers/iio/light/rohm-bu27034.c
@@ -1167,11 +1167,12 @@ static int bu27034_read_raw(struct iio_dev *idev,
=20
 	switch (mask) {
 	case IIO_CHAN_INFO_INT_TIME:
-		*val =3D bu27034_get_int_time(data);
-		if (*val < 0)
-			return *val;
+		*val =3D 0;
+		*val2 =3D bu27034_get_int_time(data);
+		if (*val2 < 0)
+			return *val2;
=20
-		return IIO_VAL_INT;
+		return IIO_VAL_INT_PLUS_MICRO;
=20
 	case IIO_CHAN_INFO_SCALE:
 		return bu27034_get_scale(data, chan->channel, val, val2);
@@ -1229,7 +1230,10 @@ static int bu27034_write_raw(struct iio_dev *idev,
 		ret =3D bu27034_set_scale(data, chan->channel, val, val2);
 		break;
 	case IIO_CHAN_INFO_INT_TIME:
-		ret =3D bu27034_try_set_int_time(data, val);
+		if (!val)
+			ret =3D bu27034_try_set_int_time(data, val2);
+		else
+			ret =3D -EINVAL;
 		break;
 	default:
 		ret =3D -EINVAL;
--=20
2.39.2


--=20
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND

~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
Simon says - in Latin please.
~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
Thanks to Simon Glass for the translation =3D]=20

--K2MOcnigrCNm05N+
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEIx+f8wZb28fLKEhTeFA3/03aocUFAmQ9Dz0ACgkQeFA3/03a
ocVxGwgAyjdJtfrLVu5HaZ1xGwqIJwcvqR9JJd3st/nH2bmuu846tw5Uf/9HcgKI
IW8DflyVJE7o58uj/UR6KLCJSTxOJmiSgo/a+EEnO5fBigKubMQbareHc6Z6f9x7
8xhmOboIjE7U9DCX3iPcInbA8eaygh4q6G34mASp26cOvfokv0CsIaXr7KvMgat3
yVSf+ejiE6fEN+xthkjvQM5NfZ7TRn9RSNnSZi9+Yb0Cx+EGXf70YNKpYQi0Vp4l
qoRArbadmy18v2M/3zQ/VNG/Kf8Q9B5b5tOizUklzCeyQImkdC3UfiC39WAHoynM
vSrpV3dc6w4PviM2ml1U7vCF4Kc+Kw==
=FSyV
-----END PGP SIGNATURE-----

--K2MOcnigrCNm05N+--