Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH v2 0/4] Add uprobes support for LoongArch
To:     Hengqi Chen <chenhengqi@outlook.com>,
        Huacai Chen <chenhuacai@kernel.org>,
        WANG Xuerui <kernel@xen0n.name>
References: <1681464781-4428-1-git-send-email-yangtiezhu@loongson.cn>
 <SY4P282MB351877A70A0333C790FE85A5C09C9@SY4P282MB3518.AUSP282.PROD.OUTLOOK.COM>
Cc:     loongarch@lists.linux.dev, linux-kernel@vger.kernel.org,
        loongson-kernel@lists.loongnix.cn
From:   Tiezhu Yang <yangtiezhu@loongson.cn>
Message-ID: <8478fc34-01e9-2bdd-254b-982533ef3856@loongson.cn>
Date:   Mon, 17 Apr 2023 17:22:25 +0800
User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <SY4P282MB351877A70A0333C790FE85A5C09C9@SY4P282MB3518.AUSP282.PROD.OUTLOOK.COM>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 04/17/2023 11:17 AM, Hengqi Chen wrote:
> Hi Tiezhu:
>

...

>
> When I try to uprobe the pthread_spin_lock calls, the application core dumped.
> On X86, this will return -EINVAL instead of crashing the userspace application.
> Probably, we should add more opcode to insns_not_supported().
>

Yes, the atomic memory access instructions such as amswap_db.w
should not be supported, like llsc instructions, let me add them
in insns_not_supported(), thank you.

Thanks,
Tiezhu