Received: by 2002:a05:6358:53a8:b0:117:f937:c515 with SMTP id z40csp3720841rwe; Mon, 17 Apr 2023 02:28:37 -0700 (PDT) X-Google-Smtp-Source: AKy350ZVyh56pijJNpn7OuPKHOrZyRGjTYT0Y7ZVbuN+CrgP9BEOLrlAX+0vZzAzXfdKSfn4XiGN X-Received: by 2002:a05:6a20:12cc:b0:ef:95de:b877 with SMTP id v12-20020a056a2012cc00b000ef95deb877mr4428425pzg.10.1681723717032; Mon, 17 Apr 2023 02:28:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681723717; cv=none; d=google.com; s=arc-20160816; b=BcWexBghZwLakziRmYQbzGogqI19aXbrN45SAlPbTJWkTwjgqo4uzx1hYpc1ST+hvq WIT35o2Ja8yLQYHWCvzoiaENtEknlo/k7onazh7d99QoP32Z1ttnYrX3BTo2oKeXAHjs Rn4jxCaJQjEV5MAeaeiHczD4y1SK3+dljDxztI64htyHGQ3RZM84CNPVc87XKY/+d0Dn oCsW6k0cKccFGzqOiFc4RWeUYng1z3+M0T3MsQKFyRZqQyoBuq/ZOtN9WhVt1aWVohj0 MaS0xsF4wlz6bQBZUY5Jw4pqZEqK4ppHJhsikafLTvH6AfDCRC+Gop18ltY5v9WYIU83 z/Cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=n+j5o6fQJQAp9pw9pBLSNzanRfTudfjw+am50p7MN68=; b=tM9STylAG9XCRLyXv7UFIvVbVGDloS59/HxDQlUVLUw8iGSRZtKk7FAY8eMAacHy1e uB8J2KY8XwaL5siF35TMsDvH1ALebbu1NogYVkiUkrN6WOZIBjt6hM9a+6B+uikxXjiE LL3+KI6QpC28ob4EH8lkBDbjj1kmSvWTXMPjdsdufXZ0Fun0IELASREHJU6MwJXtsUpm wH+ozvgJAccXAdbe73xRULi5PL1I1jAYhLZt6O2X7aWWxOmXGC0TM5YJonLR9giwpVpJ Urs0VYrl/GQwkn3s2HvPwgntXzItpx6riIC17wmk55tiGLEGmuptp27YVtQEbvZEaXIt mNnQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=A8x572u5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y10-20020aa79aea000000b0063b8a054e06si3595838pfp.259.2023.04.17.02.28.22; Mon, 17 Apr 2023 02:28:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=A8x572u5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230363AbjDQJ1V (ORCPT + 99 others); Mon, 17 Apr 2023 05:27:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230317AbjDQJ1H (ORCPT ); Mon, 17 Apr 2023 05:27:07 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0715C3A94; Mon, 17 Apr 2023 02:27:06 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id dm2so62464503ejc.8; Mon, 17 Apr 2023 02:27:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681723624; x=1684315624; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=n+j5o6fQJQAp9pw9pBLSNzanRfTudfjw+am50p7MN68=; b=A8x572u5E+uNqeMjdLTyUOpLHMn5BUr/ENipcSEmI93Ofwh9gCCbXoHv1BAWhUK4Fj Ay9mQaDk18LX7JPBlKEFMx+5tJipdDJ82ryrj0BycUdc8QW2aSAQZLRbb9sXCU6W2MFJ H7CbTwhlBniI7h1kEwjFlvyZR7aYLQReiEVk+w22YJvFP/z2OGELZuySeG6G9NC2ORv5 ewBMVRuske96Pt2q3KewsOHxn8BCsJw4j0N+9ySrLNYkbK21WE7QjaUUvjB+FNIYVK56 cAJzmwBuKuLs0fyZB/5l+6hMElblkxn5SSAqpNyhA4/TzzLA8h+K+Rtfxa9PIGIEimUI M6gA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681723624; x=1684315624; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=n+j5o6fQJQAp9pw9pBLSNzanRfTudfjw+am50p7MN68=; b=GiRo7wCljKYLRPRy8HipMiAcqPVDbzDGB0siRFHl+mf1h3DpEUxtFhllLt41nLZ2Ao E1N7Y/LadV6f4yqphJE2zt84pkIxkzkIRdmG/DksP//mv3npCyGacFsI+h2JvY65l9TW +Kes+r4CObShKB3xqENMbaIyEFFxFbo1h57tf0eYd5T6L0dUIe1hZJFKoMGRU/PZGwp4 IEJ+R7RgPBQe/L/OgGrJ8SMlDWDD9nvTUfLv+sRu1pj10kJCFYNuZxFujQYZlJ2UF+7y 5cPvY7f7RW+fsGo2YuBUp4Gj44tJ9y74rI895lAtIvazfcng+YC+aXc9rRQtC9GjfmtP PBUA== X-Gm-Message-State: AAQBX9fTSl19Z+hzwYmJGF1wD1+flzDTzyjub73ll1tbfT2QPifeh6Za +zid8SfdZuOOBcA9GH/dhb0= X-Received: by 2002:a17:906:244d:b0:94e:626e:c108 with SMTP id a13-20020a170906244d00b0094e626ec108mr6990751ejb.50.1681723624285; Mon, 17 Apr 2023 02:27:04 -0700 (PDT) Received: from A13PC04R.einet.ad.eivd.ch ([193.134.219.72]) by smtp.googlemail.com with ESMTPSA id p20-20020a170906615400b0094aa087578csm6398596ejl.171.2023.04.17.02.27.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Apr 2023 02:27:04 -0700 (PDT) From: Rick Wertenbroek To: alberto.dassatti@heig-vd.ch Cc: xxm@rock-chips.com, Rick Wertenbroek , stable@vger.kernel.org, Damien Le Moal , Shawn Lin , Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Krzysztof Kozlowski , Heiko Stuebner , Caleb Connolly , Brian Norris , Johan Jonker , Corentin Labbe , Arnaud Ferraris , Judy Hsiao , Hugh Cole-Baker , linux-pci@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 03/11] PCI: rockchip: Assert PCI Configuration Enable bit after probe Date: Mon, 17 Apr 2023 11:26:21 +0200 Message-Id: <20230417092631.347976-4-rick.wertenbroek@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230417092631.347976-1-rick.wertenbroek@gmail.com> References: <20230417092631.347976-1-rick.wertenbroek@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Assert PCI Configuration Enable bit after probe. When this bit is left to 0 in the endpoint mode, the RK3399 PCIe endpoint core will generate configuration request retry status (CRS) messages back to the root complex. Assert this bit after probe to allow the RK3399 PCIe endpoint core to reply to configuration requests from the root complex. This is documented in section 17.5.8.1.2 of the RK3399 TRM. Fixes: cf590b078391 ("PCI: rockchip: Add EP driver for Rockchip PCIe controller") Cc: stable@vger.kernel.org Signed-off-by: Rick Wertenbroek Reviewed-by: Damien Le Moal Tested-by: Damien Le Moal --- drivers/pci/controller/pcie-rockchip-ep.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pci/controller/pcie-rockchip-ep.c b/drivers/pci/controller/pcie-rockchip-ep.c index 9b835377bd9e..4c84e403e155 100644 --- a/drivers/pci/controller/pcie-rockchip-ep.c +++ b/drivers/pci/controller/pcie-rockchip-ep.c @@ -623,6 +623,8 @@ static int rockchip_pcie_ep_probe(struct platform_device *pdev) ep->irq_pci_addr = ROCKCHIP_PCIE_EP_DUMMY_IRQ_ADDR; + rockchip_pcie_write(rockchip, PCIE_CLIENT_CONF_ENABLE, PCIE_CLIENT_CONFIG); + return 0; err_epc_mem_exit: pci_epc_mem_exit(epc); -- 2.25.1