Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0a9185f6-e369-c9ab-f855-54ac2741cc1c@redhat.com>
Date:   Mon, 17 Apr 2023 12:13:27 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH] platform/x86/intel/sdsi: Change mailbox timeout
Content-Language: en-US, nl
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        "David E. Box" <david.e.box@linux.intel.com>
Cc:     markgross@kernel.org, platform-driver-x86@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>
References: <20230413013230.1521584-1-david.e.box@linux.intel.com>
 <66b5cf7-391-8d63-b7da-267fe8a639bd@linux.intel.com>
From:   Hans de Goede <hdegoede@redhat.com>
In-Reply-To: <66b5cf7-391-8d63-b7da-267fe8a639bd@linux.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi,

On 4/13/23 12:17, Ilpo Järvinen wrote:
> On Wed, 12 Apr 2023, David E. Box wrote:
> 
>> On some platforms, it may take up to 400ms for the ready bit to be set in a
>> successful mailbox transaction. Set the timeout to 500ms to cover the worst
>> case.
>>
>> Signed-off-by: David E. Box <david.e.box@linux.intel.com>
>> ---
>>  drivers/platform/x86/intel/sdsi.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/platform/x86/intel/sdsi.c b/drivers/platform/x86/intel/sdsi.c
>> index 9e0ea2cdd704..556e7c6dbb05 100644
>> --- a/drivers/platform/x86/intel/sdsi.c
>> +++ b/drivers/platform/x86/intel/sdsi.c
>> @@ -49,7 +49,7 @@
>>  #define SDSI_MBOX_CMD_SUCCESS		0x40
>>  #define SDSI_MBOX_CMD_TIMEOUT		0x80
>>  
>> -#define MBOX_TIMEOUT_US			2000
>> +#define MBOX_TIMEOUT_US			500000
>>  #define MBOX_TIMEOUT_ACQUIRE_US		1000
>>  #define MBOX_POLLING_PERIOD_US		100
>>  #define MBOX_ACQUIRE_NUM_RETRIES	5
> 
> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

Thank you both for the patch + review, I've applied this patch
to my review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans