Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 17 Apr 2023 18:18:55 +0800
From:   Aaron Lu <aaron.lu@intel.com>
To:     Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
CC:     Peter Zijlstra <peterz@infradead.org>,
        <linux-kernel@vger.kernel.org>, Olivier Dion <odion@efficios.com>,
        <michael.christie@oracle.com>
Subject: Re: [RFC PATCH v7] sched: Fix performance regression introduced by
 mm_cid
Message-ID: <20230417101855.GA485797@ziqianlu-desk2>
References: <20230416223217.191261-1-mathieu.desnoyers@efficios.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230416223217.191261-1-mathieu.desnoyers@efficios.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?2qVkZB2mr8ghV0Ar+Y7zgwRXd9H0rImd3bxlrDQdXVO2VOJ83ZimYQRXc0bT?=
 =?us-ascii?Q?NmFgreoP2f8CkiEkfS6cwB0+IBFr8MbkbPHk1P6vPULwbNo1wm/yYLffVUGZ?=
 =?us-ascii?Q?ZJUP80IJKhMkGD0IKCU7COeN77yVSSGEPG5YjHq1fdPP/xEJ+yLw1Mf5YnTb?=
 =?us-ascii?Q?8v5oEDVTpWK1IRgUyBM+R4qFOX4xgBdWlFRlKJG/7iZthWmmnx1FgbORhxVE?=
 =?us-ascii?Q?6jeTmaqPGZQMP558aU5KA1p6gFgoxoQt2/10tnxKdW3u3//0UWRZwFROuJTH?=
 =?us-ascii?Q?Cw3GqqB1wHMrtvuwzeqyw9vBl2Rc+69VsXf6Uhx5Y1NKNka0zWSQtjCKi4qQ?=
 =?us-ascii?Q?ejm0/RlbT5bxP5gJIQRT/uomYOAq6HmzHfnFJ/vOrBbkKOsiLQKHZXlKSzj9?=
 =?us-ascii?Q?lAyQ6S2VGFv+i1mNjHbrf/iNZGHJplFmkJ73DBr2n62RYdT97cNdmDx/Coik?=
 =?us-ascii?Q?jl5/y93KHoQMeiQtGb4irPAZ3/aZXYMuaREaiDb4Xg7m7qe9FdZj/FvgpmiG?=
 =?us-ascii?Q?flpk+xfem7s2tSE5YgRBoklcgw54JvT4S9LLn/Vtjkwvbp1S11ZGgnmf8kn+?=
 =?us-ascii?Q?T/ugqoh6TB81EGp2RVmZhq3ivo4QAcxoOcOqXL93qvxd3LSpzUmVOnKkt8LR?=
 =?us-ascii?Q?N640ZS3FHCXpuM3X1RQRHRD8dTTQ64un+ekRI4uAHAw+m2967UZo7H2dRe0J?=
 =?us-ascii?Q?VDMXv/fUL2i+H8FiQRRhyGaLJcbX8xSMBCzkSMGMAjBLrrXI16HKGli9bwPD?=
 =?us-ascii?Q?y94H/+WY99eCWB9veuvMsYbxegLRWOUMhHM9qZeIm38mKAduSsD5paLPEDr3?=
 =?us-ascii?Q?7b4vnxk5L1Q3BF6gb5EmtYyp5NZMhYIgReUJKufTyo1x5tlQR6KL+6aoPXJc?=
 =?us-ascii?Q?k7VKSlDvMkfuEb1PNr0qN7M0e4rE91rSs9zNv2hLBvlGjRFKB80W254JSXd7?=
 =?us-ascii?Q?z4ripBvV/AiA1psJdvAN3/joRXwCo2cjXAL6g8UNrKmNFo4Kw0YiOHyJuF5q?=
 =?us-ascii?Q?k/2QeZo4MRx4DR03eXFb7yaMy/SnNIk90vquN0bIid9hJjJg3fUBNW0ryCpH?=
 =?us-ascii?Q?wV5XOypc+9l2q+gEPIU7JUyekOJaB3hWM8Ftc0YVB/FDnXO19VH2RCFu6RGC?=
 =?us-ascii?Q?WoTo86M5Xl+jI8CZLrx9OE2bbZXOivlmPKpPgDCInsktgU1H2UTxIUDZFRJf?=
 =?us-ascii?Q?7uJpjMaMSOh4u5qKlVdTEiDgqt7XUMuct6SfDBrPso06nAXoxamPFkpXPCvU?=
 =?us-ascii?Q?iJjz2hrb8eIXlpB0tRUhSZswvuUDcHL3PkXU1tzNKxDumpXmBM1MohZ/a8zT?=
 =?us-ascii?Q?rVDkdb4CDPTJIgwEkQC4/MYdnpDpFxwTWGgLqfiWHIt787eD761wuu+2tmEP?=
 =?us-ascii?Q?dCA0+iUpqHtoJsYxzwS/L5cIG7yOwXTTsbKuX7wrtd8FUYcvnxxvh94zZoBv?=
 =?us-ascii?Q?tmbSx1LDs9OhclCMNJpZvE+dsLZJ47jy09rk+GjZv8eKMXMuCWLn2q5IO0DO?=
 =?us-ascii?Q?bYMa+GOPb3teL9uCQryBUUE8TuTIGawNrTxG0TiiGbENgPrjpV7PeK2zqUcs?=
 =?us-ascii?Q?JiSc1siU4j8oY2o6ho95OJMyb1eaup9Z2CXEwlVR?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5bb9f8c1-a27e-4579-4114-08db3f2d2c3d
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3062.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2023 10:19:05.5002
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GaS7+6BVEECk+hybnIZqMUQGYvpg5dg5ShJGA3y1Uq7XYb+/W3XoaEnXFVcZgGyv5ElM6s65H/Ifqem3l2MIsQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6725
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Apr 16, 2023 at 06:32:17PM -0400, Mathieu Desnoyers wrote:
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 0d18c3969f90..9532cf1a2a44 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -2084,8 +2084,10 @@ static inline void dequeue_task(struct rq *rq, struct task_struct *p, int flags)
>  
>  void activate_task(struct rq *rq, struct task_struct *p, int flags)
>  {
> -	if (task_on_rq_migrating(p))
> +	if (task_on_rq_migrating(p)) {
>  		flags |= ENQUEUE_MIGRATED;
> +		sched_mm_cid_migrate_to(rq, p);


I noticed you did this in previous version too but forgot to ask:
is it your intention to only invoke sched_mm_cid_migrate_to() for queued
tasks, i.e. tasks that are being migrated due to load/idle balance etc,
but not those tasks that migrated on wakeup?

I saw you did the corresonding sched_mm_cid_migrate_from() in
set_task_cpu(), which on the other hand includes tasks that migrated due
to wakeup, so it kind of feel weird.

> +	}
>  
>  	enqueue_task(rq, p, flags);
>  
> @@ -3195,6 +3197,7 @@ void set_task_cpu(struct task_struct *p, unsigned int new_cpu)
>  			p->sched_class->migrate_task_rq(p, new_cpu);
>  		p->se.nr_migrations++;
>  		rseq_migrate(p);
> +		sched_mm_cid_migrate_from(p);
>  		perf_event_task_migrate(p);
>  	}

Thanks,
Aaron