Received: by 2002:a05:6358:53a8:b0:117:f937:c515 with SMTP id z40csp3828166rwe; Mon, 17 Apr 2023 04:17:59 -0700 (PDT) X-Google-Smtp-Source: AKy350br4sP7ffB+htK6zGMukeylJ/2v2hJ9rkD/n64VV6tSt31ZLEebh6zjqLCNDEJdtjB1v3uU X-Received: by 2002:a17:90a:5b12:b0:244:9385:807f with SMTP id o18-20020a17090a5b1200b002449385807fmr14268895pji.44.1681730279258; Mon, 17 Apr 2023 04:17:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681730279; cv=none; d=google.com; s=arc-20160816; b=kyP8Jk0xWNpDyOVNn/hWTngI2/NMSYH026ZX1v2VJ40XPqsUqSTviDZwJCrJaM1YUS wcKHp58VpQG6aplTQzcM5yGv5iur85wl3HkdiueMnlqToSFmZU8a8UWk1J8Bm+Ywg+eD FVPr6cZM6nYENMnDFHsE3uNXV/7TCTyHShbp5XncJ4fufpI911a9GyRWOQPkIlHdAOT5 AjNmZdUFVoPrVwETmqjrVVXYw4iH9WUXnVLFe5Ys5OGt5IovM+75pYT9tE0e4SeJ5of7 mpEgRviVHtkqCZPYWq0R6+e7qGu2emddbwfI/U4vFSnrsn/i8pj1x1USzW9OVKh+kguJ u+pw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=Cc/9pUOO/zETIb32WJW/RJXmVNctXN1CXTfJbEX+7mw=; b=GPE6hEYNQ9Qy0R68mFZo6xyaz9A8pPyxc6WqAM7MuSPmp+2hG2+Ya+8JpwBO4/XDQA rzgGNAriuL8+CFGfYAlAwQXpSsCSYgLwl6CT5waRCfgwj8WWySzBE9rLolKG6XO4Qd6J wfwgjiGPHdzq8ObIeQVIOb6bXsPYikLlYxEjsAD15FE5UpJd8/OmfegrpAwtdx77NHAc IJqElR9N4dOA9ugYQQI3hY71Pa8Tn6GAYyH+Yr6YEZFzkBPOY2F/SwPoX7UqJSaHi4fV 2GEWzRJY6HF7ZbW9iKVmRP8FBnRVK6w3NwKmAZROI5MdFcyVv6O8JKDEivctxPdpahwr kcWg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u190-20020a6385c7000000b0051b50d08d45si11634234pgd.309.2023.04.17.04.17.48; Mon, 17 Apr 2023 04:17:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230499AbjDQK4Q (ORCPT + 99 others); Mon, 17 Apr 2023 06:56:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230227AbjDQKzn (ORCPT ); Mon, 17 Apr 2023 06:55:43 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 196701737; Mon, 17 Apr 2023 03:54:41 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D84AC6223B; Mon, 17 Apr 2023 10:52:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 75C41C433EF; Mon, 17 Apr 2023 10:52:36 +0000 (UTC) Date: Mon, 17 Apr 2023 11:52:33 +0100 From: Catalin Marinas To: Lorenzo Stoakes Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Matthew Wilcox , David Hildenbrand , linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-security-module@vger.kernel.org, Will Deacon , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Sven Schnelle , Eric Biederman , Kees Cook , Alexander Viro , Christian Brauner , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Kentaro Takeda , Tetsuo Handa , Paul Moore , James Morris , "Serge E . Hallyn" , Paolo Bonzini Subject: Re: [PATCH v3 3/7] mm/gup: remove vmas parameter from get_user_pages_remote() Message-ID: References: <523f0764f4979276a6d4b89cbad9af9124e4bf0a.1681558407.git.lstoakes@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <523f0764f4979276a6d4b89cbad9af9124e4bf0a.1681558407.git.lstoakes@gmail.com> X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 15, 2023 at 01:09:24PM +0100, Lorenzo Stoakes wrote: > The only instances of get_user_pages_remote() invocations which used the > vmas parameter were for a single page which can instead simply look up the > VMA directly. In particular:- > > - __update_ref_ctr() looked up the VMA but did nothing with it so we simply > remove it. > > - __access_remote_vm() was already using vma_lookup() when the original > lookup failed so by doing the lookup directly this also de-duplicates the > code. > > This forms part of a broader set of patches intended to eliminate the vmas > parameter altogether. > > Signed-off-by: Lorenzo Stoakes > --- > arch/arm64/kernel/mte.c | 7 ++++--- For arm64: Reviewed-by: Catalin Marinas