Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230304034835.2082479-4-senozhatsky@chromium.org> <20230417050140.1653593-1-senozhatsky@chromium.org>
In-Reply-To: <20230417050140.1653593-1-senozhatsky@chromium.org>
From:   Yosry Ahmed <yosryahmed@google.com>
Date:   Mon, 17 Apr 2023 04:43:04 -0700
Message-ID: <CAJD7tkYX4JEFwk3yjmMLMCLVPF=8UfFbv1qaPAufcQ++z8XqDQ@mail.gmail.com>
Subject: Re: [PATCH] zsmalloc: reset compaction source zspage pointer after putback_zspage()
To:     Sergey Senozhatsky <senozhatsky@chromium.org>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Yu Zhao <yuzhao@google.com>, Minchan Kim <minchan@kernel.org>,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Sergey,

On Sun, Apr 16, 2023 at 10:01=E2=80=AFPM Sergey Senozhatsky
<senozhatsky@chromium.org> wrote:
>
> Fixup.

I think the original patch landed in mm-stable already, so we might
want a proper commit log and fixes tag.

I suspect we want:
Fixes: 5a845e9f2d66 ("zsmalloc: rework compaction algorithm")

>
> Reported-by: Yu Zhao <yuzhao@google.com>
> Signed-off-by: Sergey Senozhatsky <senozhatsky@chromium.org>

Otherwise, LGTM.

Reviewed-by: Yosry Ahmed <yosryahmed@google.com>

> ---
>  mm/zsmalloc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
> index aea50e2aa350..cc81dfba05a0 100644
> --- a/mm/zsmalloc.c
> +++ b/mm/zsmalloc.c
> @@ -2239,8 +2239,8 @@ static unsigned long __zs_compact(struct zs_pool *p=
ool,
>                 if (fg =3D=3D ZS_INUSE_RATIO_0) {
>                         free_zspage(pool, class, src_zspage);
>                         pages_freed +=3D class->pages_per_zspage;
> -                       src_zspage =3D NULL;
>                 }
> +               src_zspage =3D NULL;
>
>                 if (get_fullness_group(class, dst_zspage) =3D=3D ZS_INUSE=
_RATIO_100
>                     || spin_is_contended(&pool->lock)) {
> --
> 2.40.0.634.g4ca3ef3211-goog
>