Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230414120520.360291-1-joychakr@google.com> <20230414120520.360291-3-joychakr@google.com>
 <ZD0iycNg4i6sYO48@smile.fi.intel.com>
In-Reply-To: <ZD0iycNg4i6sYO48@smile.fi.intel.com>
From:   Joy Chakraborty <joychakr@google.com>
Date:   Mon, 17 Apr 2023 17:41:32 +0530
Message-ID: <CAOSNQF33jw8uKuxsjjGmmLG6vG9vbky6FCN6Ts5-KZ88YLxmQw@mail.gmail.com>
Subject: Re: [PATCH v6 2/5] spi: dw: Move "dw_spi_can_dma" function
To:     Andy Shevchenko <andriy.shevchenko@intel.com>
Cc:     Serge Semin <fancer.lancer@gmail.com>,
        Mark Brown <broonie@kernel.org>, linux-spi@vger.kernel.org,
        linux-kernel@vger.kernel.org, manugautam@google.com,
        rohitner@google.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Apr 17, 2023 at 4:13=E2=80=AFPM Andy Shevchenko
<andriy.shevchenko@intel.com> wrote:
>
> On Fri, Apr 14, 2023 at 12:05:17PM +0000, Joy Chakraborty wrote:
> > Move "dw_spi_can_dma" function implementation below
> > "dw_spi_dma_convert_width" function for handing compile dependency in
> > future patches.
>
> We refer to the functions like func().
>
> ...
>
> > +static bool dw_spi_can_dma(struct spi_controller *master,
> > +                        struct spi_device *spi, struct spi_transfer *x=
fer)
> > +{
> > +     struct dw_spi *dws =3D spi_controller_get_devdata(master);
> > +
> > +     return xfer->len > dws->fifo_len;
> > +}
>
> > +
> > +
>
> Single blank line is enough.

Sure,I will make these changes and send V7.
Will wait for some time to see if Serge(y) has any other comments on
the patch series.

>
> --
> With Best Regards,
> Andy Shevchenko
>
>