Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 17 Apr 2023 13:12:25 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Doug Anderson <dianders@chromium.org>
Cc:     Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com>,
        agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org,
        robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org,
        linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, quic_msavaliy@quicinc.com,
        mka@chromium.org, swboyd@chromium.org, quic_vtanuku@quicinc.com
Subject: Re: [PATCH v3 3/3] spi: spi-qcom-qspi: Add DMA mode support
Message-ID: <30a752c9-3ea0-43d3-959a-da2e8b526cb4@sirena.org.uk>
References: <1681481153-24036-1-git-send-email-quic_vnivarth@quicinc.com>
 <1681481153-24036-4-git-send-email-quic_vnivarth@quicinc.com>
 <CAD=FV=VKY-0vX271G+EQQ5kC3gTqpPPyTGE0xHWPBncVUhZufQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="QerR8LcbkWiaBCb1"
Content-Disposition: inline
In-Reply-To: <CAD=FV=VKY-0vX271G+EQQ5kC3gTqpPPyTGE0xHWPBncVUhZufQ@mail.gmail.com>
Precedence: bulk


--QerR8LcbkWiaBCb1
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Apr 14, 2023 at 03:05:58PM -0700, Doug Anderson wrote:

> Having alignment requirements like this doesn't seem like it should be
> that unusual, though, and that's why it feels like the logic belongs
> in the SPI core. In fact, it seems like this is _supposed_ to be
> handled in the SPI core, but it isn't? In "spi.h" I see
> "dma_alignment" that claims to be exactly what you need. As far as I
> can tell, though, the core doesn't use this? ...so I'm kinda confused.
> As far as I can tell this doesn't do anything and thus anyone setting
> it today is broken?

SPI consumers should only be providing dmaable buffers.

--QerR8LcbkWiaBCb1
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmQ9N6gACgkQJNaLcl1U
h9A0RAf/Q/Bi/4JeWGxUTZ0r2ETK1oo6ycZJpBYut1iRufKN7g8gHo0D+I7u4ShX
PbOSybrq4CnyaGqfmtBnuBBBS/4VX9Ryu8mj5XTkLKyUbamhzjUZj48SauEkufN8
bUkhQ5VZtCrIOd+aWVUIBX5L+VyAmjXddaHINuWUHXIYy5w5/Z/23ES7iUqsjUe+
LIDO3zSxDkssalpPAsbCjcoYDBs+oRmIUUNvbwS5FlaTsl3yIq9r75YXHd/lUHXf
EuW/RGag45g7zSGN02g15P0wvajWATasTYWuEnWxNMV76YOiRbmtZ8vedV1bsGPP
O4J9kUULTNCnTdo6M5NRqqWfIXdCvQ==
=/PHR
-----END PGP SIGNATURE-----

--QerR8LcbkWiaBCb1--