Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ccae3994-3b1b-4050-ea34-98f97cf886e0@wolfvision.net>
Date:   Mon, 17 Apr 2023 14:38:20 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [libcamera-devel] [PATCH RFC 1/4] media: v4l2-ctrls: add lens
 group status controls for zoom and focus
Content-Language: en-US
To:     Sakari Ailus <sakari.ailus@linux.intel.com>,
        Dave Stevenson <dave.stevenson@raspberrypi.com>
Cc:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        Michael Riesch via B4 Relay 
        <devnull+michael.riesch.wolfvision.net@kernel.org>,
        linux-kernel@vger.kernel.org,
        Matthias Fend <Matthias.Fend@wolfvision.net>,
        libcamera-devel@lists.libcamera.org, linux-media@vger.kernel.org
References: <20230406-feature-controls-lens-v1-0-543189a680de@wolfvision.net>
 <20230406-feature-controls-lens-v1-1-543189a680de@wolfvision.net>
 <CAPY8ntArOOqPQzvkJrQEyuVFfb6j8x6WODTMHOn1qHPU588mbQ@mail.gmail.com>
 <0f1baf5e-2ff6-e10b-5c3e-0a82c71d0ce6@wolfvision.net>
 <CAPY8ntAjBEFfeV6nnQs34Y22QM-irT13ALDv4ksP8AYK=jWsKg@mail.gmail.com>
 <3ab7bfc4-aaae-2e39-b420-40ad8d71dda4@wolfvision.net>
 <CAPY8ntCNuvgmF37kDvVh1kuepbLqy2hWcz9HOi8iub9trHmi2g@mail.gmail.com>
 <ZDbKU5kwcb7RGeCo@kekkonen.localdomain>
From:   Michael Riesch <michael.riesch@wolfvision.net>
In-Reply-To: <ZDbKU5kwcb7RGeCo@kekkonen.localdomain>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K09XNEd0UXRoQlBkL2x0RmphbWovYWxEaCsvbndDTnVQOGUvY3RvQWV3VlJn?=
 =?utf-8?B?aGhkWkduT3RBL1JIL3A0K3F4d2UyTElkR3d1bnFjUWZ2NFlMaVMybGsxbmQr?=
 =?utf-8?B?MGRQVEEvb2V2dWFzMXEyUjhBbDFRdkNmQjJzWndJRHN6M3MyMEMxY3czb3JQ?=
 =?utf-8?B?dlZHRjZvTExiNUY1RGgyekpjMGpsL1d0SWU3bXhBZGJvRmJ1VitENmh3UFlr?=
 =?utf-8?B?bkdXQ01hanl6WGlNcFV2ckhDSjViTVpFblp3V2hVbFpMUndEZFdXU2tlc0Fo?=
 =?utf-8?B?S2tvTm4vaU5HalovdjBDbG1TUEpVVnFVTnNkc0pQejR5dFpyS010eGI4UUpB?=
 =?utf-8?B?R01oL0RzbTN3cWtIajBBOEI4RElMYVQ5TmZIczM2T0ROdmVueDYwVXBMblpC?=
 =?utf-8?B?amUxVG9uL0ExanNGcDZrU0tRVlgzV3l3d0dIelNCUFp4T1M2dWZWUnNLbWov?=
 =?utf-8?B?eW1JdjdhNjVwbm5RQmRBSTU3SjJ5N1p2dUUzakZCKy9WeC9pdmI3Rm9wNjhv?=
 =?utf-8?B?d0ptVFBDNzg3Q1cxcUZNQjFCc3phNjlWaS9PdjlkdEdBNTlYRFlMS1BNV2dm?=
 =?utf-8?B?QlE3ZXZZcXFOeWtwUzJMMVBRNlBKOEF1a2JKRzJaZWhDUkNkNzJ5L3ViOHRO?=
 =?utf-8?B?QlE2NG93MlYwL2pkSVBra3h5dkdIREFpMDRSREFtMCtEZDU5S293NWFUdHMx?=
 =?utf-8?B?bm1MendlSFZWUHluQ3Z4TXBtY1NyQWZSOGo2a1pwSThlNTFFSnB6djBiaDB2?=
 =?utf-8?B?cEh0REd3RXBSN3ZneDE3UDd4NlJUNm8xb1Z0NVJBQmF5NTI5VFYwZ0dGcDBK?=
 =?utf-8?B?Vk54bWd1S3dHcTlmV2dCVGVNbEN6K3RralE2Q1hMVjJtTUdtb2IzYTdDVERI?=
 =?utf-8?B?bkdpUGFhWFZiNk1HK0RaeVJwbUZiNk9xUVA5VE4vMVYrTnFlNnI5L1RyQ3dz?=
 =?utf-8?B?Tnl0QXNiaFBickVTYUZPUEc2SXlPVzdDdEYvNXBZazgrRElnbWVOL0g3RWpv?=
 =?utf-8?B?TkVoT3FWZ0ZLTXRGNEhKaUdiQWFvaytVaW5wQW81ajN0MzMyWkRkZG1NdzhK?=
 =?utf-8?B?dW85MzdaM0k1NVBVQlBndEQzOURwWDVXUklCeVlkK1BhK25pekgrSVdmUCtS?=
 =?utf-8?B?Mm1FVnZCVGttdThSaW5OTkFjRXhram1KMzdUbUJ1VXBEUjFaL3VtT0JTbjJT?=
 =?utf-8?B?VFp1bXc4dmZKNUNleVlUVzcvcEtqRmZoRjYxMU5rbUZsNHdvR2lBOUxqODBy?=
 =?utf-8?B?L05KQ2xBWVlpelljVWRZdWdzOVhuRnV4U25xTkFPN1kvdHR4a1RGNWlkaEoy?=
 =?utf-8?B?QXVySkFJcUdoc0Z1NTVNS3Y3K014Z3JDZHV0RHFVcnNQNGU4cE8xaW5GRFdU?=
 =?utf-8?B?RkMrQTFtUENrb00rK29DOWx5UmE3VUtERFYzODZySzJqV2NKbE5VcDN4cTFO?=
 =?utf-8?B?Sy9RYWY5RlJ3QWJjRGtLcXZ4TTBsc1pHZDVTUnhGMk1uMEQwMStSU3pHYVlJ?=
 =?utf-8?B?cG5QT1cyMGNMejRMakhpdUc3bzZSVVJNN3dRcGwvMHJNMVpxL1RML2NvUVlB?=
 =?utf-8?B?dUttL2FHM1JlV1gwcFlGNGNIaW01cm0xNWVJV2RMeXE1Q25tRmVYWk5KM3Na?=
 =?utf-8?B?TmNnemQ3QXBjWUlIZERlc1NGZUd2QUwraGczeDI2Q3VDZTlIWXdyUThiQm5z?=
 =?utf-8?B?SFZUVy9jaXZrVFY5Z0U3d1ZBM3YwdkdtcTZ3S1Y5V3VZNHNJU0dWaUpIRzN1?=
 =?utf-8?B?TjgyWUtkYzlmZitKR3dSVXJsdVN2TFBFTUVHTGpEZnRCbWhNdy92VTNjVmVI?=
 =?utf-8?B?am9YUmpZd3BSSDhFTXJtRlZmZDArVnV0L0QrMWRBY3UxbUxlVTI0eU1Jcnhr?=
 =?utf-8?B?dmZtbFA5WEliYjdtV0FXYzNmeTk2VGxUU0wxSUNoOW1XMDR2VDQ2Rkx6RVAw?=
 =?utf-8?B?eG11RzNWNFA5NC9aeXJKNnZZTmtPSCsrUlY3dFNWWDY4MjY0U0dtOWhHcnVU?=
 =?utf-8?B?RTluUmZ2cjNldGlBSGZ5TFRSOS9TMTZYeFhhQ3g2SDZSemVRL042MFZRb0x5?=
 =?utf-8?B?dzhnNDV3clVRMk15UHhaeXVLZ2ZHRFJydlFIZTZDYWF6ZnQ0a1B5NDh5OCtO?=
 =?utf-8?B?Nk9CTXJpbHR3ZVpCd3FGQjJ3VFA2dDNTdzhyMmtDZGd1bXNqSVd3K2xUNnZt?=
 =?utf-8?B?SFFCMUw2ZjhXU1lmZk5rZExTS3I5bWxGR2VPeHcwZjFCTTArY3RmbXpheE1h?=
 =?utf-8?B?SmpTcC9xN2lmd0tmTWZKVE1SKzZBPT0=?=
X-OriginatorOrg: wolfvision.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 6fd3abd5-3f68-4a27-e92a-08db3f40a155
X-MS-Exchange-CrossTenant-AuthSource: DU0PR08MB9155.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2023 12:38:22.1916
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: w94QlELEcV0BlAz3juQvKECylqOpGkGVgUKV+tX+W4V+PS54Ot04Hd19+2xnLRceBjobPFPxFUKLJpQJVIlBDPs9th+hbeGhEbAc8ixYD2M=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB5936
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Sakari,

On 4/12/23 17:12, Sakari Ailus wrote:
> Hi Dave, Michael,
> 
> On Wed, Apr 12, 2023 at 02:55:56PM +0100, Dave Stevenson wrote:
>>>> If the ranges aren't updated, where should that out-of-range lens
>>>> movement leave the lens?
>>>
>>> This is up to the hardware controller, but I would guess it typically
>>> stops one step before disaster. Wherever that may be, the error
>>> condition and the current position can be read out via this new STATUS
>>> control.
>>>
>>> Does this sound good so far?
>>
>> Sounds reasonable, but I'm not the gatekeeper (that would be Sakari or
>> Laurent), and I'm just expressing my views based on the lenses I've
>> encountered.
>> All of my lenses have a single drive for focus, a single drive for
>> zoom, and where there are multiple elements they are all connected
>> mechanically. Your setup sounds far more complex and is likely to need
>> a more extensive driver, but it'd be nice to not unnecessarily
>> overcomplicate the interface.
> 
> Could we also have a driver that uses these new controls?

If you are referring to the driver for our custom lens controller, then
I have to say that it is under development and simply not ready for
release yet. Also, the decision has not yet been made whether or not
this will be an open-source driver.

A different approach could be the adaptation of the vimc-lens driver,
which currently only supports FOCUS_ABSOLUTE. But this would raise
several implementation questions and at least for me this would be a
nontrivial task.

Is it required to have a driver for this interface (in the sense that
the patches cannot be accepted otherwise)?

> The controls themselves appear reasonable to me as well. I guess there are
> changes to be made based on the discussion?

I'd summarize that whether or not the status controls are compound
controls of the type V4L2_CTRL_TYPE_LENS_STATUS is the open question.

As a potential follow-up question I recently asked myself if the struct
v4l2_ctrl_lens_status should contain trailing reserved bytes for future
extension (no idea, though, what this could be).

Alternatively, we could come up with "V4L2_CID_FOCUS_CURRENT (integer)"
for the current position and "V4L2_CID_FOCUS_STATUS (bitmask)" (and add
further controls when they are needed. Here, we lose atomicity but maybe
this can be ignored. One could assume that all relevant controls are
read out with a single ioctl which provides at least some level of
atomicity.

Any comments and/or recommendations to this open question would be much
appreciated.

Other review comments will be incorporated in the next iteration of this
series as well, but they are quite straightforward.

Best regards,
Michael