Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 17 Apr 2023 14:51:50 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Vladimir Oltean <vladimir.oltean@nxp.com>
Cc:     netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        UNGLinuxDriver@microchip.com,
        Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 1/7] net: mscc: ocelot: export a single
 ocelot_mm_irq()
Message-ID: <ZD1A5lz63dNEUj7D@corigine.com>
References: <20230415170551.3939607-1-vladimir.oltean@nxp.com>
 <20230415170551.3939607-2-vladimir.oltean@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230415170551.3939607-2-vladimir.oltean@nxp.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Wg7IPPOebr2irYSH3JzSv3dB+HqQESUmjk2v2AUFLzp9Z5HYe53ypnOmPv1j?=
 =?us-ascii?Q?hm/dNuBiPX6eqm9Tqu489Aeu9JoAP9BXOE6Shs3xMVyi6CGJ7T79wXPjg55w?=
 =?us-ascii?Q?191KWo+LQlc/VcuadR4UGx0QKNbAhf4OS6t3CEr6yUCCRm3sMJucW20CdgO8?=
 =?us-ascii?Q?8HtpBKA0Q1FoRzccJ0BmUypUqMekbnLTOpFNRsxf2Bi9ns7Qm+SHmmUYBRU8?=
 =?us-ascii?Q?hjpzMWSqZ9p5b9nhIfk2R0TjtVN4zv2ppB1YVQtUYMVLR5QGFUyOSdgV4Jrc?=
 =?us-ascii?Q?77aVo7NCU6zRVMvEweSAyWaAmwHWp2sqr7fgHLxZjqNCrYdibqfILN1Dg8iq?=
 =?us-ascii?Q?U36ACdE0M4BScibaK9ee92oA5yqui8tgfZJNCbohbmBjJDfne0fgHFQyJpPa?=
 =?us-ascii?Q?9gZJlB1BmxLYupRaLah4gyEcRmMk4l4xs1wmUzYAgL6p2Cm7Cepw3TPwwVUE?=
 =?us-ascii?Q?q3Bl7ABywGjdD3W0fbxiSxD96tdHNoO9E/RDJpHpqHG24PhI5jlU+sVSkIE8?=
 =?us-ascii?Q?mcLan7ZTgvyH9LE1AnJVke6/hT9PClWJ81oRx/Z8NTS6F/AzU36t2w12/ywI?=
 =?us-ascii?Q?jftDLNZfAfYkhik7Ve+z1mVUrS3MzuUgdt0UnowY7KpPGno6iljOcq2Xry6Z?=
 =?us-ascii?Q?DRqTreGqKBwIK9gndvIGDo05tgcP4b1zaewXDiCDRhpP2puanEjKqSqSUcpc?=
 =?us-ascii?Q?FvEsuecHgyh3M0pVWjBvq2iRFl/Va6pAnQSWlyLVtphU5721f27ef4CbtLLT?=
 =?us-ascii?Q?VUDygoiPvVVvQYlBQhZ0KYgnGGrX+ayBFXTUBlpmYcLK2mUDZw0d3M3JP/tr?=
 =?us-ascii?Q?ZzD+wKvpizggvAYklOjzOgUfIVsbDtGqdp49PqPl4Lk2YPZ+bqx5IniLZw12?=
 =?us-ascii?Q?Qr9imdFnAbO7sDF9dWbax5htGkjcbbSXbKBF5bfwx9YPvaSs8FMrBTqYF1J1?=
 =?us-ascii?Q?+DLzUACwJ1G+oU0dtU+C5dctV3qf3HJj/L3BPaFrO0bpEKH4PCm2ZNOyr1Jy?=
 =?us-ascii?Q?y3oS29dRLkVoECer5AZ9Qrf4FTv60OaH/95/wWLRXeb215bvxiqvqJdzIcK5?=
 =?us-ascii?Q?psvQLv/9e7tFdD/nu/OwLhXku7G0eRluqDy3Zvq6ghFZFu2ROKa1T7i8W00w?=
 =?us-ascii?Q?99tEYTyZCeI+VjQDe2wkJAP4xKqNn4CSC2FpHkS+fO6saCzQ07T05glQiRnA?=
 =?us-ascii?Q?j3Ysn7DCElQ9GFRbtgY/KzTqjp90qnIZ+z+zGIUqWPaMz/M08EZFiyuwGt0P?=
 =?us-ascii?Q?cXjfzHjKpF1nOOyc+AUZriPpsgZGA2Y8XsRHKMsH5aK7ajnj+Kj8WoPT2xlH?=
 =?us-ascii?Q?AkVTGKr9cCiF19HhdMNkQGZqDQnxDSTKpptm9Z0hnyXrfJ1cvA+UoSbMEwet?=
 =?us-ascii?Q?zY+j0tQypRQOCoGHTigNhoKrOpU89uMDc4h0qCH/ZNGWj2BHHNVsJsn9z1CL?=
 =?us-ascii?Q?2w3l4UcMa0G15dLmvCEdv/WPbxFxdGk5ly4Lg9Cp5Rf96XlCLHUmcyyAIAqA?=
 =?us-ascii?Q?VWLAyvYiM5BHJtSoYJE8PIlSrH6adIrCw8xVVuY5AK7T/Lv+ea1HlHECa7FL?=
 =?us-ascii?Q?30BclCfB0EGjhChFugaFObWlgvPK8cT7Q9+L1u3z3qgzomjC+KMY0rrkB+Uz?=
 =?us-ascii?Q?gGw6U2Iq5dEDOrnP+DkDgIRV3LWrlZC10Op1YRSr5X8MJroY7b8sUcm6MqRY?=
 =?us-ascii?Q?wXKmtg=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 87e51a57-c812-40e6-5b2f-08db3f428708
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2023 12:51:57.2135
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zqTW+O0vl2vgOC2QEJZeoYPJT+yPZ89VRH0lHgWmOG+UV1dcl5AabzkAKVPTpRxZD6kauQH3Sx+GucHVagO+tHodf0P/LbaAhrF6B9c759M=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR13MB5757
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Apr 15, 2023 at 08:05:45PM +0300, Vladimir Oltean wrote:
> When the switch emits an IRQ, we don't know what caused it, and we
> iterate through all ports to check the MAC Merge status.
> 
> Move that iteration inside the ocelot lib; we will change the locking in
> a future change and it would be good to encapsulate that lock completely
> within the ocelot lib.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>