Received: by 2002:a05:6358:53a8:b0:117:f937:c515 with SMTP id z40csp3964949rwe; Mon, 17 Apr 2023 06:15:48 -0700 (PDT) X-Google-Smtp-Source: AKy350ZpMEGhZlrXlpr/M263q39I5haATZRs8zhlsdofK6IYFE2QGWnyg73Rydebv5wRDE1RIldq X-Received: by 2002:a05:6a20:72a2:b0:ef:f886:768b with SMTP id o34-20020a056a2072a200b000eff886768bmr3034189pzk.32.1681737347853; Mon, 17 Apr 2023 06:15:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681737347; cv=none; d=google.com; s=arc-20160816; b=RiGAVAYpN+SpKbQn8zliSSHFPN3fCDVm4JMA+nVjJvnflc+puH/pFZYZEr7MqfI5SE zz22k8LbLKeO4RYVBk7OTS1qFaqRgBdSeBit4pD2k7l0tg+TilYsz3HYtCHo8dIxs6Nb 2KTmBRby8q1tlxEme76QiauYPMZaS2xK8ZfheCAb/C5zh4SIRxMqegMsgN0BufvvspsD 98sruRdzPTyG4JqB1U2G2XOcdwHabrcZ84PMXUi0ORFSyAmvaRRYjWqaErKk/aq4KzCo yzy9ylcgZToDPHGLo+R+J3qHAwYKdi3l6LeNdGYmFMTnnubnNX5cQNU2QCl5cPq9zn9K BZIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=e2nbVjTG+rwOLIIWdYvkuFGThNWk4ROtsmXtB/FlaiQ=; b=qCtxMnKW/tMFG5k5iCiCi87TuOC7aCtexuzdBoLrqn8otpquMcYdtjj+bWcWKgldd6 W62xcwtt/TZEiyTbFW6uXsFm8wnJvliHXmRo3xs9jXmqcJRfdIGoaHJSAgAWWgGrrZtm puuZDRUe2RWSq8m81sXHnq9t+/RXBQGSF+AxOBfjk5FsMS6wUYfiX2gsVKI9TtyDfLp4 z/Xg9UBIj88fVhzciH+RVilTl/Zf5c8eD9MnWgSO1K30+8r+WFOC6Xx8WgxOBa2mMP8e 89BKRvIn1GJc1NXTM0HK5do7hrkDSoiTyp2H1EiwcJ9NhN7jkTQMqRdhFcPCbQ4+EeFt beRw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=GRPh4oRa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t190-20020a6381c7000000b0051b5de41857si10962714pgd.101.2023.04.17.06.15.35; Mon, 17 Apr 2023 06:15:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=GRPh4oRa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229781AbjDQNJh (ORCPT + 99 others); Mon, 17 Apr 2023 09:09:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229688AbjDQNJX (ORCPT ); Mon, 17 Apr 2023 09:09:23 -0400 Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C2F8BB84 for ; Mon, 17 Apr 2023 06:08:20 -0700 (PDT) Received: by mail-pl1-x629.google.com with SMTP id w1so2735544plg.6 for ; Mon, 17 Apr 2023 06:08:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1681736851; x=1684328851; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=e2nbVjTG+rwOLIIWdYvkuFGThNWk4ROtsmXtB/FlaiQ=; b=GRPh4oRaAQNCW+Xy26biO1ezbnOT6FVEi2bJ554bozSaVO5cvtCICTkzvPcnKaOwMj xBlUjW0fh7gjbt+uO2YYE337FASfH1ycpy0PZgdtuTSxU06XN9eKc3BF2JbB84raTt0Q yeerFjzgOw4Ut0+51iZK/UC/WSwSc/EyymADM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681736851; x=1684328851; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=e2nbVjTG+rwOLIIWdYvkuFGThNWk4ROtsmXtB/FlaiQ=; b=TeOTtJRejCgyr8N42OygA6Oa+uQtf/IJzpqhYfl7TE7z7dRZyjRPnxRh1sskVDsG2D bJaYcv01L+7Er8I7xE3QlvCcm2I/07/r9GvmAuCcvK8BZ+83Pds7Eum5oULEGR8Q70Yx /usd7G+e8SsAJ2le0kZSPnmnd7tlmWizRMftZsha2bKpZUCNLipkDsMSk0NuTDfmTTI0 G09CU0Jwl1XywE1AYj67dj9qhy179Yr9I0jZjOaQ1X/f1IwuOThB46uvWCEANqtEQ4/0 AxxSU1eKKL2eN45AJtXAdlmeyv5F5Ims5UnZILNpOonOfkjo377FmmbSV9NRn6Kd3JSc zu9g== X-Gm-Message-State: AAQBX9ejPWuiUhFxkzyt1LNg+Ggw+7ofXkW77YAXbkmXz4n+Kkmavy7h jFtnQbh9ktPGhmWbmZOWc6FKBA== X-Received: by 2002:a17:902:fb04:b0:1a6:97fd:29e7 with SMTP id le4-20020a170902fb0400b001a697fd29e7mr11195216plb.27.1681736851187; Mon, 17 Apr 2023 06:07:31 -0700 (PDT) Received: from google.com (KD124209188001.ppp-bb.dion.ne.jp. [124.209.188.1]) by smtp.gmail.com with ESMTPSA id 4-20020a170902c10400b001a194df5a58sm3590623pli.167.2023.04.17.06.07.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Apr 2023 06:07:30 -0700 (PDT) Date: Mon, 17 Apr 2023 22:07:26 +0900 From: Sergey Senozhatsky To: Yosry Ahmed Cc: Sergey Senozhatsky , Andrew Morton , Yu Zhao , Minchan Kim , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] zsmalloc: reset compaction source zspage pointer after putback_zspage() Message-ID: <20230417130726.GQ25053@google.com> References: <20230304034835.2082479-4-senozhatsky@chromium.org> <20230417050140.1653593-1-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On (23/04/17 04:43), Yosry Ahmed wrote: > wrote: > > > > Fixup. > > I think the original patch landed in mm-stable already, so we might > want a proper commit log and fixes tag. > > I suspect we want: > Fixes: 5a845e9f2d66 ("zsmalloc: rework compaction algorithm") Oh, OK, let me send out a proper patch, just in case. > > > > Reported-by: Yu Zhao > > Signed-off-by: Sergey Senozhatsky > > Otherwise, LGTM. > > Reviewed-by: Yosry Ahmed Thanks.